[GitHub] [kafka] lucasbru commented on a diff in pull request #13025: KAFKA-14299: Make sure no progress is made on paused topologies

[GitBox <gi...@apache.org>]

lucasbru commented on code in PR #13025:
URL: https://github.com/apache/kafka/pull/13025#discussion_r1067891929


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -276,6 +276,11 @@ private void addTask(final Task task) {
                         changelogReader.transitToUpdateStandby();
                     }
                 }
+
+                // Move task to paused tasks immediately to not make any progress
+                if (topologyMetadata.isPaused(task.id().topologyName())) {
+                    pauseTask(task);

Review Comment:
   Done. But I also had to make more changes to make resuming reliable. I have to wake up the state updater thread when a topology is resumed, to make sure that the state updater does in fact resume the task



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org