You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/31 06:31:10 UTC

[GitHub] [flink] JingsongLi opened a new pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

JingsongLi opened a new pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730
 
 
   
   ## What is the purpose of the change
   
   The vector api of Hive 1.x version are totally different from hive 2+.
   So we need introduce more efforts to support vectorized read for hive 1.x.
   
   ## Brief change log
   
   - Introduce flink-orc-nohive module
   - Introduce orc vectors
   - Introduce NoHiveOrcShim
   - Introduce nohive orc OrcSplitReaderUtil
   - Integrate hive to flink-orc-nohive
   
   ## Verifying this change
   
   This change is already covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): yes
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): yes
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented? JavaDocs

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-569879082
 
 
   <!--
   Meta data
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142725335 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143843124 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143851936 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:f59ef58b40daaf5f7fd81d971e06983bca92d0bf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147655079 TriggerType:PUSH TriggerID:f59ef58b40daaf5f7fd81d971e06983bca92d0bf
   Hash:f59ef58b40daaf5f7fd81d971e06983bca92d0bf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4883 TriggerType:PUSH TriggerID:f59ef58b40daaf5f7fd81d971e06983bca92d0bf
   Hash:610f35b473db99f0d4d6e7d2cbfecda288ffcfea Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147675567 TriggerType:PUSH TriggerID:610f35b473db99f0d4d6e7d2cbfecda288ffcfea
   Hash:610f35b473db99f0d4d6e7d2cbfecda288ffcfea Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4887 TriggerType:PUSH TriggerID:610f35b473db99f0d4d6e7d2cbfecda288ffcfea
   Hash:41445892ce21d63b9ac08dafa23d33ca98d0093c Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/148176567 TriggerType:PUSH TriggerID:41445892ce21d63b9ac08dafa23d33ca98d0093c
   Hash:41445892ce21d63b9ac08dafa23d33ca98d0093c Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4998 TriggerType:PUSH TriggerID:41445892ce21d63b9ac08dafa23d33ca98d0093c
   -->
   ## CI report:
   
   * 753a9d8bd5705954a67133f2780617ac936a8737 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142725335) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004) 
   * 61d1841804ed500402856aee88654a32730f56db Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143843124) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244) 
   * eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143851936) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248) 
   * f59ef58b40daaf5f7fd81d971e06983bca92d0bf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147655079) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4883) 
   * 610f35b473db99f0d4d6e7d2cbfecda288ffcfea Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147675567) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4887) 
   * 41445892ce21d63b9ac08dafa23d33ca98d0093c Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/148176567) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4998) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-569879082
 
 
   <!--
   Meta data
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142725335 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143843124 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143851936 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:f59ef58b40daaf5f7fd81d971e06983bca92d0bf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147655079 TriggerType:PUSH TriggerID:f59ef58b40daaf5f7fd81d971e06983bca92d0bf
   Hash:f59ef58b40daaf5f7fd81d971e06983bca92d0bf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4883 TriggerType:PUSH TriggerID:f59ef58b40daaf5f7fd81d971e06983bca92d0bf
   Hash:610f35b473db99f0d4d6e7d2cbfecda288ffcfea Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147675567 TriggerType:PUSH TriggerID:610f35b473db99f0d4d6e7d2cbfecda288ffcfea
   Hash:610f35b473db99f0d4d6e7d2cbfecda288ffcfea Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4887 TriggerType:PUSH TriggerID:610f35b473db99f0d4d6e7d2cbfecda288ffcfea
   -->
   ## CI report:
   
   * 753a9d8bd5705954a67133f2780617ac936a8737 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142725335) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004) 
   * 61d1841804ed500402856aee88654a32730f56db Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143843124) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244) 
   * eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143851936) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248) 
   * f59ef58b40daaf5f7fd81d971e06983bca92d0bf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147655079) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4883) 
   * 610f35b473db99f0d4d6e7d2cbfecda288ffcfea Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147675567) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4887) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-569873920
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 753a9d8bd5705954a67133f2780617ac936a8737 (Tue Dec 31 06:34:14 UTC 2019)
   
   **Warnings:**
    * **3 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#discussion_r377429861
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/read/HiveVectorizedOrcSplitReader.java
 ##########
 @@ -62,18 +62,30 @@ public HiveVectorizedOrcSplitReader(
 			throw new IllegalArgumentException("Unknown split type: " + hadoopSplit);
 		}
 
-		this.reader = genPartColumnarRowReader(
-				hiveVersion,
-				conf,
-				fieldNames,
-				fieldTypes,
-				split.getHiveTablePartition().getPartitionSpec(),
-				selectedFields,
-				new ArrayList<>(),
-				DEFAULT_SIZE,
-				new Path(fileSplit.getPath().toString()),
-				fileSplit.getStart(),
-				fileSplit.getLength());
+		this.reader = hiveVersion.startsWith("1.") ?
+				OrcNoHiveSplitReaderUtil.genPartColumnarRowReader(
+						conf,
+						fieldNames,
+						fieldTypes,
+						split.getHiveTablePartition().getPartitionSpec(),
+						selectedFields,
+						new ArrayList<>(),
+						DEFAULT_SIZE,
+						new Path(fileSplit.getPath().toString()),
+						fileSplit.getStart(),
+						fileSplit.getLength()) :
+				org.apache.flink.orc.OrcSplitReaderUtil.genPartColumnarRowReader(
 
 Review comment:
   I don't think we need the full package path here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] bowenli86 closed pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
bowenli86 closed pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-569879082
 
 
   <!--
   Meta data
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142725335 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143843124 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   -->
   ## CI report:
   
   * 753a9d8bd5705954a67133f2780617ac936a8737 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142725335) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004) 
   * 61d1841804ed500402856aee88654a32730f56db Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143843124) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244) 
   * eebae70efc64285b9b3a9a8f42c2caeea09a33b2 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#discussion_r376233882
 
 

 ##########
 File path: flink-formats/flink-orc/src/main/java/org/apache/flink/orc/OrcSplitReader.java
 ##########
 @@ -44,23 +44,23 @@
  * Orc split reader to read record from orc file. The reader is only responsible for reading the data
  * of a single split.
  */
-public abstract class OrcSplitReader<T> implements Closeable {
+public abstract class OrcSplitReader<T, BATCH extends OrcVectorizedBatch> implements Closeable {
 
 	private final OrcShim shim;
 
 Review comment:
   `OrcShim<BATCH>`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-569879082
 
 
   <!--
   Meta data
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142725335 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143843124 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143851936 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:f59ef58b40daaf5f7fd81d971e06983bca92d0bf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147655079 TriggerType:PUSH TriggerID:f59ef58b40daaf5f7fd81d971e06983bca92d0bf
   Hash:f59ef58b40daaf5f7fd81d971e06983bca92d0bf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4883 TriggerType:PUSH TriggerID:f59ef58b40daaf5f7fd81d971e06983bca92d0bf
   Hash:610f35b473db99f0d4d6e7d2cbfecda288ffcfea Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147675567 TriggerType:PUSH TriggerID:610f35b473db99f0d4d6e7d2cbfecda288ffcfea
   Hash:610f35b473db99f0d4d6e7d2cbfecda288ffcfea Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4887 TriggerType:PUSH TriggerID:610f35b473db99f0d4d6e7d2cbfecda288ffcfea
   Hash:41445892ce21d63b9ac08dafa23d33ca98d0093c Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148176567 TriggerType:PUSH TriggerID:41445892ce21d63b9ac08dafa23d33ca98d0093c
   Hash:41445892ce21d63b9ac08dafa23d33ca98d0093c Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4998 TriggerType:PUSH TriggerID:41445892ce21d63b9ac08dafa23d33ca98d0093c
   Hash:196ed2a9d918bb7f93277e50eb0b24323700e082 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:196ed2a9d918bb7f93277e50eb0b24323700e082
   -->
   ## CI report:
   
   * 753a9d8bd5705954a67133f2780617ac936a8737 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142725335) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004) 
   * 61d1841804ed500402856aee88654a32730f56db Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143843124) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244) 
   * eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143851936) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248) 
   * f59ef58b40daaf5f7fd81d971e06983bca92d0bf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147655079) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4883) 
   * 610f35b473db99f0d4d6e7d2cbfecda288ffcfea Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147675567) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4887) 
   * 41445892ce21d63b9ac08dafa23d33ca98d0093c Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/148176567) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4998) 
   * 196ed2a9d918bb7f93277e50eb0b24323700e082 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-569879082
 
 
   <!--
   Meta data
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142725335 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143843124 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143851936 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   -->
   ## CI report:
   
   * 753a9d8bd5705954a67133f2780617ac936a8737 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142725335) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004) 
   * 61d1841804ed500402856aee88654a32730f56db Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143843124) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244) 
   * eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143851936) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-569879082
 
 
   <!--
   Meta data
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142725335 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:61d1841804ed500402856aee88654a32730f56db Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   -->
   ## CI report:
   
   * 753a9d8bd5705954a67133f2780617ac936a8737 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142725335) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004) 
   * 61d1841804ed500402856aee88654a32730f56db UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-569879082
 
 
   <!--
   Meta data
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142725335 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143843124 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143851936 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:f59ef58b40daaf5f7fd81d971e06983bca92d0bf Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:f59ef58b40daaf5f7fd81d971e06983bca92d0bf
   -->
   ## CI report:
   
   * 753a9d8bd5705954a67133f2780617ac936a8737 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142725335) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004) 
   * 61d1841804ed500402856aee88654a32730f56db Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143843124) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244) 
   * eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143851936) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248) 
   * f59ef58b40daaf5f7fd81d971e06983bca92d0bf UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-569879082
 
 
   <!--
   Meta data
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142725335 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143843124 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   -->
   ## CI report:
   
   * 753a9d8bd5705954a67133f2780617ac936a8737 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142725335) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004) 
   * 61d1841804ed500402856aee88654a32730f56db Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143843124) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-569879082
 
 
   <!--
   Meta data
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142725335 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   -->
   ## CI report:
   
   * 753a9d8bd5705954a67133f2780617ac936a8737 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142725335) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-569879082
 
 
   <!--
   Meta data
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142725335 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143843124 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143851936 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   -->
   ## CI report:
   
   * 753a9d8bd5705954a67133f2780617ac936a8737 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142725335) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004) 
   * 61d1841804ed500402856aee88654a32730f56db Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143843124) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244) 
   * eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143851936) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#discussion_r376299123
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/pom.xml
 ##########
 @@ -701,6 +713,7 @@ under the License.
 								<includes combine.children="append">
 									<include>org.apache.flink:flink-hadoop-fs</include>
 									<include>org.apache.flink:flink-orc_${scala.binary.version}</include>
+									<include>org.apache.flink:flink-orc-nohive_${scala.binary.version}</include>
 
 Review comment:
   I think we can remove this words, it seems we don't need tell users?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-582712920
 
 
   Need update document, hive 1.X need this jars:
   ```
   orc-core-1.4.3-nohive.jar
   aircompressor-0.8.jar
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#discussion_r376196822
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/pom.xml
 ##########
 @@ -701,6 +713,7 @@ under the License.
 								<includes combine.children="append">
 									<include>org.apache.flink:flink-hadoop-fs</include>
 									<include>org.apache.flink:flink-orc_${scala.binary.version}</include>
+									<include>org.apache.flink:flink-orc-nohive_${scala.binary.version}</include>
 
 Review comment:
   Update the Hive dep docs to indicate flink-connector-hive now contains flink-orc-nohive?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-584075641
 
 
   Thanks @lirui-apache for your review, updated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#discussion_r376232416
 
 

 ##########
 File path: flink-formats/flink-orc-nohive/src/main/java/org/apache/flink/orc/nohive/vector/AbstractOrcColumnVector.java
 ##########
 @@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.orc.nohive.vector;
+
+import org.apache.flink.table.types.logical.DecimalType;
+import org.apache.flink.table.types.logical.LogicalType;
+
+import org.apache.orc.storage.common.type.HiveDecimal;
+import org.apache.orc.storage.ql.exec.vector.BytesColumnVector;
+import org.apache.orc.storage.ql.exec.vector.ColumnVector;
+import org.apache.orc.storage.ql.exec.vector.DecimalColumnVector;
+import org.apache.orc.storage.ql.exec.vector.DoubleColumnVector;
+import org.apache.orc.storage.ql.exec.vector.LongColumnVector;
+import org.apache.orc.storage.ql.exec.vector.TimestampColumnVector;
+
+import java.math.BigDecimal;
+import java.nio.charset.StandardCharsets;
+import java.sql.Date;
+import java.sql.Timestamp;
+import java.time.LocalDate;
+import java.time.LocalDateTime;
+
+import static org.apache.flink.table.runtime.functions.SqlDateTimeUtils.dateToInternal;
+
+/**
+ * This column vector is used to adapt hive's ColumnVector to Flink's ColumnVector.
+ */
+public abstract class AbstractOrcColumnVector implements
+		org.apache.flink.table.dataformat.vector.ColumnVector {
+
+	private ColumnVector vector;
+
+	AbstractOrcColumnVector(ColumnVector vector) {
+		this.vector = vector;
+	}
+
+	@Override
+	public boolean isNullAt(int i) {
+		return !vector.noNulls && vector.isNull[vector.isRepeating ? 0 : i];
+	}
+
+	@Override
+	public void reset() {
+		throw new UnsupportedOperationException();
+	}
+
+	public static org.apache.flink.table.dataformat.vector.ColumnVector createVector(
+			ColumnVector vector) {
+		if (vector instanceof LongColumnVector) {
+			return new OrcLongColumnVector((LongColumnVector) vector);
+		} else if (vector instanceof DoubleColumnVector) {
+			return new OrcDoubleColumnVector((DoubleColumnVector) vector);
+		} else if (vector instanceof BytesColumnVector) {
+			return new OrcBytesColumnVector((BytesColumnVector) vector);
+		} else if (vector instanceof DecimalColumnVector) {
+			return new OrcDecimalColumnVector((DecimalColumnVector) vector);
+		} else if (vector instanceof TimestampColumnVector) {
+			return new OrcTimestampColumnVector((TimestampColumnVector) vector);
+		} else {
+			throw new UnsupportedOperationException("Unsupport vector: " + vector.getClass().getName());
+		}
+	}
+
+	/**
+	 * Create flink vector by hive vector from constant.
+	 */
+	public static org.apache.flink.table.dataformat.vector.ColumnVector createVectorFromConstant(
 
 Review comment:
   Rename to `createFlinkVectorFromConstant `?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-582721697
 
 
   Verified at cluster.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-569879082
 
 
   <!--
   Meta data
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142725335 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143843124 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143851936 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:f59ef58b40daaf5f7fd81d971e06983bca92d0bf Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147655079 TriggerType:PUSH TriggerID:f59ef58b40daaf5f7fd81d971e06983bca92d0bf
   Hash:f59ef58b40daaf5f7fd81d971e06983bca92d0bf Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4883 TriggerType:PUSH TriggerID:f59ef58b40daaf5f7fd81d971e06983bca92d0bf
   -->
   ## CI report:
   
   * 753a9d8bd5705954a67133f2780617ac936a8737 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142725335) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004) 
   * 61d1841804ed500402856aee88654a32730f56db Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143843124) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244) 
   * eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143851936) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248) 
   * f59ef58b40daaf5f7fd81d971e06983bca92d0bf Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147655079) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4883) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-584462175
 
 
   Thanks for updating. LGTM. Just left some minor comments.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#discussion_r376305666
 
 

 ##########
 File path: flink-formats/flink-orc/src/main/java/org/apache/flink/orc/vector/OrcVectorizedBatch.java
 ##########
 @@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.orc.vector;
+
+/**
+ * Interface to unify orc reader in hive and orc reader without hive dependents.
+ */
+public interface OrcVectorizedBatch {
 
 Review comment:
   It seems we don't need interface now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-583265783
 
 
   @JingsongLi Thanks for working on this. PR LGTM overall.
   One suggestion is to avoid giving classes in `flink-orc` and `flink-orc-nohive` the same name. IMO we already have too many classes sharing the same name in Flink, which makes the code awfully unreadable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-569879082
 
 
   <!--
   Meta data
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142725335 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143843124 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:61d1841804ed500402856aee88654a32730f56db Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   -->
   ## CI report:
   
   * 753a9d8bd5705954a67133f2780617ac936a8737 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142725335) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004) 
   * 61d1841804ed500402856aee88654a32730f56db Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143843124) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#discussion_r376203398
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/read/HiveVectorizedOrcSplitReader.java
 ##########
 @@ -62,18 +61,30 @@ public HiveVectorizedOrcSplitReader(
 			throw new IllegalArgumentException("Unknown split type: " + hadoopSplit);
 		}
 
-		this.reader = genPartColumnarRowReader(
-				hiveVersion,
-				conf,
-				fieldNames,
-				fieldTypes,
-				split.getHiveTablePartition().getPartitionSpec(),
-				selectedFields,
-				new ArrayList<>(),
-				DEFAULT_SIZE,
-				new Path(fileSplit.getPath().toString()),
-				fileSplit.getStart(),
-				fileSplit.getLength());
+		this.reader = hiveVersion.startsWith("1.") ?
+				org.apache.flink.orc.nohive.OrcSplitReaderUtil.genPartColumnarRowReader(
 
 Review comment:
   Can we have a different class name like `OrcNoHiveSplitReaderUtil `? Having to differentiate classes by package path is not very friendly to developers.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#discussion_r376232303
 
 

 ##########
 File path: flink-formats/flink-orc-nohive/src/main/java/org/apache/flink/orc/nohive/vector/AbstractOrcColumnVector.java
 ##########
 @@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.orc.nohive.vector;
+
+import org.apache.flink.table.types.logical.DecimalType;
+import org.apache.flink.table.types.logical.LogicalType;
+
+import org.apache.orc.storage.common.type.HiveDecimal;
+import org.apache.orc.storage.ql.exec.vector.BytesColumnVector;
+import org.apache.orc.storage.ql.exec.vector.ColumnVector;
+import org.apache.orc.storage.ql.exec.vector.DecimalColumnVector;
+import org.apache.orc.storage.ql.exec.vector.DoubleColumnVector;
+import org.apache.orc.storage.ql.exec.vector.LongColumnVector;
+import org.apache.orc.storage.ql.exec.vector.TimestampColumnVector;
+
+import java.math.BigDecimal;
+import java.nio.charset.StandardCharsets;
+import java.sql.Date;
+import java.sql.Timestamp;
+import java.time.LocalDate;
+import java.time.LocalDateTime;
+
+import static org.apache.flink.table.runtime.functions.SqlDateTimeUtils.dateToInternal;
+
+/**
+ * This column vector is used to adapt hive's ColumnVector to Flink's ColumnVector.
+ */
+public abstract class AbstractOrcColumnVector implements
+		org.apache.flink.table.dataformat.vector.ColumnVector {
+
+	private ColumnVector vector;
+
+	AbstractOrcColumnVector(ColumnVector vector) {
+		this.vector = vector;
+	}
+
+	@Override
+	public boolean isNullAt(int i) {
+		return !vector.noNulls && vector.isNull[vector.isRepeating ? 0 : i];
+	}
+
+	@Override
+	public void reset() {
+		throw new UnsupportedOperationException();
+	}
+
+	public static org.apache.flink.table.dataformat.vector.ColumnVector createVector(
 
 Review comment:
   Rename to `createFlinkVector`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-569879082
 
 
   <!--
   Meta data
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142725335 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143843124 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143851936 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:f59ef58b40daaf5f7fd81d971e06983bca92d0bf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147655079 TriggerType:PUSH TriggerID:f59ef58b40daaf5f7fd81d971e06983bca92d0bf
   Hash:f59ef58b40daaf5f7fd81d971e06983bca92d0bf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4883 TriggerType:PUSH TriggerID:f59ef58b40daaf5f7fd81d971e06983bca92d0bf
   Hash:610f35b473db99f0d4d6e7d2cbfecda288ffcfea Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147675567 TriggerType:PUSH TriggerID:610f35b473db99f0d4d6e7d2cbfecda288ffcfea
   Hash:610f35b473db99f0d4d6e7d2cbfecda288ffcfea Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4887 TriggerType:PUSH TriggerID:610f35b473db99f0d4d6e7d2cbfecda288ffcfea
   Hash:41445892ce21d63b9ac08dafa23d33ca98d0093c Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148176567 TriggerType:PUSH TriggerID:41445892ce21d63b9ac08dafa23d33ca98d0093c
   Hash:41445892ce21d63b9ac08dafa23d33ca98d0093c Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4998 TriggerType:PUSH TriggerID:41445892ce21d63b9ac08dafa23d33ca98d0093c
   -->
   ## CI report:
   
   * 753a9d8bd5705954a67133f2780617ac936a8737 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142725335) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004) 
   * 61d1841804ed500402856aee88654a32730f56db Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143843124) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244) 
   * eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143851936) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248) 
   * f59ef58b40daaf5f7fd81d971e06983bca92d0bf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147655079) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4883) 
   * 610f35b473db99f0d4d6e7d2cbfecda288ffcfea Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147675567) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4887) 
   * 41445892ce21d63b9ac08dafa23d33ca98d0093c Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/148176567) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4998) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-569879082
 
 
   <!--
   Meta data
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142725335 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143843124 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143851936 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:f59ef58b40daaf5f7fd81d971e06983bca92d0bf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147655079 TriggerType:PUSH TriggerID:f59ef58b40daaf5f7fd81d971e06983bca92d0bf
   Hash:f59ef58b40daaf5f7fd81d971e06983bca92d0bf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4883 TriggerType:PUSH TriggerID:f59ef58b40daaf5f7fd81d971e06983bca92d0bf
   Hash:610f35b473db99f0d4d6e7d2cbfecda288ffcfea Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147675567 TriggerType:PUSH TriggerID:610f35b473db99f0d4d6e7d2cbfecda288ffcfea
   Hash:610f35b473db99f0d4d6e7d2cbfecda288ffcfea Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4887 TriggerType:PUSH TriggerID:610f35b473db99f0d4d6e7d2cbfecda288ffcfea
   Hash:41445892ce21d63b9ac08dafa23d33ca98d0093c Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148176567 TriggerType:PUSH TriggerID:41445892ce21d63b9ac08dafa23d33ca98d0093c
   Hash:41445892ce21d63b9ac08dafa23d33ca98d0093c Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4998 TriggerType:PUSH TriggerID:41445892ce21d63b9ac08dafa23d33ca98d0093c
   -->
   ## CI report:
   
   * 753a9d8bd5705954a67133f2780617ac936a8737 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142725335) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004) 
   * 61d1841804ed500402856aee88654a32730f56db Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143843124) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244) 
   * eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143851936) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248) 
   * f59ef58b40daaf5f7fd81d971e06983bca92d0bf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147655079) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4883) 
   * 610f35b473db99f0d4d6e7d2cbfecda288ffcfea Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147675567) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4887) 
   * 41445892ce21d63b9ac08dafa23d33ca98d0093c Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/148176567) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4998) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-569879082
 
 
   <!--
   Meta data
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142725335 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   -->
   ## CI report:
   
   * 753a9d8bd5705954a67133f2780617ac936a8737 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142725335) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-582719615
 
 
   CC: @lirui-apache 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-569879082
 
 
   <!--
   Meta data
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   -->
   ## CI report:
   
   * 753a9d8bd5705954a67133f2780617ac936a8737 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-569879082
 
 
   <!--
   Meta data
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142725335 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   -->
   ## CI report:
   
   * 753a9d8bd5705954a67133f2780617ac936a8737 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142725335) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-569879082
 
 
   <!--
   Meta data
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142725335 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143843124 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143851936 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:f59ef58b40daaf5f7fd81d971e06983bca92d0bf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147655079 TriggerType:PUSH TriggerID:f59ef58b40daaf5f7fd81d971e06983bca92d0bf
   Hash:f59ef58b40daaf5f7fd81d971e06983bca92d0bf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4883 TriggerType:PUSH TriggerID:f59ef58b40daaf5f7fd81d971e06983bca92d0bf
   Hash:610f35b473db99f0d4d6e7d2cbfecda288ffcfea Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:610f35b473db99f0d4d6e7d2cbfecda288ffcfea
   -->
   ## CI report:
   
   * 753a9d8bd5705954a67133f2780617ac936a8737 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142725335) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004) 
   * 61d1841804ed500402856aee88654a32730f56db Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143843124) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244) 
   * eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143851936) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248) 
   * f59ef58b40daaf5f7fd81d971e06983bca92d0bf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147655079) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4883) 
   * 610f35b473db99f0d4d6e7d2cbfecda288ffcfea UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#discussion_r376237004
 
 

 ##########
 File path: flink-formats/flink-orc/src/main/java/org/apache/flink/orc/SplitReader.java
 ##########
 @@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.orc;
+
+import java.io.Closeable;
+import java.io.IOException;
+
+/**
+ * Split reader to read record from files. The reader is only responsible for reading the data
+ * of a single split.
+ */
+public interface SplitReader<T> extends Closeable {
 
 Review comment:
   I don't see how this class is used?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#discussion_r376305666
 
 

 ##########
 File path: flink-formats/flink-orc/src/main/java/org/apache/flink/orc/vector/OrcVectorizedBatch.java
 ##########
 @@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.orc.vector;
+
+/**
+ * Interface to unify orc reader in hive and orc reader without hive dependents.
+ */
+public interface OrcVectorizedBatch {
 
 Review comment:
   It seems we don't need interface now. Just a real wrapper class is OK.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#discussion_r376239553
 
 

 ##########
 File path: flink-formats/flink-orc/src/main/java/org/apache/flink/orc/vector/OrcVectorizedBatch.java
 ##########
 @@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.orc.vector;
+
+/**
+ * Interface to unify orc reader in hive and orc reader without hive dependents.
+ */
+public interface OrcVectorizedBatch {
 
 Review comment:
   I find this interface a little strange because it doesn't have any API to retrieve the vectorized batch, which means how this interface should be used depends on implementations. How about modify it like:
   ```
   public interface OrcVectorizedBatchWrapper<T> {
       T getBatch();
       int size();
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-569879082
 
 
   <!--
   Meta data
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142725335 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143843124 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143851936 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:f59ef58b40daaf5f7fd81d971e06983bca92d0bf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147655079 TriggerType:PUSH TriggerID:f59ef58b40daaf5f7fd81d971e06983bca92d0bf
   Hash:f59ef58b40daaf5f7fd81d971e06983bca92d0bf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4883 TriggerType:PUSH TriggerID:f59ef58b40daaf5f7fd81d971e06983bca92d0bf
   Hash:610f35b473db99f0d4d6e7d2cbfecda288ffcfea Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147675567 TriggerType:PUSH TriggerID:610f35b473db99f0d4d6e7d2cbfecda288ffcfea
   Hash:610f35b473db99f0d4d6e7d2cbfecda288ffcfea Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4887 TriggerType:PUSH TriggerID:610f35b473db99f0d4d6e7d2cbfecda288ffcfea
   -->
   ## CI report:
   
   * 753a9d8bd5705954a67133f2780617ac936a8737 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142725335) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004) 
   * 61d1841804ed500402856aee88654a32730f56db Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143843124) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244) 
   * eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143851936) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248) 
   * f59ef58b40daaf5f7fd81d971e06983bca92d0bf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147655079) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4883) 
   * 610f35b473db99f0d4d6e7d2cbfecda288ffcfea Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147675567) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4887) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-569879082
 
 
   <!--
   Meta data
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142725335 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143843124 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143851936 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:f59ef58b40daaf5f7fd81d971e06983bca92d0bf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147655079 TriggerType:PUSH TriggerID:f59ef58b40daaf5f7fd81d971e06983bca92d0bf
   Hash:f59ef58b40daaf5f7fd81d971e06983bca92d0bf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4883 TriggerType:PUSH TriggerID:f59ef58b40daaf5f7fd81d971e06983bca92d0bf
   -->
   ## CI report:
   
   * 753a9d8bd5705954a67133f2780617ac936a8737 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142725335) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004) 
   * 61d1841804ed500402856aee88654a32730f56db Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143843124) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244) 
   * eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143851936) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248) 
   * f59ef58b40daaf5f7fd81d971e06983bca92d0bf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147655079) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4883) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-569879082
 
 
   <!--
   Meta data
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142725335 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143843124 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143851936 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:f59ef58b40daaf5f7fd81d971e06983bca92d0bf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147655079 TriggerType:PUSH TriggerID:f59ef58b40daaf5f7fd81d971e06983bca92d0bf
   Hash:f59ef58b40daaf5f7fd81d971e06983bca92d0bf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4883 TriggerType:PUSH TriggerID:f59ef58b40daaf5f7fd81d971e06983bca92d0bf
   Hash:610f35b473db99f0d4d6e7d2cbfecda288ffcfea Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147675567 TriggerType:PUSH TriggerID:610f35b473db99f0d4d6e7d2cbfecda288ffcfea
   Hash:610f35b473db99f0d4d6e7d2cbfecda288ffcfea Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4887 TriggerType:PUSH TriggerID:610f35b473db99f0d4d6e7d2cbfecda288ffcfea
   Hash:41445892ce21d63b9ac08dafa23d33ca98d0093c Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:41445892ce21d63b9ac08dafa23d33ca98d0093c
   -->
   ## CI report:
   
   * 753a9d8bd5705954a67133f2780617ac936a8737 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142725335) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004) 
   * 61d1841804ed500402856aee88654a32730f56db Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143843124) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244) 
   * eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143851936) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248) 
   * f59ef58b40daaf5f7fd81d971e06983bca92d0bf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147655079) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4883) 
   * 610f35b473db99f0d4d6e7d2cbfecda288ffcfea Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147675567) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4887) 
   * 41445892ce21d63b9ac08dafa23d33ca98d0093c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] bowenli86 commented on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
bowenli86 commented on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-586558519
 
 
   @JingsongLi thanks for the great effort!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#discussion_r377427787
 
 

 ##########
 File path: flink-formats/flink-orc-nohive/src/main/java/org/apache/flink/orc/nohive/shim/OrcNoHiveShim.java
 ##########
 @@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.orc.nohive.shim;
+
+import org.apache.flink.api.java.tuple.Tuple2;
+import org.apache.flink.orc.OrcSplitReader;
+import org.apache.flink.orc.nohive.vector.OrcNoHiveBatchWrapper;
+import org.apache.flink.orc.shim.OrcShim;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.orc.OrcConf;
+import org.apache.orc.OrcFile;
+import org.apache.orc.Reader;
+import org.apache.orc.RecordReader;
+import org.apache.orc.TypeDescription;
+import org.apache.orc.storage.ql.exec.vector.VectorizedRowBatch;
+
+import java.io.IOException;
+import java.util.List;
+
+import static org.apache.flink.orc.shim.OrcShimV200.computeProjectionMask;
+import static org.apache.flink.orc.shim.OrcShimV200.getOffsetAndLengthForSplit;
+
+/**
+ * Shim for orc reader without hive dependents.
+ */
+public class OrcNoHiveShim implements OrcShim<VectorizedRowBatch> {
 
 Review comment:
   Misses a serialVersionUID

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#discussion_r376991033
 
 

 ##########
 File path: flink-formats/flink-orc/src/main/java/org/apache/flink/orc/vector/OrcVectorizedBatch.java
 ##########
 @@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.orc.vector;
+
+/**
+ * Interface to unify orc reader in hive and orc reader without hive dependents.
+ */
+public interface OrcVectorizedBatch {
 
 Review comment:
   It has `size` method, should be interface.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#discussion_r377427396
 
 

 ##########
 File path: flink-formats/flink-orc/src/main/java/org/apache/flink/orc/shim/OrcShim.java
 ##########
 @@ -46,22 +47,24 @@ RecordReader createRecordReader(
 			long splitStart,
 			long splitLength) throws IOException;
 
+	OrcVectorizedBatchWrapper<BATCH> createBatchWrapper(TypeDescription schema, int batchSize);
+
 	/**
 	 * Read the next row batch.
 	 */
-	boolean nextBatch(RecordReader reader, VectorizedRowBatch rowBatch) throws IOException;
+	boolean nextBatch(RecordReader reader, BATCH rowBatch) throws IOException;
 
 	/**
 	 * Default with orc dependent, we should use v2.3.0.
 	 */
-	static OrcShim defaultShim() {
+	static OrcShimV230 defaultShim() {
 
 Review comment:
   Can we change the return type to `OrcShim<VectorizedRowBatch>`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-569879082
 
 
   <!--
   Meta data
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142725335 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143843124 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143851936 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:f59ef58b40daaf5f7fd81d971e06983bca92d0bf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147655079 TriggerType:PUSH TriggerID:f59ef58b40daaf5f7fd81d971e06983bca92d0bf
   Hash:f59ef58b40daaf5f7fd81d971e06983bca92d0bf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4883 TriggerType:PUSH TriggerID:f59ef58b40daaf5f7fd81d971e06983bca92d0bf
   Hash:610f35b473db99f0d4d6e7d2cbfecda288ffcfea Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147675567 TriggerType:PUSH TriggerID:610f35b473db99f0d4d6e7d2cbfecda288ffcfea
   Hash:610f35b473db99f0d4d6e7d2cbfecda288ffcfea Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4887 TriggerType:PUSH TriggerID:610f35b473db99f0d4d6e7d2cbfecda288ffcfea
   Hash:41445892ce21d63b9ac08dafa23d33ca98d0093c Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148176567 TriggerType:PUSH TriggerID:41445892ce21d63b9ac08dafa23d33ca98d0093c
   Hash:41445892ce21d63b9ac08dafa23d33ca98d0093c Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4998 TriggerType:PUSH TriggerID:41445892ce21d63b9ac08dafa23d33ca98d0093c
   Hash:196ed2a9d918bb7f93277e50eb0b24323700e082 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5048 TriggerType:PUSH TriggerID:196ed2a9d918bb7f93277e50eb0b24323700e082
   Hash:196ed2a9d918bb7f93277e50eb0b24323700e082 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148354367 TriggerType:PUSH TriggerID:196ed2a9d918bb7f93277e50eb0b24323700e082
   -->
   ## CI report:
   
   * 753a9d8bd5705954a67133f2780617ac936a8737 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142725335) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004) 
   * 61d1841804ed500402856aee88654a32730f56db Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143843124) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244) 
   * eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143851936) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248) 
   * f59ef58b40daaf5f7fd81d971e06983bca92d0bf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147655079) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4883) 
   * 610f35b473db99f0d4d6e7d2cbfecda288ffcfea Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147675567) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4887) 
   * 41445892ce21d63b9ac08dafa23d33ca98d0093c Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/148176567) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4998) 
   * 196ed2a9d918bb7f93277e50eb0b24323700e082 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/148354367) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5048) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#discussion_r376310241
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/pom.xml
 ##########
 @@ -701,6 +713,7 @@ under the License.
 								<includes combine.children="append">
 									<include>org.apache.flink:flink-hadoop-fs</include>
 									<include>org.apache.flink:flink-orc_${scala.binary.version}</include>
+									<include>org.apache.flink:flink-orc-nohive_${scala.binary.version}</include>
 
 Review comment:
   Yeah I think that's also OK

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#discussion_r376232086
 
 

 ##########
 File path: flink-formats/flink-orc-nohive/src/main/java/org/apache/flink/orc/nohive/vector/AbstractOrcColumnVector.java
 ##########
 @@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.orc.nohive.vector;
+
+import org.apache.flink.table.types.logical.DecimalType;
+import org.apache.flink.table.types.logical.LogicalType;
+
+import org.apache.orc.storage.common.type.HiveDecimal;
+import org.apache.orc.storage.ql.exec.vector.BytesColumnVector;
+import org.apache.orc.storage.ql.exec.vector.ColumnVector;
+import org.apache.orc.storage.ql.exec.vector.DecimalColumnVector;
+import org.apache.orc.storage.ql.exec.vector.DoubleColumnVector;
+import org.apache.orc.storage.ql.exec.vector.LongColumnVector;
+import org.apache.orc.storage.ql.exec.vector.TimestampColumnVector;
+
+import java.math.BigDecimal;
+import java.nio.charset.StandardCharsets;
+import java.sql.Date;
+import java.sql.Timestamp;
+import java.time.LocalDate;
+import java.time.LocalDateTime;
+
+import static org.apache.flink.table.runtime.functions.SqlDateTimeUtils.dateToInternal;
+
+/**
+ * This column vector is used to adapt hive's ColumnVector to Flink's ColumnVector.
+ */
+public abstract class AbstractOrcColumnVector implements
+		org.apache.flink.table.dataformat.vector.ColumnVector {
+
+	private ColumnVector vector;
 
 Review comment:
   Rename it to `hiveVector` or `orcVector`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-569879082
 
 
   <!--
   Meta data
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142725335 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143843124 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143851936 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:f59ef58b40daaf5f7fd81d971e06983bca92d0bf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147655079 TriggerType:PUSH TriggerID:f59ef58b40daaf5f7fd81d971e06983bca92d0bf
   Hash:f59ef58b40daaf5f7fd81d971e06983bca92d0bf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4883 TriggerType:PUSH TriggerID:f59ef58b40daaf5f7fd81d971e06983bca92d0bf
   Hash:610f35b473db99f0d4d6e7d2cbfecda288ffcfea Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147675567 TriggerType:PUSH TriggerID:610f35b473db99f0d4d6e7d2cbfecda288ffcfea
   Hash:610f35b473db99f0d4d6e7d2cbfecda288ffcfea Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4887 TriggerType:PUSH TriggerID:610f35b473db99f0d4d6e7d2cbfecda288ffcfea
   Hash:41445892ce21d63b9ac08dafa23d33ca98d0093c Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148176567 TriggerType:PUSH TriggerID:41445892ce21d63b9ac08dafa23d33ca98d0093c
   Hash:41445892ce21d63b9ac08dafa23d33ca98d0093c Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4998 TriggerType:PUSH TriggerID:41445892ce21d63b9ac08dafa23d33ca98d0093c
   Hash:196ed2a9d918bb7f93277e50eb0b24323700e082 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5048 TriggerType:PUSH TriggerID:196ed2a9d918bb7f93277e50eb0b24323700e082
   Hash:196ed2a9d918bb7f93277e50eb0b24323700e082 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/148354367 TriggerType:PUSH TriggerID:196ed2a9d918bb7f93277e50eb0b24323700e082
   -->
   ## CI report:
   
   * 753a9d8bd5705954a67133f2780617ac936a8737 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142725335) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004) 
   * 61d1841804ed500402856aee88654a32730f56db Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143843124) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244) 
   * eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143851936) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248) 
   * f59ef58b40daaf5f7fd81d971e06983bca92d0bf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147655079) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4883) 
   * 610f35b473db99f0d4d6e7d2cbfecda288ffcfea Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147675567) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4887) 
   * 41445892ce21d63b9ac08dafa23d33ca98d0093c Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/148176567) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4998) 
   * 196ed2a9d918bb7f93277e50eb0b24323700e082 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/148354367) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5048) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#discussion_r376304686
 
 

 ##########
 File path: flink-formats/flink-orc/src/main/java/org/apache/flink/orc/SplitReader.java
 ##########
 @@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.orc;
+
+import java.io.Closeable;
+import java.io.IOException;
+
+/**
+ * Split reader to read record from files. The reader is only responsible for reading the data
+ * of a single split.
+ */
+public interface SplitReader<T> extends Closeable {
 
 Review comment:
   Useless, I'll remove it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read
URL: https://github.com/apache/flink/pull/10730#issuecomment-569879082
 
 
   <!--
   Meta data
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142725335 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:753a9d8bd5705954a67133f2780617ac936a8737 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004 TriggerType:PUSH TriggerID:753a9d8bd5705954a67133f2780617ac936a8737
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143843124 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:61d1841804ed500402856aee88654a32730f56db Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244 TriggerType:PUSH TriggerID:61d1841804ed500402856aee88654a32730f56db
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143851936 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248 TriggerType:PUSH TriggerID:eebae70efc64285b9b3a9a8f42c2caeea09a33b2
   Hash:f59ef58b40daaf5f7fd81d971e06983bca92d0bf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147655079 TriggerType:PUSH TriggerID:f59ef58b40daaf5f7fd81d971e06983bca92d0bf
   Hash:f59ef58b40daaf5f7fd81d971e06983bca92d0bf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4883 TriggerType:PUSH TriggerID:f59ef58b40daaf5f7fd81d971e06983bca92d0bf
   Hash:610f35b473db99f0d4d6e7d2cbfecda288ffcfea Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147675567 TriggerType:PUSH TriggerID:610f35b473db99f0d4d6e7d2cbfecda288ffcfea
   Hash:610f35b473db99f0d4d6e7d2cbfecda288ffcfea Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4887 TriggerType:PUSH TriggerID:610f35b473db99f0d4d6e7d2cbfecda288ffcfea
   -->
   ## CI report:
   
   * 753a9d8bd5705954a67133f2780617ac936a8737 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142725335) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4004) 
   * 61d1841804ed500402856aee88654a32730f56db Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143843124) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4244) 
   * eebae70efc64285b9b3a9a8f42c2caeea09a33b2 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143851936) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4248) 
   * f59ef58b40daaf5f7fd81d971e06983bca92d0bf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147655079) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4883) 
   * 610f35b473db99f0d4d6e7d2cbfecda288ffcfea Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147675567) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4887) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services