You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "poojanilangekar (via GitHub)" <gi...@apache.org> on 2025/07/03 22:54:47 UTC
[PR] Update CatalogEntity::Builder to set default CatalogType as INTERNAL [polaris]
poojanilangekar opened a new pull request, #1998:
URL: https://github.com/apache/polaris/pull/1998
Encountered the issue while adding additional validations to `ExternalCatalog`. The `CatalogEntity::Builder` checks if the `Catalog::type` is set to `INTERNAL`, if not it defaults to `EXTERNAL`. However this is the opposite of the behavior defined in polaris-management-service.yml where the default is set to `INTERNAL`. This change only affects tests because in other cases the catalog entity is generated from the REST request.
Testing:
Updated CatalogEntityTest to ensure that the default is set to `INTERNAL`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update CatalogEntity::Builder to set default CatalogType as INTERNAL [polaris]
Posted by "poojanilangekar (via GitHub)" <gi...@apache.org>.
poojanilangekar commented on PR #1998:
URL: https://github.com/apache/polaris/pull/1998#issuecomment-3033895186
CC: @dimas-b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update CatalogEntity::Builder to set default CatalogType as INTERNAL [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard merged PR #1998:
URL: https://github.com/apache/polaris/pull/1998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update CatalogEntity::Builder to set default CatalogType as INTERNAL [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #1998:
URL: https://github.com/apache/polaris/pull/1998#discussion_r2184266898
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/CatalogEntity.java:
##########
@@ -106,25 +106,25 @@ public Catalog asCatalog() {
CatalogProperties.builder(propertiesMap.get(DEFAULT_BASE_LOCATION_KEY))
.putAll(propertiesMap)
.build();
- return catalogType == Catalog.TypeEnum.INTERNAL
- ? PolarisCatalog.builder()
- .setType(Catalog.TypeEnum.INTERNAL)
+ return catalogType == Catalog.TypeEnum.EXTERNAL
Review Comment:
nit: would it not be easier to fix line 103 instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org