You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Michael Blow (Code Review)" <de...@asterixdb.apache.org> on 2019/04/12 16:50:38 UTC

Change in asterixdb[stabilization-f69489]: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start

Michael Blow has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/3341


Change subject: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start
......................................................................

[NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start

also, fix printing of running processes post sample stop

Change-Id: I84037ad5f64536bafcb7c9500b9a7668e6849156
---
M asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.bat
M asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.sh
M asterixdb/asterix-server/src/main/opt/local/bin/stop-sample-cluster.sh
3 files changed, 11 insertions(+), 36 deletions(-)



  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/41/3341/1

diff --git a/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.bat b/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.bat
index 60f5cb5..652abff 100644
--- a/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.bat
+++ b/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.bat
@@ -32,9 +32,9 @@
 if "%1" == "" goto postopts
 
 if "%1" == "-f" (
-  set force=1
+  rem ignored, this is always the case
 ) else if "%1" == "-force" (
-  set force=1
+  rem ignored, this is always the case
 ) else if "%1" == "-usage" (
   goto :usage
 ) else if "%1" == "-help" (
@@ -80,23 +80,12 @@
   "name='java.exe' and CommandLine like '%%org.codehaus.mojo.appassembler.booter.AppassemblerBooter%%' and (CommandLine like '%%app.name=\"%%[cn]c\"%%' or CommandLine like '%%app.name=\"%%ncservice\"%%')" ^
   GET processid > %tempfile% 2> nul
 
-set severity=ERROR
-if "%force%" == "1" set severity=WARNING
-
 for /F "skip=1" %%P in ('type %tempfile%') DO set found=1
 
 if "%found%" == "1" (
-  if "%force%" == "1" (
-    echo %severity%: ${PRODUCT} processes are already running; -f[orce] specified, ignoring
-    del %tempfile%
- ) else (
-    echo %severity%: ${PRODUCT} processes are already running; aborting"
-    echo.
-    echo Re-run with -f to ignore, or run stop-sample-cluster.bat -f to forcibly terminate all running ${PRODUCT} processes:
-    for /F "skip=1" %%P in ('type %tempfile%') DO @echo     - %%P
-    del %tempfile%
-    exit /B 1
-  )
+  echo WARNING: ${PRODUCT} processes are already running:
+  for /F "skip=1" %%P in ('type %tempfile%') DO @echo     - %%P
+  del %tempfile%
 )
 
 goto :post_timestamp
diff --git a/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.sh b/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.sh
index 34d156c..9268bed 100755
--- a/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.sh
+++ b/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.sh
@@ -20,14 +20,13 @@
 
 function usage() {
   echo
-  echo Usage: $(basename $0) [-f[orce]]
+  echo Usage: $(basename $0)
   echo
-  echo "  -f[orce]  : Forces a start attempt when ${PRODUCT} processes are found to be running"
 }
 
 while [ -n "$1" ]; do
   case $1 in
-    -f|-force) force=1;;
+    -f|-force);; # ignored, this is always the case
     -help|--help|-usage|--usage) usage; exit 0;;
     *) echo "ERROR: unknown argument '$1'"; usage; exit 1;;
   esac
@@ -115,22 +114,9 @@
     && echo "ERROR: sample cluster address (localhost:${LISTEN_PORT}) already in use" && exit 1
 
 if ps -ef | grep 'java.*org\.apache\.hyracks\.control\.[cn]c\.\([CN]CDriver\|service\.NCService\)' > /tmp/$$_pids; then
-  if [ $force ]; then
-    severity=WARNING
-  else
-    severity=ERROR
-  fi
-  echo -n "${severity}: ${PRODUCT} processes are already running; "
-  if [ $force ]; then
-    echo "-f[orce] specified, ignoring"
-  else
-    echo "aborting"
-    echo
-    echo "Re-run with -f to ignore, or run stop-sample-cluster.sh -f to forcibly terminate all running ${PRODUCT} processes:"
-    cat /tmp/$$_pids |  sed 's/^ *[0-9]* \([0-9]*\).*org\.apache\.hyracks\.control\.[cn]c[^ ]*\.\([^ ]*\) .*/\1 - \2/'
-    rm /tmp/$$_pids
-    exit 1
-  fi
+  echo "WARNING: ${PRODUCT} processes are already running:"
+  cat /tmp/$$_pids |  sed 's/^ *[0-9]* \([0-9]*\).*org\.apache\.hyracks\.control\.[cn]c[^ ]*\.\([^ ]*\) .*/\1 - \2/'
+  rm /tmp/$$_pids
 fi
 
 rm /tmp/$$_pids
diff --git a/asterixdb/asterix-server/src/main/opt/local/bin/stop-sample-cluster.sh b/asterixdb/asterix-server/src/main/opt/local/bin/stop-sample-cluster.sh
index 80647d4..97473ac 100755
--- a/asterixdb/asterix-server/src/main/opt/local/bin/stop-sample-cluster.sh
+++ b/asterixdb/asterix-server/src/main/opt/local/bin/stop-sample-cluster.sh
@@ -146,7 +146,7 @@
     done
   else
     echo "re-run with -f|-force to forcibly terminate all ${PRODUCT} processes:"
-    cat /tmp/pids |  sed 's/^ *[0-9]* \([0-9]*\).*org\.apache\.hyracks\.control\.[cn]c[^ ]*\.\([^ ]*\) .*/\1 - \2/'
+    cat /tmp/$$_pids |  sed 's/^ *[0-9]* \([0-9]*\).*org\.apache\.hyracks\.control\.[cn]c[^ ]*\.\([^ ]*\) .*/\1 - \2/'
   fi
 fi
 rm /tmp/$$_pids

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3341
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: newchange
Gerrit-Change-Id: I84037ad5f64536bafcb7c9500b9a7668e6849156
Gerrit-Change-Number: 3341
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>

Change in asterixdb[stabilization-f69489]: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3341 )

Change subject: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6164/ (1/13)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3341
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: I84037ad5f64536bafcb7c9500b9a7668e6849156
Gerrit-Change-Number: 3341
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 16:50:45 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3341 )

Change subject: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9540/ (12/13)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3341
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: I84037ad5f64536bafcb7c9500b9a7668e6849156
Gerrit-Change-Number: 3341
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 16:50:47 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3341 )

Change subject: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start
......................................................................


Patch Set 1:

Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8358/


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3341
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: I84037ad5f64536bafcb7c9500b9a7668e6849156
Gerrit-Change-Number: 3341
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 16:52:55 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start

Posted by "Ian Maxon (Code Review)" <de...@asterixdb.apache.org>.
Ian Maxon has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3341 )

Change subject: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3341
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: I84037ad5f64536bafcb7c9500b9a7668e6849156
Gerrit-Change-Number: 3341
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 16:57:01 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3341 )

Change subject: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11069/ (9/13)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3341
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: I84037ad5f64536bafcb7c9500b9a7668e6849156
Gerrit-Change-Number: 3341
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 16:50:47 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3341 )

Change subject: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/951/ (2/13)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3341
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: I84037ad5f64536bafcb7c9500b9a7668e6849156
Gerrit-Change-Number: 3341
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 16:50:46 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3341 )

Change subject: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5954/ (5/13)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3341
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: I84037ad5f64536bafcb7c9500b9a7668e6849156
Gerrit-Change-Number: 3341
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 16:50:47 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3341 )

Change subject: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3593/ (4/13)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3341
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: I84037ad5f64536bafcb7c9500b9a7668e6849156
Gerrit-Change-Number: 3341
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 16:50:46 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3341 )

Change subject: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/760/ (3/13)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3341
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: I84037ad5f64536bafcb7c9500b9a7668e6849156
Gerrit-Change-Number: 3341
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 16:50:46 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3341 )

Change subject: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5557/ (10/13)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3341
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: I84037ad5f64536bafcb7c9500b9a7668e6849156
Gerrit-Change-Number: 3341
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 16:50:47 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3341 )

Change subject: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5590/ (7/13)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3341
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: I84037ad5f64536bafcb7c9500b9a7668e6849156
Gerrit-Change-Number: 3341
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 16:50:47 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start

Posted by "Anon. E. Moose (Code Review)" <de...@asterixdb.apache.org>.
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3341 )

Change subject: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start
......................................................................


Patch Set 1: Contrib+1

Analytics Compatibility Tests Successful
https://cbjenkins.page.link/9Bb56EZAY4jMHt5a7 : SUCCESS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3341
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: I84037ad5f64536bafcb7c9500b9a7668e6849156
Gerrit-Change-Number: 3341
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 18:52:13 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start

Posted by "Anon. E. Moose (Code Review)" <de...@asterixdb.apache.org>.
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3341 )

Change subject: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start
......................................................................


Patch Set 1:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/QKofsZ27bPeepB2x7 : SUCCESS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3341
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: I84037ad5f64536bafcb7c9500b9a7668e6849156
Gerrit-Change-Number: 3341
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 16:54:55 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3341 )

Change subject: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5803/ (13/13)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3341
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: I84037ad5f64536bafcb7c9500b9a7668e6849156
Gerrit-Change-Number: 3341
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 16:51:52 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3341 )

Change subject: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5493/ (11/13)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3341
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: I84037ad5f64536bafcb7c9500b9a7668e6849156
Gerrit-Change-Number: 3341
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 16:50:47 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3341 )

Change subject: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app-stabilization-f69489/99/ (8/13)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3341
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: I84037ad5f64536bafcb7c9500b9a7668e6849156
Gerrit-Change-Number: 3341
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 16:50:47 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start

Posted by "Michael Blow (Code Review)" <de...@asterixdb.apache.org>.
Michael Blow has submitted this change and it was merged. ( https://asterix-gerrit.ics.uci.edu/3341 )

Change subject: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start
......................................................................

[NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start

also, fix printing of running processes post sample stop

Change-Id: I84037ad5f64536bafcb7c9500b9a7668e6849156
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3341
Reviewed-by: Ian Maxon <im...@uci.edu>
Sonar-Qube: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
---
M asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.bat
M asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.sh
M asterixdb/asterix-server/src/main/opt/local/bin/stop-sample-cluster.sh
3 files changed, 11 insertions(+), 36 deletions(-)

Approvals:
  Ian Maxon: Looks good to me, approved
  Jenkins: Verified; No violations found; Verified
  Anon. E. Moose (1000171): 



diff --git a/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.bat b/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.bat
index 60f5cb5..652abff 100644
--- a/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.bat
+++ b/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.bat
@@ -32,9 +32,9 @@
 if "%1" == "" goto postopts
 
 if "%1" == "-f" (
-  set force=1
+  rem ignored, this is always the case
 ) else if "%1" == "-force" (
-  set force=1
+  rem ignored, this is always the case
 ) else if "%1" == "-usage" (
   goto :usage
 ) else if "%1" == "-help" (
@@ -80,23 +80,12 @@
   "name='java.exe' and CommandLine like '%%org.codehaus.mojo.appassembler.booter.AppassemblerBooter%%' and (CommandLine like '%%app.name=\"%%[cn]c\"%%' or CommandLine like '%%app.name=\"%%ncservice\"%%')" ^
   GET processid > %tempfile% 2> nul
 
-set severity=ERROR
-if "%force%" == "1" set severity=WARNING
-
 for /F "skip=1" %%P in ('type %tempfile%') DO set found=1
 
 if "%found%" == "1" (
-  if "%force%" == "1" (
-    echo %severity%: ${PRODUCT} processes are already running; -f[orce] specified, ignoring
-    del %tempfile%
- ) else (
-    echo %severity%: ${PRODUCT} processes are already running; aborting"
-    echo.
-    echo Re-run with -f to ignore, or run stop-sample-cluster.bat -f to forcibly terminate all running ${PRODUCT} processes:
-    for /F "skip=1" %%P in ('type %tempfile%') DO @echo     - %%P
-    del %tempfile%
-    exit /B 1
-  )
+  echo WARNING: ${PRODUCT} processes are already running:
+  for /F "skip=1" %%P in ('type %tempfile%') DO @echo     - %%P
+  del %tempfile%
 )
 
 goto :post_timestamp
diff --git a/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.sh b/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.sh
index 34d156c..9268bed 100755
--- a/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.sh
+++ b/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.sh
@@ -20,14 +20,13 @@
 
 function usage() {
   echo
-  echo Usage: $(basename $0) [-f[orce]]
+  echo Usage: $(basename $0)
   echo
-  echo "  -f[orce]  : Forces a start attempt when ${PRODUCT} processes are found to be running"
 }
 
 while [ -n "$1" ]; do
   case $1 in
-    -f|-force) force=1;;
+    -f|-force);; # ignored, this is always the case
     -help|--help|-usage|--usage) usage; exit 0;;
     *) echo "ERROR: unknown argument '$1'"; usage; exit 1;;
   esac
@@ -115,22 +114,9 @@
     && echo "ERROR: sample cluster address (localhost:${LISTEN_PORT}) already in use" && exit 1
 
 if ps -ef | grep 'java.*org\.apache\.hyracks\.control\.[cn]c\.\([CN]CDriver\|service\.NCService\)' > /tmp/$$_pids; then
-  if [ $force ]; then
-    severity=WARNING
-  else
-    severity=ERROR
-  fi
-  echo -n "${severity}: ${PRODUCT} processes are already running; "
-  if [ $force ]; then
-    echo "-f[orce] specified, ignoring"
-  else
-    echo "aborting"
-    echo
-    echo "Re-run with -f to ignore, or run stop-sample-cluster.sh -f to forcibly terminate all running ${PRODUCT} processes:"
-    cat /tmp/$$_pids |  sed 's/^ *[0-9]* \([0-9]*\).*org\.apache\.hyracks\.control\.[cn]c[^ ]*\.\([^ ]*\) .*/\1 - \2/'
-    rm /tmp/$$_pids
-    exit 1
-  fi
+  echo "WARNING: ${PRODUCT} processes are already running:"
+  cat /tmp/$$_pids |  sed 's/^ *[0-9]* \([0-9]*\).*org\.apache\.hyracks\.control\.[cn]c[^ ]*\.\([^ ]*\) .*/\1 - \2/'
+  rm /tmp/$$_pids
 fi
 
 rm /tmp/$$_pids
diff --git a/asterixdb/asterix-server/src/main/opt/local/bin/stop-sample-cluster.sh b/asterixdb/asterix-server/src/main/opt/local/bin/stop-sample-cluster.sh
index 80647d4..97473ac 100755
--- a/asterixdb/asterix-server/src/main/opt/local/bin/stop-sample-cluster.sh
+++ b/asterixdb/asterix-server/src/main/opt/local/bin/stop-sample-cluster.sh
@@ -146,7 +146,7 @@
     done
   else
     echo "re-run with -f|-force to forcibly terminate all ${PRODUCT} processes:"
-    cat /tmp/pids |  sed 's/^ *[0-9]* \([0-9]*\).*org\.apache\.hyracks\.control\.[cn]c[^ ]*\.\([^ ]*\) .*/\1 - \2/'
+    cat /tmp/$$_pids |  sed 's/^ *[0-9]* \([0-9]*\).*org\.apache\.hyracks\.control\.[cn]c[^ ]*\.\([^ ]*\) .*/\1 - \2/'
   fi
 fi
 rm /tmp/$$_pids

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3341
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: merged
Gerrit-Change-Id: I84037ad5f64536bafcb7c9500b9a7668e6849156
Gerrit-Change-Number: 3341
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>

Change in asterixdb[stabilization-f69489]: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3341 )

Change subject: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start
......................................................................


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8358/ : SUCCESS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3341
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: I84037ad5f64536bafcb7c9500b9a7668e6849156
Gerrit-Change-Number: 3341
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 18:21:56 +0000
Gerrit-HasComments: No

Change in asterixdb[stabilization-f69489]: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start

Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3341 )

Change subject: [NO ISSUE][*DB] Warn (not fail) on running *DB processes on sample start
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5581/ (6/13)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3341
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-MessageType: comment
Gerrit-Change-Id: I84037ad5f64536bafcb7c9500b9a7668e6849156
Gerrit-Change-Number: 3341
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 12 Apr 2019 16:50:47 +0000
Gerrit-HasComments: No