You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/11/18 02:36:55 UTC
[GitHub] [shardingsphere] jingshanglu opened a new pull request #13673: support for @ShardingSphereTransactionType(value = TransactionType.BASE)
jingshanglu opened a new pull request #13673:
URL: https://github.com/apache/shardingsphere/pull/13673
Fixes #13550 .
Changes proposed in this pull request:
- Get the `connectionTransaction` according to the `TransActiontype` in the annotation, throw an exception if you can't get it, and get `connectionTransaction` by config file.
- change `privite ConnectionTransaction(final String schemaName, final TransactionType transactionType, final TransactionContexts transactionContexts) ` to `public ConnectionTransaction(final String schemaName, final TransactionType transactionType, final TransactionContexts transactionContexts) {`
Test
- [x] MANUAL
- [ ] UT
- [ ] IT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #13673: support for @ShardingSphereTransactionType(value = TransactionType.BASE)
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #13673:
URL: https://github.com/apache/shardingsphere/pull/13673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #13673: support for @ShardingSphereTransactionType(value = TransactionType.BASE)
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #13673:
URL: https://github.com/apache/shardingsphere/pull/13673#issuecomment-972491480
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13673?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#13673](https://codecov.io/gh/apache/shardingsphere/pull/13673?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (04ad107) into [master](https://codecov.io/gh/apache/shardingsphere/commit/f4a304f2ff0e9a72f6cea0adefd80ae356982a57?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f4a304f) will **increase** coverage by `0.00%`.
> The diff coverage is `80.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/13673/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/13673?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #13673 +/- ##
=========================================
Coverage 63.65% 63.65%
Complexity 1696 1696
=========================================
Files 2743 2743
Lines 40875 40881 +6
Branches 6973 6975 +2
=========================================
+ Hits 26020 26024 +4
- Misses 12871 12872 +1
- Partials 1984 1985 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/13673?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...driver/jdbc/core/connection/ConnectionManager.java](https://codecov.io/gh/apache/shardingsphere/pull/13673/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvY29ubmVjdGlvbi9Db25uZWN0aW9uTWFuYWdlci5qYXZh) | `83.15% <77.77%> (-1.12%)` | :arrow_down: |
| [...rdingsphere/transaction/ConnectionTransaction.java](https://codecov.io/gh/apache/shardingsphere/pull/13673/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXRyYW5zYWN0aW9uL3NoYXJkaW5nc3BoZXJlLXRyYW5zYWN0aW9uLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3RyYW5zYWN0aW9uL0Nvbm5lY3Rpb25UcmFuc2FjdGlvbi5qYXZh) | `38.46% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13673?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13673?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f4a304f...04ad107](https://codecov.io/gh/apache/shardingsphere/pull/13673?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org