[GitHub] [pulsar] Anonymitaet commented on a change in pull request #10650: [Transactionn] Transaction admin api component in topic status

[GitBox <gi...@apache.org>]

Anonymitaet commented on a change in pull request #10650:
URL: https://github.com/apache/pulsar/pull/10650#discussion_r639370981



##########
File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Transactions.java
##########
@@ -71,4 +73,21 @@
      */
     CompletableFuture<TransactionMetadata> getTransactionMetadata(TxnID txnID);
 
+    /**
+     * Get transaction buffer stats.
+     *
+     * @param topic the topic of getting transaction buffer stats
+     * @return the future stats of transaction buffer in topic.
+     */
+    CompletableFuture<TransactionBufferStats> getTransactionBufferStats(String topic);
+
+    /**
+     * Get transaction pending ack stats.
+     *
+     * @param topic the topic of this transaction pending ack stats
+     * @param subName the topic of this transaction pending ack stats

Review comment:
       ```suggestion
        * @param subName the subName of this transaction pending ack stats
   ```
   is `subName` accurate? or `subscription name`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org