You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2011/05/17 15:06:30 UTC

svn commit: r1104225 - /httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/DefaultAsyncRequestDirector.java

Author: olegk
Date: Tue May 17 13:06:30 2011
New Revision: 1104225

URL: http://svn.apache.org/viewvc?rev=1104225&view=rev
Log:
Make sure auth state gets invalidated for connection based schemes when the underlying connection is closed

Modified:
    httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/DefaultAsyncRequestDirector.java

Modified: httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/DefaultAsyncRequestDirector.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/DefaultAsyncRequestDirector.java?rev=1104225&r1=1104224&r2=1104225&view=diff
==============================================================================
--- httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/DefaultAsyncRequestDirector.java (original)
+++ httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/DefaultAsyncRequestDirector.java Tue May 17 13:06:30 2011
@@ -378,6 +378,8 @@ class DefaultAsyncRequestDirector<T> imp
                 this.managedConn.setIdleDuration(duration, TimeUnit.MILLISECONDS);
             } else {
                 releaseConnection();
+                invalidateAuthIfSuccessful(this.proxyAuthState);
+                invalidateAuthIfSuccessful(this.targetAuthState);
             }
 
             if (this.finalResponse != null) {
@@ -807,4 +809,14 @@ class DefaultAsyncRequestDirector<T> imp
         authState.setCredentials(creds);
     }
 
+    private void invalidateAuthIfSuccessful(final AuthState authState) {
+        AuthScheme authscheme = authState.getAuthScheme();
+        if (authscheme != null
+                && authscheme.isConnectionBased()
+                && authscheme.isComplete()
+                && authState.getCredentials() != null) {
+            authState.invalidate();
+        }
+    }
+
 }