You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/10/18 07:46:02 UTC

[GitHub] [incubator-devlake] likyh commented on a diff in pull request #3462: docs: add comments and rename scripts

likyh commented on code in PR #3462:
URL: https://github.com/apache/incubator-devlake/pull/3462#discussion_r997839316


##########
models/migrationscripts/20220929_change_leadtimeminutes_to_int64.go:
##########
@@ -35,7 +35,9 @@ func (Issues20220929) TableName() string {
 	return "issues"
 }
 
-func (*modifyLeadTimeMinutes) Up(basicRes core.BasicRes) errors.Error {
+func (*changeLeadTimeMinutesToInt64) Up(basicRes core.BasicRes) errors.Error {
+	// Yes, issues.lead_time_minutes might be negative, we ought to change the type
+	// for the column from `uint` to `int64`

Review Comment:
   add issue link here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org