You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/08 15:44:36 UTC
[GitHub] [flink] zentol opened a new pull request #10802:
[FLINK-12040][build] Remove unused akka dependencies
zentol opened a new pull request #10802: [FLINK-12040][build] Remove unused akka dependencies
URL: https://github.com/apache/flink/pull/10802
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10802:
[1.8][FLINK-12040][build] Remove unused akka dependencies
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10802: [1.8][FLINK-12040][build] Remove unused akka dependencies
URL: https://github.com/apache/flink/pull/10802#issuecomment-572141818
<!--
Meta data
Hash:06bb6f54d0d0c75ee59f0467ef863dc24cc28fcf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143594193 TriggerType:PUSH TriggerID:06bb6f54d0d0c75ee59f0467ef863dc24cc28fcf
Hash:46bcae02d0fd88e95099d6540713bd415b171b6d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143758055 TriggerType:PUSH TriggerID:46bcae02d0fd88e95099d6540713bd415b171b6d
-->
## CI report:
* 06bb6f54d0d0c75ee59f0467ef863dc24cc28fcf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143594193)
* 46bcae02d0fd88e95099d6540713bd415b171b6d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143758055)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10802:
[1.8][FLINK-12040][build] Remove unused akka dependencies
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10802: [1.8][FLINK-12040][build] Remove unused akka dependencies
URL: https://github.com/apache/flink/pull/10802#issuecomment-572141818
<!--
Meta data
Hash:06bb6f54d0d0c75ee59f0467ef863dc24cc28fcf Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:06bb6f54d0d0c75ee59f0467ef863dc24cc28fcf
-->
## CI report:
* 06bb6f54d0d0c75ee59f0467ef863dc24cc28fcf UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10802:
[1.8][FLINK-12040][build] Remove unused akka dependencies
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10802: [1.8][FLINK-12040][build] Remove unused akka dependencies
URL: https://github.com/apache/flink/pull/10802#issuecomment-572141818
<!--
Meta data
Hash:06bb6f54d0d0c75ee59f0467ef863dc24cc28fcf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143594193 TriggerType:PUSH TriggerID:06bb6f54d0d0c75ee59f0467ef863dc24cc28fcf
Hash:46bcae02d0fd88e95099d6540713bd415b171b6d Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:46bcae02d0fd88e95099d6540713bd415b171b6d
-->
## CI report:
* 06bb6f54d0d0c75ee59f0467ef863dc24cc28fcf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143594193)
* 46bcae02d0fd88e95099d6540713bd415b171b6d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10802:
[1.8][FLINK-12040][build] Remove unused akka dependencies
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10802: [1.8][FLINK-12040][build] Remove unused akka dependencies
URL: https://github.com/apache/flink/pull/10802#issuecomment-572141818
<!--
Meta data
Hash:06bb6f54d0d0c75ee59f0467ef863dc24cc28fcf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143594193 TriggerType:PUSH TriggerID:06bb6f54d0d0c75ee59f0467ef863dc24cc28fcf
Hash:46bcae02d0fd88e95099d6540713bd415b171b6d Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143758055 TriggerType:PUSH TriggerID:46bcae02d0fd88e95099d6540713bd415b171b6d
-->
## CI report:
* 06bb6f54d0d0c75ee59f0467ef863dc24cc28fcf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143594193)
* 46bcae02d0fd88e95099d6540713bd415b171b6d Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143758055)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10802:
[1.8][FLINK-12040][build] Remove unused akka dependencies
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10802: [1.8][FLINK-12040][build] Remove unused akka dependencies
URL: https://github.com/apache/flink/pull/10802#issuecomment-572129714
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 06bb6f54d0d0c75ee59f0467ef863dc24cc28fcf (Wed Jan 08 15:47:43 UTC 2020)
**Warnings:**
* **4 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol merged pull request #10802:
[1.8][FLINK-12040][build] Remove unused akka dependencies
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #10802: [1.8][FLINK-12040][build] Remove unused akka dependencies
URL: https://github.com/apache/flink/pull/10802
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10802:
[1.8][FLINK-12040][build] Remove unused akka dependencies
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10802: [1.8][FLINK-12040][build] Remove unused akka dependencies
URL: https://github.com/apache/flink/pull/10802#discussion_r367881837
##########
File path: flink-yarn/pom.xml
##########
@@ -59,33 +59,6 @@ under the License.
<version>${hadoop.version}-${project.version}</version>
</dependency>
- <dependency>
- <groupId>com.typesafe.akka</groupId>
- <artifactId>akka-actor_${scala.binary.version}</artifactId>
- <scope>provided</scope>
- </dependency>
-
- <dependency>
- <groupId>com.typesafe.akka</groupId>
- <artifactId>akka-remote_${scala.binary.version}</artifactId>
- <scope>provided</scope>
- </dependency>
-
- <dependency>
- <groupId>com.typesafe.akka</groupId>
- <artifactId>akka-camel_${scala.binary.version}</artifactId>
Review comment:
yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10802:
[1.8][FLINK-12040][build] Remove unused akka dependencies
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10802: [1.8][FLINK-12040][build] Remove unused akka dependencies
URL: https://github.com/apache/flink/pull/10802#issuecomment-572141818
<!--
Meta data
Hash:06bb6f54d0d0c75ee59f0467ef863dc24cc28fcf Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143594193 TriggerType:PUSH TriggerID:06bb6f54d0d0c75ee59f0467ef863dc24cc28fcf
-->
## CI report:
* 06bb6f54d0d0c75ee59f0467ef863dc24cc28fcf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143594193)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10802:
[1.8][FLINK-12040][build] Remove unused akka dependencies
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10802: [1.8][FLINK-12040][build] Remove unused akka dependencies
URL: https://github.com/apache/flink/pull/10802#discussion_r367499930
##########
File path: flink-yarn/pom.xml
##########
@@ -59,33 +59,6 @@ under the License.
<version>${hadoop.version}-${project.version}</version>
</dependency>
- <dependency>
- <groupId>com.typesafe.akka</groupId>
- <artifactId>akka-actor_${scala.binary.version}</artifactId>
- <scope>provided</scope>
- </dependency>
-
- <dependency>
- <groupId>com.typesafe.akka</groupId>
- <artifactId>akka-remote_${scala.binary.version}</artifactId>
- <scope>provided</scope>
- </dependency>
-
- <dependency>
- <groupId>com.typesafe.akka</groupId>
- <artifactId>akka-camel_${scala.binary.version}</artifactId>
Review comment:
Can we remove this dependency also from the dependency management section of the parent `pom.xml`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10802:
[1.8][FLINK-12040][build] Remove unused akka dependencies
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10802: [1.8][FLINK-12040][build] Remove unused akka dependencies
URL: https://github.com/apache/flink/pull/10802#issuecomment-572141818
<!--
Meta data
Hash:06bb6f54d0d0c75ee59f0467ef863dc24cc28fcf Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143594193 TriggerType:PUSH TriggerID:06bb6f54d0d0c75ee59f0467ef863dc24cc28fcf
-->
## CI report:
* 06bb6f54d0d0c75ee59f0467ef863dc24cc28fcf Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143594193)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services