You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2023/01/19 23:48:34 UTC
[GitHub] [tvm] mkatanbaf opened a new pull request, #13811: [microTVM] Allow multiple runners in tuning micro models with meta-schedule
mkatanbaf opened a new pull request, #13811:
URL: https://github.com/apache/tvm/pull/13811
This PR adds support for running candidate projects on multiple physical boards when using meta-schedule to tune micro models, and helps reducing the tuning time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mkatanbaf commented on pull request #13811: [microTVM] Allow multiple runners in tuning micro models with meta-schedule
Posted by "mkatanbaf (via GitHub)" <gi...@apache.org>.
mkatanbaf commented on PR #13811:
URL: https://github.com/apache/tvm/pull/13811#issuecomment-1402363659
@tvm-bot rerun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on a diff in pull request #13811: [microTVM] Allow multiple runners in tuning micro models with meta-schedule
Posted by "mehrdadh (via GitHub)" <gi...@apache.org>.
mehrdadh commented on code in PR #13811:
URL: https://github.com/apache/tvm/pull/13811#discussion_r1083109491
##########
tests/micro/zephyr/test_ms_tuning.py:
##########
@@ -95,7 +95,10 @@ def test_ms_tuning_conv2d(workspace_dir, board, microtvm_debug, use_fvp, serial_
builder = get_local_builder_micro()
with ms.Profiler() as profiler:
with get_rpc_runner_micro(
- platform=platform, options=project_options, session_timeout_sec=120
+ platform=platform,
+ options=project_options,
+ session_timeout_sec=120,
+ serial_numbers=["0", "1"],
Review Comment:
To be able to run this test in CI with physical devices, we need to pass the serial numbers. I suggest to reuse the `serial_number` pytest argument. We could use this argument in the format of `SERIAL_1,SERIAL_2,...,SERIAL_N` when we want to tune with N number of devices and parse the string in `serial_number` pytest argument function and return a list of serial numbers. Then we could pass the serial numbers to this function.
Then in this function you could check if serial_number arg is an empty list and set it to `["0", "1"]` if it's empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mkatanbaf commented on a diff in pull request #13811: [microTVM] Allow multiple runners in tuning micro models with meta-schedule
Posted by "mkatanbaf (via GitHub)" <gi...@apache.org>.
mkatanbaf commented on code in PR #13811:
URL: https://github.com/apache/tvm/pull/13811#discussion_r1084464065
##########
tests/micro/zephyr/test_ms_tuning.py:
##########
@@ -95,7 +95,10 @@ def test_ms_tuning_conv2d(workspace_dir, board, microtvm_debug, use_fvp, serial_
builder = get_local_builder_micro()
with ms.Profiler() as profiler:
with get_rpc_runner_micro(
- platform=platform, options=project_options, session_timeout_sec=120
+ platform=platform,
+ options=project_options,
+ session_timeout_sec=120,
+ serial_numbers=["0", "1"],
Review Comment:
Thanks @mehrdadh, made the change to use the serial number when available. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh merged pull request #13811: [microTVM] Allow multiple runners in tuning micro models with meta-schedule
Posted by "mehrdadh (via GitHub)" <gi...@apache.org>.
mehrdadh merged PR #13811:
URL: https://github.com/apache/tvm/pull/13811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13811: [microTVM] Allow multiple runners in tuning micro models with meta-schedule
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13811:
URL: https://github.com/apache/tvm/pull/13811#issuecomment-1397752705
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on a diff in pull request #13811: [microTVM] Allow multiple runners in tuning micro models with meta-schedule
Posted by "mehrdadh (via GitHub)" <gi...@apache.org>.
mehrdadh commented on code in PR #13811:
URL: https://github.com/apache/tvm/pull/13811#discussion_r1083109491
##########
tests/micro/zephyr/test_ms_tuning.py:
##########
@@ -95,7 +95,10 @@ def test_ms_tuning_conv2d(workspace_dir, board, microtvm_debug, use_fvp, serial_
builder = get_local_builder_micro()
with ms.Profiler() as profiler:
with get_rpc_runner_micro(
- platform=platform, options=project_options, session_timeout_sec=120
+ platform=platform,
+ options=project_options,
+ session_timeout_sec=120,
+ serial_numbers=["0", "1"],
Review Comment:
To be able to run this test in CI with physical devices, we need to pass the serial numbers. I suggest to reuse the `serial_number` pytest argument. We could use this argument in the format of `SERIAL_1,SERIAL_2,...,SERIAL_N` when we want to tune with N number of devices and parse the string in `serial_number` pytest argument function and return a list of serial numbers. Then we could pass the serial numbers to this function.
Then in this function you could check if serial_number arg is an empty list, just set it to `["0", "1"]`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mkatanbaf commented on pull request #13811: [microTVM] Allow multiple runners in tuning micro models with meta-schedule
Posted by "mkatanbaf (via GitHub)" <gi...@apache.org>.
mkatanbaf commented on PR #13811:
URL: https://github.com/apache/tvm/pull/13811#issuecomment-1398916223
cc @mehrdadh @gromero @alanmacd @areusch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org