You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by li...@apache.org on 2016/11/07 03:52:00 UTC

[1/2] kylin git commit: minor, job diagnosis extract conf for each mr job

Repository: kylin
Updated Branches:
  refs/heads/v1.6.0-rc1 75c981cb3 -> 4e5f989b9


minor, job diagnosis extract conf for each mr job


Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/8385850b
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/8385850b
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/8385850b

Branch: refs/heads/v1.6.0-rc1
Commit: 8385850bc78ca8797aa070b33196c7f707d7aef0
Parents: 75c981c
Author: lidongsjtu <li...@apache.org>
Authored: Mon Nov 7 09:57:01 2016 +0800
Committer: lidongsjtu <li...@apache.org>
Committed: Mon Nov 7 11:41:57 2016 +0800

----------------------------------------------------------------------
 .../java/org/apache/kylin/tool/MrJobInfoExtractor.java    | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kylin/blob/8385850b/tool/src/main/java/org/apache/kylin/tool/MrJobInfoExtractor.java
----------------------------------------------------------------------
diff --git a/tool/src/main/java/org/apache/kylin/tool/MrJobInfoExtractor.java b/tool/src/main/java/org/apache/kylin/tool/MrJobInfoExtractor.java
index 056c210..96f47d3 100644
--- a/tool/src/main/java/org/apache/kylin/tool/MrJobInfoExtractor.java
+++ b/tool/src/main/java/org/apache/kylin/tool/MrJobInfoExtractor.java
@@ -127,13 +127,9 @@ public class MrJobInfoExtractor extends AbstractInfoExtractor {
         try {
             String jobResponse = getHttpResponse(jobUrlPrefix);
             JsonNode job = new ObjectMapper().readTree(jobResponse).path("job").get("state");
-            String state = job.textValue();
-            logger.debug(state);
-            if (!state.equals("SUCCEEDED")) {
-                String confUrl = jobUrlPrefix + "/conf/";
-                String response = getHttpResponse(confUrl);
-                FileUtils.writeStringToFile(new File(exportDir, "job_conf.json"), response, Charset.defaultCharset());
-            }
+            String confUrl = jobUrlPrefix + "/conf/";
+            String response = getHttpResponse(confUrl);
+            FileUtils.writeStringToFile(new File(exportDir, "job_conf.json"), response, Charset.defaultCharset());
         } catch (Exception e) {
             logger.warn("Failed to get job conf rest response.", e);
         }


[2/2] kylin git commit: minor, add more logging

Posted by li...@apache.org.
minor, add more logging


Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/4e5f989b
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/4e5f989b
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/4e5f989b

Branch: refs/heads/v1.6.0-rc1
Commit: 4e5f989b94a61b1a6db94d88f358ad0750834374
Parents: 8385850
Author: lidongsjtu <li...@apache.org>
Authored: Fri Oct 28 14:07:39 2016 +0800
Committer: lidongsjtu <li...@apache.org>
Committed: Mon Nov 7 11:51:14 2016 +0800

----------------------------------------------------------------------
 .../org/apache/kylin/storage/gtrecord/GTCubeStorageQueryBase.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kylin/blob/4e5f989b/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/GTCubeStorageQueryBase.java
----------------------------------------------------------------------
diff --git a/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/GTCubeStorageQueryBase.java b/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/GTCubeStorageQueryBase.java
index fa23be1..b96e952 100644
--- a/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/GTCubeStorageQueryBase.java
+++ b/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/GTCubeStorageQueryBase.java
@@ -103,7 +103,7 @@ public abstract class GTCubeStorageQueryBase implements IStorageQuery {
         dimensionsD.addAll(groupsD);
         dimensionsD.addAll(otherDimsD);
         Cuboid cuboid = Cuboid.identifyCuboid(cubeDesc, dimensionsD, metrics);
-        logger.info("Cuboid identified: cube={}, cuboidId={}", cubeInstance.getName(), cuboid.getId());
+        logger.info("Cuboid identified: cube={}, cuboidId={}, groupsD={}, otherDimsD={}", cubeInstance.getName(), cuboid.getId(), groupsD, otherDimsD);
         context.setCuboid(cuboid);
 
         // isExactAggregation? meaning: tuples returned from storage requires no further aggregation in query engine