You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "MeihanLi (via GitHub)" <gi...@apache.org> on 2023/10/24 19:04:50 UTC
[I] [Regression] Non Agg Group By queries work in 0.11 but fail in 0.12 [pinot]
MeihanLi opened a new issue, #11866:
URL: https://github.com/apache/pinot/issues/11866
Non Aggregation Group By queries work in 0.11 but start to fail in 0.12. The change is introduced [#9605](https://github.com/apache/pinot/pull/9605).
This is regression in 0.12 but it seems to be fixed in the current master branch. Does anyone know which PR fixes this?
example Non Agg Group By query which works in 0.11 but fails in 0.12:
`SELECT CONCAT(CONCAT(CONCAT(CONCAT(name, '-', ''), stage, ''), '.', ''), status, '') FROM tableName WHERE (occurred_at_hour BETWEEN 1696754872000 AND 1696841272000) GROUP BY name, stage, status LIMIT 10000`
Error in 0.12:
However, it works in current master branch:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] [Regression] Non Agg Group By queries work in 0.11 but fail in 0.12 [pinot]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #11866:
URL: https://github.com/apache/pinot/issues/11866#issuecomment-6159513191
This issue has been closed because it has been inactive for 180 days. If you believe this issue is still relevant, please feel free to reopen it or create a new issue. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] [Regression] Non Agg Group By queries work in 0.11 but fail in 0.12 [pinot]
Posted by "ankitsultana (via GitHub)" <gi...@apache.org>.
ankitsultana commented on issue #11866:
URL: https://github.com/apache/pinot/issues/11866#issuecomment-1788111598
The query Christina shared is valid though.
I tested this in Postgres with this table:
|row-num | id | nm | cnt
|-- | -- | -- | --
|1 | a- | name | 0
|2 | a | -name | 1
Query:
```
select concat(id, nm, '-') from testing_groupby group by id, nm
```
Output:
```
a-name-
a-name-
```
Also, Christina mentioned that the query in the original post is working in Multistage Engine but it is not working in V1 Engine. (I didn't verify this myself)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] [Regression] Non Agg Group By queries work in 0.11 but fail in 0.12 [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on issue #11866:
URL: https://github.com/apache/pinot/issues/11866#issuecomment-1789314152
@ankitsultana It is a valid query, and the example you posted shows the problem of the original re-write. In Pinot, if we rewrite it into `select distinct concat(id, nm, '-') from testing_groupby`, it will return a single row instead of 2 rows from PostgreSQL (standard SQL)
@heydoriszhang You may take a look at the example @ankitsultana posted. I don't want to revert #9605 because it is the wrong and unsafe behavior. Multi-stage engine is giving the correct SQL behavior, not the old single-stage behavior. In order to fix this, we should follow the SQL behavior and directly support group-by without aggregation in single-stage engine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] [Regression] Non Agg Group By queries work in 0.11 but fail in 0.12 [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on issue #11866:
URL: https://github.com/apache/pinot/issues/11866#issuecomment-1789351098
Opened #11923 to track this feature. @heydoriszhang I think you may revert #9605 in your fork branch, and once #11923 is addressed you may remove that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] [Regression] Non Agg Group By queries work in 0.11 but fail in 0.12 [pinot]
Posted by "heydoriszhang (via GitHub)" <gi...@apache.org>.
heydoriszhang commented on issue #11866:
URL: https://github.com/apache/pinot/issues/11866#issuecomment-1789495307
Thanks for confirming and opened #11923 to track.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] [Regression] Non Agg Group By queries work in 0.11 but fail in 0.12 [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on issue #11866:
URL: https://github.com/apache/pinot/issues/11866#issuecomment-1777995354
It is intentionally done this way because this query rewrite does not guarantee the same semantic. E.g. concat of `'a-'` and `'-b'` vs `'a'` and `'--b'` will give the same result, but they belong to different group. Please explicitly use `select distinct concat(id, type, '-') from githubEvents limit 10`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] [Regression] Non Agg Group By queries work in 0.11 but fail in 0.12 [pinot]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #11866: [Regression] Non Agg Group By queries work in 0.11 but fail in 0.12
URL: https://github.com/apache/pinot/issues/11866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] [Regression] Non Agg Group By queries work in 0.11 but fail in 0.12 [pinot]
Posted by "heydoriszhang (via GitHub)" <gi...@apache.org>.
heydoriszhang commented on issue #11866:
URL: https://github.com/apache/pinot/issues/11866#issuecomment-1788039040
@Jackie-Jiang , we have a lot of existing customers using this kind of query and asking them to rewrite the query takes non-trivial effort. This is blocking our Pinot 0.12 version upgrade in Uber.
Could we safely revert #9605 or make minimum change to keep the old behavior in 0.12+ release while working with customers to migrate the queries for the long run?
Also it seems in current master branch, using the multi-stage engine will work with the old behavior on the non aggregation group by, is this intended? In 0.12.1 this will not work for multi-stage engine either. Does anyone know which PR made multi-stage engine working with the old behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] [Regression] Non Agg Group By queries work in 0.11 but fail in 0.12 [pinot]
Posted by "MeihanLi (via GitHub)" <gi...@apache.org>.
MeihanLi commented on issue #11866:
URL: https://github.com/apache/pinot/issues/11866#issuecomment-1777858183
cc @Jackie-Jiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] [Regression] Non Agg Group By queries work in 0.11 but fail in 0.12 [pinot]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #11866:
URL: https://github.com/apache/pinot/issues/11866#issuecomment-5649668093
This issue has been automatically marked as stale because it has not had any activity in the last 150 days. It will be closed in 30 days if no further activity occurs. If this issue is still relevant, please leave a comment to keep it open. Thank you for your contributions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org