You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Pradeep Agrawal <pr...@gmail.com> on 2022/03/29 13:09:22 UTC
Review Request 73919: RANGER-3485: db setup scripts should not convert the db user to lowercase during setup
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73919/
-----------------------------------------------------------
Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-3485
https://issues.apache.org/jira/browse/RANGER-3485
Repository: ranger
Description
-------
**Problem statement:** only for postgres db flavor db setup scripts converts the db user name to lowercase during setup. if any one has pre-created user in uppercase then he may not able to install ranger because ranger db schema creation may fail.
**Proposed solution:** Postgres DB allows creation of user in non small case format also, but such string should be provided within the '"'{doublequote) character.
This patch change the db script and sql queries and passes the db user name within the '"'{doublequote) character.
Diffs
-----
kms/scripts/db_setup.py 25480257a
kms/scripts/dba_script.py 14e6ff88c
kms/scripts/setup.sh b5a6e719d
security-admin/scripts/db_setup.py ff54956b9
security-admin/scripts/dba_script.py e7567a3f7
security-admin/scripts/setup.sh 8ba8e9a7b
Diff: https://reviews.apache.org/r/73919/diff/1/
Testing
-------
Tested for fresh install(small/caps/camelcase) and upgrade(only small case)
Thanks,
Pradeep Agrawal
Re: Review Request 73919: RANGER-3485: db setup scripts should not convert the db user to lowercase during setup
Posted by bhavik patel <bh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73919/#review224235
-----------------------------------------------------------
Ship it!
Ship It!
- bhavik patel
On March 29, 2022, 1:09 p.m., Pradeep Agrawal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73919/
> -----------------------------------------------------------
>
> (Updated March 29, 2022, 1:09 p.m.)
>
>
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3485
> https://issues.apache.org/jira/browse/RANGER-3485
>
>
> Repository: ranger
>
>
> Description
> -------
>
> **Problem statement:** only for postgres db flavor db setup scripts converts the db user name to lowercase during setup. if any one has pre-created user in uppercase then he may not able to install ranger because ranger db schema creation may fail.
>
> **Proposed solution:** Postgres DB allows creation of user in non small case format also, but such string should be provided within the '"'{doublequote) character.
> This patch change the db script and sql queries and passes the db user name within the '"'{doublequote) character.
>
>
> Diffs
> -----
>
> kms/scripts/db_setup.py 25480257a
> kms/scripts/dba_script.py 14e6ff88c
> kms/scripts/setup.sh b5a6e719d
> security-admin/scripts/db_setup.py ff54956b9
> security-admin/scripts/dba_script.py e7567a3f7
> security-admin/scripts/setup.sh 8ba8e9a7b
>
>
> Diff: https://reviews.apache.org/r/73919/diff/1/
>
>
> Testing
> -------
>
> Tested for fresh install(small/caps/camelcase) and upgrade(only small case)
>
>
> Thanks,
>
> Pradeep Agrawal
>
>