You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by ijuma <gi...@git.apache.org> on 2017/06/23 12:21:52 UTC

[GitHub] kafka pull request #3420: KAFKA-5506: Fix NPE in OffsetFetchRequest.toString

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/3420

    KAFKA-5506: Fix NPE in OffsetFetchRequest.toString

    Also avoid eager toString call in parameter passed to log.debug.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka kafka-5506-offset-fetch-request-to-string-npe

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3420.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3420
    
----
commit 89343195d62227af42d535a11da97d4b497ed05f
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-06-23T12:18:54Z

    KAFKA-5506: Fix NPE in OffsetFetchRequest.toString

commit b3a17f57510215bb22acede4e17430a2465e702f
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-06-23T12:20:42Z

    Pass parameter to log.debug without calling toString
    
    This way we don't pay the cost unnecessarily

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3420: KAFKA-5506: Fix NPE in OffsetFetchRequest.toString

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/3420


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---