You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-commits@hadoop.apache.org by el...@apache.org on 2012/02/24 22:14:04 UTC
svn commit: r1293419 - in
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs: CHANGES.txt
src/main/java/org/apache/hadoop/hdfs/DFSClient.java
Author: eli
Date: Fri Feb 24 21:14:04 2012
New Revision: 1293419
URL: http://svn.apache.org/viewvc?rev=1293419&view=rev
Log:
HDFS-3008. Negative caching of local addrs doesn't work. Contributed by Eli Collins
Modified:
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
Modified: hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt?rev=1293419&r1=1293418&r2=1293419&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt (original)
+++ hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt Fri Feb 24 21:14:04 2012
@@ -280,6 +280,8 @@ Release 0.23.2 - UNRELEASED
dfs.client.block.write.replace-datanode-on-failure.enable should be true.
(szetszwo)
+ HDFS-3008. Negative caching of local addrs doesn't work. (eli)
+
Release 0.23.1 - 2012-02-17
INCOMPATIBLE CHANGES
Modified: hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java?rev=1293419&r1=1293418&r2=1293419&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java (original)
+++ hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java Fri Feb 24 21:14:04 2012
@@ -542,17 +542,19 @@ public class DFSClient implements java.i
private static boolean isLocalAddress(InetSocketAddress targetAddr) {
InetAddress addr = targetAddr.getAddress();
Boolean cached = localAddrMap.get(addr.getHostAddress());
- if (cached != null && cached) {
+ if (cached != null) {
if (LOG.isTraceEnabled()) {
- LOG.trace("Address " + targetAddr + " is local");
+ LOG.trace("Address " + targetAddr +
+ (cached ? " is local" : " is not local"));
}
- return true;
+ return cached;
}
boolean local = NetUtils.isLocalAddress(addr);
if (LOG.isTraceEnabled()) {
- LOG.trace("Address " + targetAddr + " is local");
+ LOG.trace("Address " + targetAddr +
+ (local ? " is local" : " is not local"));
}
localAddrMap.put(addr.getHostAddress(), local);
return local;