You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/03 16:03:04 UTC

[GitHub] [airflow] ashb opened a new pull request #21296: Fix relationship join bug in FAB/SecurityManager with SQLA 1.4

ashb opened a new pull request #21296:
URL: https://github.com/apache/airflow/pull/21296

This is fixed in SQLA 1.4.19, but the fix makes the intent clearer here anyway.

(I haven't yet tested this change locally fully -- images are rebuilding for me-- but it worked in the debugger where the previous query didn't)

<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.

Feel free to ping committers for the review!

In case of existing issue, reference it using one of the following:

closes: #ISSUE
related: #ISSUE

How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->

---
**^ Add meaningful description above**

Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on pull request #21296: Fix relationship join bug in FAB/SecurityManager with SQLA 1.4

Posted by GitBox <gi...@apache.org>.

ashb commented on pull request #21296:
URL: https://github.com/apache/airflow/pull/21296#issuecomment-1029146415


   Whops, hit cancel by mistake


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb closed pull request #21296: Fix relationship join bug in FAB/SecurityManager with SQLA 1.4

Posted by GitBox <gi...@apache.org>.

ashb closed pull request #21296:
URL: https://github.com/apache/airflow/pull/21296


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #21296: Fix relationship join bug in FAB/SecurityManager with SQLA 1.4

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #21296:
URL: https://github.com/apache/airflow/pull/21296#issuecomment-1029146855


   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] pingzh commented on pull request #21296: Fix relationship join bug in FAB/SecurityManager with SQLA 1.4

Posted by GitBox <gi...@apache.org>.

pingzh commented on pull request #21296:
URL: https://github.com/apache/airflow/pull/21296#issuecomment-1032131134


   could you please also put more context information about the relationship join bug that this pr tried to fix?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb merged pull request #21296: Fix relationship join bug in FAB/SecurityManager with SQLA 1.4

Posted by GitBox <gi...@apache.org>.

ashb merged pull request #21296:
URL: https://github.com/apache/airflow/pull/21296


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] pingzh commented on pull request #21296: Fix relationship join bug in FAB/SecurityManager with SQLA 1.4

Posted by GitBox <gi...@apache.org>.

pingzh commented on pull request #21296:
URL: https://github.com/apache/airflow/pull/21296#issuecomment-1032125611


   @ashb , looks like this pr has caused this issue https://github.com/apache/airflow/issues/21407
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on pull request #21296: Fix relationship join bug in FAB/SecurityManager with SQLA 1.4

Posted by GitBox <gi...@apache.org>.

ashb commented on pull request #21296:
URL: https://github.com/apache/airflow/pull/21296#issuecomment-1032465629


   It was fixing broken main build https://github.com/apache/airflow/runs/5051943355?check_suite_focus=true
   
   > tests/www/test_security.py::test_create_dag_specific_permissions: sqlalchemy.exc.InvalidRequestError: Don't know how to join to <Mapper at 0x7fcc61b11370; Action>. Please use the .select_from() method to establish an explicit left side, as well as providing an explicit ON clause if not present already to help resolve the ambiguity.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org