[GitHub] [spark] HyukjinKwon commented on issue #25243: [SPARK-28498][SQL][TEST] always create a fresh copy of the SparkSession before each test

[GitBox <gi...@apache.org>]

HyukjinKwon commented on issue #25243: [SPARK-28498][SQL][TEST] always create a fresh copy of the SparkSession before each test
URL: https://github.com/apache/spark/pull/25243#issuecomment-515033377
 
 
   > We don't have to but we'd better too. I won't encourage people to send test-only PRs to do the replacement, but when I need to add a new test in one suite, I would probably update the suite.
   
   I was trying to say both `SharedSparkSession` and `SharedSparkSessionWithFreshCopy` are fine but `SharedSparkSessionWithFreshCopy` is more preferred. So, it's still discouraged to make such PRs since either way is fine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org