[GitHub] [incubator-druid] himanshug commented on issue #6698: do not watch unwanted tier's data node in HttpServerInventoryView

[GitBox <gi...@apache.org>]

himanshug commented on issue #6698: do not watch unwanted tier's data node in HttpServerInventoryView
URL: https://github.com/apache/incubator-druid/pull/6698#issuecomment-486473879
 
 
   @kaijianding apologies for the gigantic delay. I think it is a great optimization opportunity and we should find a solution whether or not it is ideal.
   
   I agree with @egor-ryashin comment about `HttpServerInventoryView` knowing about tiers/servers to watch . In fact, I think it could have been done that way for zookeeper based impl too because that is also unnecessarily watching the segments for servers it is continuously discarding after the fact. It is just that the cost is not as high in that case.
   
   Simplest would be to get an instance of `BrokerSegmentWatcherConfig` injected in `HttpServerInventoryView` and use that. We will need to put some blurb in release notes for users to make sure and not accidentally have those properties set on coordinator node.
   
   PS: If I was doing things from scratch then I would've called it "BaseServerInventoryViewConfig" and named the watched tier property name (and some others) accordingly.
   
   @jihoonson does that sound reasonable to you ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org