You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/08/17 20:22:37 UTC
[GitHub] [incubator-pinot] jihaozh opened a new pull request #5882: [TE] change dimension explore early stop to be 10% of top k
jihaozh opened a new pull request #5882:
URL: https://github.com/apache/incubator-pinot/pull/5882
This PR changes the early stop in the dimension explorer to be 10% of k. Previously it was set to be 10 dimensions, which can be too strict when k is large. This change relaxes the failure threshold.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jihaozh merged pull request #5882: [TE] change dimension explore early stop to be 10% of top k
Posted by GitBox <gi...@apache.org>.
jihaozh merged pull request #5882:
URL: https://github.com/apache/incubator-pinot/pull/5882
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jihaozh commented on pull request #5882: [TE] change dimension explore early stop to be 10% of top k
Posted by GitBox <gi...@apache.org>.
jihaozh commented on pull request #5882:
URL: https://github.com/apache/incubator-pinot/pull/5882#issuecomment-675115511
> Looks great! If someone is continuously adding new dimensions without enough data, is there any logic that makes sure the new dimensions are checked later? For example, are nestedMetrics ordered?
yes. The k is ordered by the data volume during the monitoring window.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org