You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/05/04 10:35:35 UTC
[GitHub] [cloudstack-primate] utchoang opened a new pull request #307: [FIX] VM Deployment Wizard Changes
utchoang opened a new pull request #307:
URL: https://github.com/apache/cloudstack-primate/pull/307
Open for https://github.com/apache/cloudstack-primate/issues/306
@rhtyd cc @svenvogel
* [x] Template filter can be left to search box and not working
* [ ] TBD: should we add/have a way to add network, re-use the add network form perhaps?
* [x] Not able to specify a new group
* [x] Hypervisor option could be moved next to zone?
* [x] Changing default network has no effect
* [x] Do validation for form elements, looks like only zone is validated; but say service offering is not
* [x] Group ID passed instead of name in the deployVM API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] shwstppr commented on pull request #307: [FIX] VM Deployment Wizard Changes
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #307:
URL: https://github.com/apache/cloudstack-primate/pull/307#issuecomment-619929534
@utchoang @rhtyd when there are no VPCs
```
NetworksCreation.vue?733d:167 Uncaught (in promise) TypeError: Cannot read property 'unshift' of undefined
at eval (VM3349 NetworksCreation.vue:194)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on issue #307: [FIX] VM Deployment Wizard Changes
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #307:
URL: https://github.com/apache/cloudstack-primate/pull/307#issuecomment-618147573
* Move template/iso filter to left of search box
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on issue #307: [FIX] VM Deployment Wizard Changes
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #307:
URL: https://github.com/apache/cloudstack-primate/pull/307#issuecomment-618208782
Hi @rhtyd I have some questions:
1. For adding new network, do you mean you want to make it similar to the first version? (add networking in a network section)
2. Change default network: According to https://github.com/apache/cloudstack/blob/ef14e195c4b40be53466f081e4632547aa0cf43c/ui/scripts/instanceWizard.js#L1227. I found that in the old UI, the default network selected as will be ordered first in the list of network for send to server. Do you have any other requirements?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #307: [FIX] VM Deployment Wizard Changes
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #307:
URL: https://github.com/apache/cloudstack-primate/pull/307#issuecomment-623387823
Travis may pass in next run.
@utchoang can you have a look at #51
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #307: [FIX] VM Deployment Wizard Changes
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #307:
URL: https://github.com/apache/cloudstack-primate/pull/307#issuecomment-623924377
thanks @utchoang I'll test and merge this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang edited a comment on issue #307: [FIX] VM Deployment Wizard Changes
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #307:
URL: https://github.com/apache/cloudstack-primate/pull/307#issuecomment-618147573
* Move template/iso filter to left of search box
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #307: [FIX] VM Deployment Wizard Changes
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #307:
URL: https://github.com/apache/cloudstack-primate/pull/307#issuecomment-619828113
@rhtyd Can you answer my questions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #307: [FIX] VM Deployment Wizard Changes
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #307:
URL: https://github.com/apache/cloudstack-primate/pull/307#issuecomment-623803156
Hi @rhtyd I added the show password after deploy VM based on https://github.com/apache/cloudstack/blob/master/ui/scripts/instanceWizard.js#L1447. But I haven't tested it because I don't know how to do it. Please test me and give me your opinion if any.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #307: [FIX] VM Deployment Wizard Changes
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #307:
URL: https://github.com/apache/cloudstack-primate/pull/307#issuecomment-631353570
Yes it's on my radar @svenvogel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #307: [FIX] VM Deployment Wizard Changes
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #307:
URL: https://github.com/apache/cloudstack-primate/pull/307
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #307: [FIX] VM Deployment Wizard Changes
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #307:
URL: https://github.com/apache/cloudstack-primate/pull/307#issuecomment-619896371
@utchoang leave that network part, I'll handle that. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] svenvogel commented on pull request #307: [FIX] VM Deployment Wizard Changes
Posted by GitBox <gi...@apache.org>.
svenvogel commented on pull request #307:
URL: https://github.com/apache/cloudstack-primate/pull/307#issuecomment-631324277
@rhtyd could you find some time to check this? :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org