You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/11 14:09:28 UTC
[GitHub] [cloudstack] ravening opened a new pull request #4685: Display last updated time for VM
ravening opened a new pull request #4685:
URL: https://github.com/apache/cloudstack/pull/4685
### Description
Add a field in api response and ui to display last updated time
```
(local) mgt01 > list virtualmachinesmetrics filter=lastupdated,
{
"count": 1,
"virtualmachine": [
{
"lastupdated": "2021-02-10T15:43:14+0000"
}
]
}
(local) mgt01 > list virtualmachines filter=lastupdated,
{
"count": 1,
"virtualmachine": [
{
"lastupdated": "2021-02-10T15:43:14+0000"
}
]
}
```
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [X] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [X] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4685: Display last updated time for VM
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4685:
URL: https://github.com/apache/cloudstack/pull/4685#issuecomment-781035496
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4685: Display last updated time for VM
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4685:
URL: https://github.com/apache/cloudstack/pull/4685#issuecomment-889624750
<b>Trillian test result (tid-1412)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 55891 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4685-t1412-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 87 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3605.06 | test_kubernetes_clusters.py
test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 3163.62 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.18 | test_kubernetes_clusters.py
test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 0.07 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 88.67 | test_kubernetes_clusters.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 470.43 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 476.52 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 476.53 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4685: Display last updated time for VM
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4685:
URL: https://github.com/apache/cloudstack/pull/4685#issuecomment-888927375
> @ravening pl fix the conflict
@rhtyd @sureshanaparti fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4685: Display last updated time for VM
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4685:
URL: https://github.com/apache/cloudstack/pull/4685#issuecomment-889031666
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 686
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4685: Display last updated time for VM
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4685:
URL: https://github.com/apache/cloudstack/pull/4685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4685: Display last updated time for VM
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4685:
URL: https://github.com/apache/cloudstack/pull/4685#issuecomment-778602672
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2703
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4685: Display last updated time for VM
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4685:
URL: https://github.com/apache/cloudstack/pull/4685#issuecomment-791902261
@ravening pl fix the conflict
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4685: Display last updated time for VM
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4685:
URL: https://github.com/apache/cloudstack/pull/4685#issuecomment-781057553
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2729
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4685: Display last updated time for VM
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4685:
URL: https://github.com/apache/cloudstack/pull/4685#issuecomment-781035138
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4685: Display last updated time for VM
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4685:
URL: https://github.com/apache/cloudstack/pull/4685#issuecomment-889074930
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4685: Display last updated time for VM
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4685:
URL: https://github.com/apache/cloudstack/pull/4685#issuecomment-778119966
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez commented on a change in pull request #4685: Display last updated time for VM
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on a change in pull request #4685:
URL: https://github.com/apache/cloudstack/pull/4685#discussion_r682769034
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/UserVmResponse.java
##########
@@ -82,6 +82,10 @@
@Param(description = "the date when this virtual machine was created")
private Date created;
+ @SerializedName("lastupdated")
+ @Param(description="the date when this virtual machine was updated last time")
Review comment:
minor changes request: add since on this new parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4685: Display last updated time for VM
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4685:
URL: https://github.com/apache/cloudstack/pull/4685#issuecomment-778119431
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4685: Display last updated time for VM
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4685:
URL: https://github.com/apache/cloudstack/pull/4685#issuecomment-779043546
@ravening conflict here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4685: Display last updated time for VM
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4685:
URL: https://github.com/apache/cloudstack/pull/4685#issuecomment-895052335
Tests LGTM, failures not related to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4685: Display last updated time for VM
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4685:
URL: https://github.com/apache/cloudstack/pull/4685#discussion_r685015094
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/UserVmResponse.java
##########
@@ -82,6 +82,10 @@
@Param(description = "the date when this virtual machine was created")
private Date created;
+ @SerializedName("lastupdated")
+ @Param(description="the date when this virtual machine was updated last time")
Review comment:
I've added and checked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez commented on a change in pull request #4685: Display last updated time for VM
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on a change in pull request #4685:
URL: https://github.com/apache/cloudstack/pull/4685#discussion_r682769034
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/UserVmResponse.java
##########
@@ -82,6 +82,10 @@
@Param(description = "the date when this virtual machine was created")
private Date created;
+ @SerializedName("lastupdated")
+ @Param(description="the date when this virtual machine was updated last time")
Review comment:
minor changes request: add since on this new parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4685: Display last updated time for VM
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4685:
URL: https://github.com/apache/cloudstack/pull/4685#issuecomment-869190686
ping @ravening can you resolve the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4685: Display last updated time for VM
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4685:
URL: https://github.com/apache/cloudstack/pull/4685#issuecomment-778593759
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4685: Display last updated time for VM
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4685:
URL: https://github.com/apache/cloudstack/pull/4685#issuecomment-781231136
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2730
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4685: Display last updated time for VM
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4685:
URL: https://github.com/apache/cloudstack/pull/4685#issuecomment-778593665
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4685: Display last updated time for VM
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4685:
URL: https://github.com/apache/cloudstack/pull/4685#issuecomment-889075489
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4685: Display last updated time for VM
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4685:
URL: https://github.com/apache/cloudstack/pull/4685#issuecomment-778158345
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2688
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org