You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by dh...@apache.org on 2008/03/13 20:25:10 UTC

svn commit: r636846 - in /hadoop/core/trunk: CHANGES.txt src/java/org/apache/hadoop/dfs/DFSClient.java

Author: dhruba
Date: Thu Mar 13 12:25:08 2008
New Revision: 636846

URL: http://svn.apache.org/viewvc?rev=636846&view=rev
Log:
HADOOP-2994. Code cleanup for DFSClient: remove redundant
conversions from string to string.  (Dave Brosius via dhruba)


Modified:
    hadoop/core/trunk/CHANGES.txt
    hadoop/core/trunk/src/java/org/apache/hadoop/dfs/DFSClient.java

Modified: hadoop/core/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/CHANGES.txt?rev=636846&r1=636845&r2=636846&view=diff
==============================================================================
--- hadoop/core/trunk/CHANGES.txt (original)
+++ hadoop/core/trunk/CHANGES.txt Thu Mar 13 12:25:08 2008
@@ -196,6 +196,9 @@
     HADOOP-2972. Fix for a NPE in FSDataset.invalidate.
     (Mahadev Konar via dhruba)
 
+    HADOOP-2994. Code cleanup for DFSClient: remove redundant 
+    conversions from string to string.  (Dave Brosius via dhruba)
+
 Release 0.16.1 - 2008-03-13
 
   INCOMPATIBLE CHANGES

Modified: hadoop/core/trunk/src/java/org/apache/hadoop/dfs/DFSClient.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/java/org/apache/hadoop/dfs/DFSClient.java?rev=636846&r1=636845&r2=636846&view=diff
==============================================================================
--- hadoop/core/trunk/src/java/org/apache/hadoop/dfs/DFSClient.java (original)
+++ hadoop/core/trunk/src/java/org/apache/hadoop/dfs/DFSClient.java Thu Mar 13 12:25:08 2008
@@ -407,7 +407,7 @@
     OutputStream result = new DFSOutputStream(src, masked,
         overwrite, replication, blockSize, progress, buffersize);
     synchronized (pendingCreates) {
-      pendingCreates.put(src.toString(), result);
+      pendingCreates.put(src, result);
     }
     return result;
   }
@@ -2192,7 +2192,7 @@
         long localstart = System.currentTimeMillis();
         while (true) {
           try {
-            return namenode.addBlock(src.toString(), clientName);
+            return namenode.addBlock(src, clientName);
           } catch (RemoteException e) {
             if (--retries == 0 && 
                 !NotReplicatedYetException.class.getName().
@@ -2514,7 +2514,7 @@
         long localstart = System.currentTimeMillis();
         boolean fileComplete = false;
         while (!fileComplete) {
-          fileComplete = namenode.complete(src.toString(), clientName);
+          fileComplete = namenode.complete(src, clientName);
           if (!fileComplete) {
             try {
               Thread.sleep(400);