version_check.pl bug?

[Bojan Smojver <bo...@rexursive.com>]

Just got a report from Fedora build system that libapreq2-2.09-rc1
failed to build. The error was:

---------------------------
build/version_check.pl failed: automake version 1.10 unsupported (1.6.1
or greater is required).
---------------------------

Now, 1.10 _is_ greater than 1.6.1, however, the script does:

---------------------------
if ($saw =~ /^(\d+)(\.(\d+))$/) {
    $fail = $saw < $version;
---------------------------

So, numeric comparison is done, even if $version isn't really numeric
(i.e. "1.6.1"). I think we should have:

---------------------------
if ($saw =~ /^(\d+)(\.(\d+))$/ and $version =~ /^(\d+)(\.(\d+))$/) {
---------------------------

Otherwise, the comparison is bound to fail.

-- 
Bojan

Re: version_check.pl bug?

[Bojan Smojver <bo...@rexursive.com>]

On Wed, 2007-01-31 at 11:46 +1100, Bojan Smojver wrote:
> Just got a report from Fedora build system that libapreq2-2.09-rc1
> failed to build.

Sorry, I meant rc2 here.

-- 
Bojan

Re: version_check.pl bug?

[Bojan Smojver <bo...@rexursive.com>]

On Thu, 2007-02-08 at 09:12 +1100, Bojan Smojver wrote:

> Committed to trunk, revision 504716.

Back-ported to 2.09 branch in revision 504735.

-- 
Bojan

Re: version_check.pl bug?

[Bojan Smojver <bo...@rexursive.com>]

On Wed, 2007-01-31 at 11:46 +1100, Bojan Smojver wrote:

> ---------------------------
> if ($saw =~ /^(\d+)(\.(\d+))$/ and $version =~ /^(\d+)(\.(\d+))$/) {
> ---------------------------

Committed to trunk, revision 504716.

-- 
Bojan