[GitHub] [arrow] domoritz commented on a change in pull request #9988: ARROW-12333: [JS] Remove jest-environment-node-debug and do not emit from typescript by default

[GitBox <gi...@apache.org>]

domoritz commented on a change in pull request #9988:
URL: https://github.com/apache/arrow/pull/9988#discussion_r611241493



##########
File path: js/tsconfig.json
##########
@@ -6,6 +6,7 @@
   },
   "compilerOptions": {
     "target": "ESNEXT",
-    "module": "commonjs"
+    "module": "commonjs",
+    "noEmit": true

Review comment:
       Now we can run yarn tsc to check types without accidentally writing a bunch of files.

##########
File path: js/package.json
##########
@@ -86,7 +86,6 @@
     "gulp-typescript": "5.0.1",
     "ix": "2.5.3",
     "jest": "26.3.0",
-    "jest-environment-node-debug": "2.0.0",

Review comment:
       I didn't see it being used anywhere. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org