You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/29 05:15:40 UTC
[GitHub] [arrow] cyb70289 opened a new pull request #8295: ARROW-10090: [C++][Compute] Improve mode kernel
cyb70289 opened a new pull request #8295:
URL: https://github.com/apache/arrow/pull/8295
- Replace naive array data visitor with optimized VisitArrayDataInline.
It improves performance significantly.
- Add chunked array test cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on pull request #8295: ARROW-10090: [C++][Compute] Improve mode kernel
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on pull request #8295:
URL: https://github.com/apache/arrow/pull/8295#issuecomment-700431722
Tested on Xeon Gold 5218, clang-9.
```
$ archery benchmark diff --suite-filter="arrow-compute-aggregate-benchmark" --benchmark-filter="^Mode" --cc=clang-9 --cxx=clang++-9
benchmark baseline contender change
22 ModeKernelInt16/1048576/10000 349.284 MiB/sec 830.555 MiB/sec 137.788 'null_percent': 0.01
29 ModeKernelInt32/1048576/10000 727.934 MiB/sec 1.571 GiB/sec 121.055 'null_percent': 0.01
7 ModeKernelInt64/1048576/10000 1.337 GiB/sec 2.748 GiB/sec 105.521 'null_percent': 0.01
17 ModeKernelInt8/1048576/0 268.265 MiB/sec 501.093 MiB/sec 86.790 'null_percent': 0.0
20 ModeKernelInt16/1048576/0 465.800 MiB/sec 866.189 MiB/sec 85.957 'null_percent': 0.0
2 ModeKernelInt8/1048576/10000 250.001 MiB/sec 457.959 MiB/sec 83.183 'null_percent': 0.01
0 ModeKernelBoolean/1048576/0 27.846 MiB/sec 50.202 MiB/sec 80.289 'null_percent': 0.0
9 ModeKernelBoolean/1048576/10000 26.292 MiB/sec 46.369 MiB/sec 76.361 'null_percent': 0.01
26 ModeKernelInt16/1048576/100 343.751 MiB/sec 605.499 MiB/sec 76.145 'null_percent': 1.0
3 ModeKernelInt32/1048576/0 976.138 MiB/sec 1.647 GiB/sec 72.772 'null_percent': 0.0
14 ModeKernelInt8/1048576/100 251.590 MiB/sec 434.547 MiB/sec 72.720 'null_percent': 1.0
21 ModeKernelBoolean/1048576/100 26.541 MiB/sec 44.134 MiB/sec 66.282 'null_percent': 1.0
23 ModeKernelInt64/1048576/0 1.752 GiB/sec 2.898 GiB/sec 65.389 'null_percent': 0.0
8 ModeKernelInt32/1048576/100 735.448 MiB/sec 1.159 GiB/sec 61.374 'null_percent': 1.0
18 ModeKernelInt64/1048576/100 1.330 GiB/sec 1.851 GiB/sec 39.201 'null_percent': 1.0
12 ModeKernelInt8/1048576/10 259.509 MiB/sec 332.128 MiB/sec 27.983 'null_percent': 10.0
24 ModeKernelBoolean/1048576/10 28.238 MiB/sec 35.918 MiB/sec 27.196 'null_percent': 10.0
1 ModeKernelInt16/1048576/10 315.322 MiB/sec 399.613 MiB/sec 26.732 'null_percent': 10.0
6 ModeKernelInt64/1048576/10 1.165 GiB/sec 1.365 GiB/sec 17.157 'null_percent': 10.0
16 ModeKernelInt32/1048576/10 674.053 MiB/sec 788.993 MiB/sec 17.052 'null_percent': 10.0
13 ModeKernelInt16/1048576/2 194.696 MiB/sec 215.931 MiB/sec 10.907 'null_percent': 50.0
10 ModeKernelInt16/1048576/1 994.201 GiB/sec 1.035 TiB/sec 6.572 null_percent': 100.0
5 ModeKernelInt64/1048576/2 772.357 MiB/sec 777.830 MiB/sec 0.709 'null_percent': 50.0
15 ModeKernelInt32/1048576/1 1.041 TiB/sec 1.046 TiB/sec 0.484 null_percent': 100.0
4 ModeKernelInt64/1048576/1 1.033 TiB/sec 1.037 TiB/sec 0.349 null_percent': 100.0
27 ModeKernelInt32/1048576/2 436.566 MiB/sec 431.104 MiB/sec -1.251 'null_percent': 50.0
28 ModeKernelInt8/1048576/1 747.523 GiB/sec 731.296 GiB/sec -2.171 null_percent': 100.0
19 ModeKernelBoolean/1048576/1 1.003 TiB/sec 956.829 GiB/sec -6.794 null_percent': 100.0
25 ModeKernelInt8/1048576/2 243.506 MiB/sec 215.637 MiB/sec -11.445 'null_percent': 50.0
11 ModeKernelBoolean/1048576/2 28.771 MiB/sec 23.861 MiB/sec -17.067 'null_percent': 50.0
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8295: ARROW-10090: [C++][Compute] Improve mode kernel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8295:
URL: https://github.com/apache/arrow/pull/8295#issuecomment-700440256
https://issues.apache.org/jira/browse/ARROW-10090
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #8295: ARROW-10090: [C++][Compute] Improve mode kernel
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #8295:
URL: https://github.com/apache/arrow/pull/8295
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org