You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openserverless.apache.org by "sciabarracom (via GitHub)" <gi...@apache.org> on 2025/05/12 13:49:20 UTC
[PR] devel branch [openserverless]
sciabarracom opened a new pull request, #127:
URL: https://github.com/apache/openserverless/pull/127
<!-- Please make sure you have read and understood the contributing guidelines -->
- [ ] I have registered the PR [changes](../changes).
where is this file?
### Ⅰ. Describe what this PR did
created a devel subfolder for writing the new installer and operator for using openwhisk2
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
fixes #121
### Ⅲ. Why don't you add test cases (unit test/integration test)?
Just PoC code so far
### Ⅳ. Describe how to verify it
```
cd devel
ops setup2 k s i hello
```
You should read `install standalone hello`
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openserverless.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] devel branch [openserverless]
Posted by "francescotimperi (via GitHub)" <gi...@apache.org>.
francescotimperi commented on code in PR #127:
URL: https://github.com/apache/openserverless/pull/127#discussion_r2106120722
##########
devel/images/standalone/Dockerfile:
##########
Review Comment:
Indeed a jre should be more than enough to run the standalone. For the PR pending towards the Openwhisk project we enforced the eclipse-temurin:11-jre-alpine and it works pretty smooth I would say.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openserverless.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] devel branch [openserverless]
Posted by "d4rkstar (via GitHub)" <gi...@apache.org>.
d4rkstar commented on code in PR #127:
URL: https://github.com/apache/openserverless/pull/127#discussion_r2106119199
##########
devel/images/standalone/Dockerfile:
##########
Review Comment:
@sciabarracom here you can probably use smaller JRE like openjdk:11-jre-slim. Don't know if eclipse-temurin:11-jre-alpine or adoptopenjdk:11-jre-hotspot-buster can work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openserverless.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] devel branch [openserverless]
Posted by "sciabarracom (via GitHub)" <gi...@apache.org>.
sciabarracom commented on code in PR #127:
URL: https://github.com/apache/openserverless/pull/127#discussion_r2107506905
##########
devel/images/standalone/Dockerfile:
##########
Review Comment:
actully I can remove the image as Francesco already built the proper images
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openserverless.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] devel branch [openserverless]
Posted by "sciabarracom (via GitHub)" <gi...@apache.org>.
sciabarracom merged PR #127:
URL: https://github.com/apache/openserverless/pull/127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openserverless.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org