You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/07 12:14:02 UTC

[GitHub] [arrow] pitrou commented on a diff in pull request #13293: ARROW-16725: [C++] Fix compilation warnings in release mode

pitrou commented on code in PR #13293:
URL: https://github.com/apache/arrow/pull/13293#discussion_r891141170


##########
cpp/src/arrow/compute/kernels/vector_sort.cc:
##########
@@ -2006,10 +2006,11 @@ class ArrayRanker : public TypeVisitor {
       }
 
       case RankOptions::Min: {
-        T curr_value, prev_value;
+        T curr_value, prev_value{};
+        rank = 0;
 
         if (null_placement_ == NullPlacement::AtStart) {
-          rank = 1;
+          rank++;

Review Comment:
   Just for consistency for other similar code blocks above.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org