You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/03/06 14:26:55 UTC
[GitHub] [qpid-dispatch] fgiorgetti opened a new pull request #696: WIP:
DISPATCH-1586 - Added allocator metrics
fgiorgetti opened a new pull request #696: WIP: DISPATCH-1586 - Added allocator metrics
URL: https://github.com/apache/qpid-dispatch/pull/696
Needs to be reviewed and metric must have the correct suffixes, following
prometheus conventions (https://prometheus.io/docs/practices/naming/).
Please review and let me know if the approach below seems valid or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-io commented on issue #696: WIP:
DISPATCH-1586 - Added allocator metrics
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #696: WIP: DISPATCH-1586 - Added allocator metrics
URL: https://github.com/apache/qpid-dispatch/pull/696#issuecomment-610495275
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/696?src=pr&el=h1) Report
> Merging [#696](https://codecov.io/gh/apache/qpid-dispatch/pull/696?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/08bc3b02d367a3e02f6eece6f10e090277f6cb51&el=desc) will **decrease** coverage by `0.16%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/696?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #696 +/- ##
==========================================
- Coverage 86.98% 86.81% -0.17%
==========================================
Files 94 94
Lines 21412 21413 +1
==========================================
- Hits 18625 18590 -35
- Misses 2787 2823 +36
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/696?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/696/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `84.68% <0.00%> (-1.75%)` | :arrow_down: |
| [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/696/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `92.64% <0.00%> (-1.32%)` | :arrow_down: |
| [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/696/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `94.49% <0.00%> (-0.69%)` | :arrow_down: |
| [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/696/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `79.94% <0.00%> (-0.59%)` | :arrow_down: |
| [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/696/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `89.66% <0.00%> (-0.57%)` | :arrow_down: |
| [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/696/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==) | `90.95% <0.00%> (-0.40%)` | :arrow_down: |
| [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/696/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `87.80% <0.00%> (-0.23%)` | :arrow_down: |
| [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/696/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.17% <0.00%> (-0.19%)` | :arrow_down: |
| [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/696/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j) | `82.14% <0.00%> (-0.17%)` | :arrow_down: |
| [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/696/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.45% <0.00%> (+<0.01%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/696?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/696?src=pr&el=footer). Last update [08bc3b0...1e3d0e0](https://codecov.io/gh/apache/qpid-dispatch/pull/696?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org