You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/06/21 00:14:40 UTC
[kudu-CR](branch-1.10.x) [java] KUDU-2873: attach authz tokens to SplitKeyRangeRequests
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13694
Change subject: [java] KUDU-2873: attach authz tokens to SplitKeyRangeRequests
......................................................................
[java] KUDU-2873: attach authz tokens to SplitKeyRangeRequests
This adds the fetching of the token, and tests to make sure that it
exercises the same token reacquisition logic we have for writes and
scans.
Note: tserver-side testing for the endpoint can be found in
tablet_server_authorization-test.cc.
Change-Id: I2b4140076206f25b34d8025b45118e3ff7b4b826
Reviewed-on: http://gerrit.cloudera.org:8080/13692
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit 8c68c946d467a466fa2d7f21c283fc083d380d29)
---
M java/kudu-client/src/main/java/org/apache/kudu/client/SplitKeyRangeRequest.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthTokenReacquire.java
2 files changed, 31 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/13694/1
--
To view, visit http://gerrit.cloudera.org:8080/13694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b4140076206f25b34d8025b45118e3ff7b4b826
Gerrit-Change-Number: 13694
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR](branch-1.10.x) [java] KUDU-2873: attach authz tokens to SplitKeyRangeRequests
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13694 )
Change subject: [java] KUDU-2873: attach authz tokens to SplitKeyRangeRequests
......................................................................
[java] KUDU-2873: attach authz tokens to SplitKeyRangeRequests
This adds the fetching of the token, and tests to make sure that it
exercises the same token reacquisition logic we have for writes and
scans.
Note: tserver-side testing for the endpoint can be found in
tablet_server_authorization-test.cc.
Change-Id: I2b4140076206f25b34d8025b45118e3ff7b4b826
Reviewed-on: http://gerrit.cloudera.org:8080/13692
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit 8c68c946d467a466fa2d7f21c283fc083d380d29)
Reviewed-on: http://gerrit.cloudera.org:8080/13694
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Andrew Wong <aw...@cloudera.com>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/SplitKeyRangeRequest.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthTokenReacquire.java
2 files changed, 31 insertions(+), 1 deletion(-)
Approvals:
Grant Henke: Looks good to me, approved
Andrew Wong: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b4140076206f25b34d8025b45118e3ff7b4b826
Gerrit-Change-Number: 13694
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.10.x) [java] KUDU-2873: attach authz tokens to SplitKeyRangeRequests
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13694 )
Change subject: [java] KUDU-2873: attach authz tokens to SplitKeyRangeRequests
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b4140076206f25b34d8025b45118e3ff7b4b826
Gerrit-Change-Number: 13694
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 21 Jun 2019 03:03:40 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.10.x) [java] KUDU-2873: attach authz tokens to SplitKeyRangeRequests
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13694 )
Change subject: [java] KUDU-2873: attach authz tokens to SplitKeyRangeRequests
......................................................................
Patch Set 2: Verified+1
Java test failed because of NTP issues.
--
To view, visit http://gerrit.cloudera.org:8080/13694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b4140076206f25b34d8025b45118e3ff7b4b826
Gerrit-Change-Number: 13694
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 21 Jun 2019 05:02:53 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.10.x) [java] KUDU-2873: attach authz tokens to SplitKeyRangeRequests
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.
Change subject: [java] KUDU-2873: attach authz tokens to SplitKeyRangeRequests
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I2b4140076206f25b34d8025b45118e3ff7b4b826
Gerrit-Change-Number: 13694
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)