[GitHub] [helix] lei-xia commented on a change in pull request #1441: Catch exception in group commit

[GitBox <gi...@apache.org>]

lei-xia commented on a change in pull request #1441:
URL: https://github.com/apache/helix/pull/1441#discussion_r500485957



##########
File path: helix-core/src/main/java/org/apache/helix/GroupCommit.java
##########
@@ -112,6 +112,9 @@ public boolean commit(BaseDataAccessor<ZNRecord> accessor, int options, String k
             merged = accessor.get(mergedKey, null, options);
           } catch (ZkNoNodeException e) {
             // OK.
+          } catch (Exception e) {

Review comment:
       There are a few places that call DataAccessor.updateProperty but did not check the return results, we may want to double check whether it is appropriate (i.e, adding check there if it cares writing failure).
   
   one example is:  HelixAdmin->addTypeToCustomizedStateConfig()




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org