You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2022/11/02 01:48:32 UTC

[GitHub] [orc] coderex2522 commented on a diff in pull request #1299: ORC-1304: [C++] Fix bug of seeking over empty PRESENT stream

coderex2522 commented on code in PR #1299:
URL: https://github.com/apache/orc/pull/1299#discussion_r1011064465


##########
c++/test/TestPredicatePushdown.cc:
##########
@@ -557,4 +557,103 @@ namespace orc {
       TestFirstStripeSelectedWithStripeStats(reader.get(), pos);
     }
   }
+
+  TEST(TestPredicatePushdown, testSeekOverEmptyPresentStream) {

Review Comment:
   I move the ut into the TestReader.cc file because the ParseError exception was not handled during the read operation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org