You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by ma...@apache.org on 2016/07/29 01:59:35 UTC
kylin git commit: KYLIN-1922 bug fix
Repository: kylin
Updated Branches:
refs/heads/beforepomupdate ebf037d39 -> 1ed00678f
KYLIN-1922 bug fix
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/1ed00678
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/1ed00678
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/1ed00678
Branch: refs/heads/beforepomupdate
Commit: 1ed00678ff8f5a3b661f00a089622e73b549c72c
Parents: ebf037d
Author: Hongbin Ma <ma...@apache.org>
Authored: Fri Jul 29 09:59:28 2016 +0800
Committer: Hongbin Ma <ma...@apache.org>
Committed: Fri Jul 29 09:59:28 2016 +0800
----------------------------------------------------------------------
.../java/org/apache/kylin/storage/gtrecord/CubeSegmentScanner.java | 2 +-
.../org/apache/kylin/storage/gtrecord/GTCubeStorageQueryBase.java | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kylin/blob/1ed00678/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/CubeSegmentScanner.java
----------------------------------------------------------------------
diff --git a/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/CubeSegmentScanner.java b/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/CubeSegmentScanner.java
index cb3bc3b..9ca53f9 100644
--- a/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/CubeSegmentScanner.java
+++ b/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/CubeSegmentScanner.java
@@ -69,7 +69,7 @@ public class CubeSegmentScanner implements IGTScanner {
}
scanRequest = scanRangePlanner.planScanRequest();
if (scanRequest != null) {
- scanRequest.setAllowPreAggregation(!context.isNeedStorageAggregation());
+ scanRequest.setAllowPreAggregation(context.isNeedStorageAggregation());
scanRequest.setAggrCacheGB(cubeSeg.getCubeInstance().getConfig().getQueryCoprocessorMemGB());
if (context.isLimitEnabled())
scanRequest.setRowLimit(context.getLimit());
http://git-wip-us.apache.org/repos/asf/kylin/blob/1ed00678/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/GTCubeStorageQueryBase.java
----------------------------------------------------------------------
diff --git a/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/GTCubeStorageQueryBase.java b/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/GTCubeStorageQueryBase.java
index 3cc7bb8..7acf186 100644
--- a/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/GTCubeStorageQueryBase.java
+++ b/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/GTCubeStorageQueryBase.java
@@ -223,6 +223,7 @@ public abstract class GTCubeStorageQueryBase implements IStorageQuery {
}
public boolean isNeedStorageAggregation(Cuboid cuboid, Collection<TblColRef> groupD, Collection<TblColRef> singleValueD, boolean isExactAggregation) {
+ logger.info("Set isNeedStorageAggregation to " + !isExactAggregation);
return !isExactAggregation;
}