You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:56:26 UTC

[GitHub] [incubator-iotdb] neuyilan commented on a change in pull request #1264: [IOTDB-708] add config for inferring data type from string value

neuyilan commented on a change in pull request #1264:
URL: https://github.com/apache/incubator-iotdb/pull/1264#discussion_r430139179



##########
File path: server/src/assembly/resources/conf/iotdb-engine.properties
##########
@@ -390,6 +390,18 @@ enable_auto_create_schema=true
 #      we will set root.sg0 as the storage group if storage group level is 1
 default_storage_group_level=1
 
+# ALL data types: BOOLEAN, INT32, INT64, FLOAT, DOUBLE, TEXT
+
+# when receive boolean string "true" or "false", we register the time series as BOOLEAN type
+boolean_string_infer_type=BOOLEAN
+
+# when receive an integer string "67", we register the time series as INT32 type
+integer_string_infer_type=FLOAT

Review comment:
       IMO,it's better to set FLOAT as default like InfluxDB, and I encountered a scenario where the first number the user started to transmit is generally 0, which is actually of type float. In this case, if the default configuration is INT32, the insertion will not succeed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org