You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/08/01 07:25:00 UTC

[jira] [Commented] (CAMEL-12575) camel-cxfrs: NPE on GET request with Content-Type header

    [ https://issues.apache.org/jira/browse/CAMEL-12575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564872#comment-16564872 ] 

ASF GitHub Bot commented on CAMEL-12575:
----------------------------------------

oscerd commented on issue #2446: CAMEL-12575:NPE on GET request with Content-Type header
URL: https://github.com/apache/camel/pull/2446#issuecomment-409476750
 
 
   Thanks, merged on master, 2.22.x and 2.21.x

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> camel-cxfrs: NPE on GET request with Content-Type header
> --------------------------------------------------------
>
>                 Key: CAMEL-12575
>                 URL: https://issues.apache.org/jira/browse/CAMEL-12575
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-cxfrs
>    Affects Versions: 2.21.1
>            Reporter: Chris Ribble
>            Assignee: Ramu
>            Priority: Major
>             Fix For: 2.21.3, 2.22.1, 2.23.0
>
>
> This commit  [https://github.com/apache/camel/commit/e4ad40f2eebb68cfde175b171538e26b278f63f6] modified DefaultCxfRsBinding.populateCxfRsResponseFromExchange in a way that causes an NPE on line #116 when a GET request is made with the Content-Type header set. Since Camel copies the request headers into the response, this causes the check for Content-Type to find the header and the code after that assumes that cxfExchange.getOutMessage() is non-null.
> I can work around this by asking clients not to send the Content-Type header (which is generally meaningless for a GET), but I cannot force them not to send it. I think I can also add header filtering before the endpoint is executed to strip the Content-Type header for GET requests, but ideally DefaultCxfRsBinding.populateCxfRsResponseFromExchange would not call cxfExchange.getOutMessage().putIfAbsent if getOutMessage returns null.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)