[GitHub] [flink] luoyuxia commented on a diff in pull request #18920: [FLINK-26361][hive] Create LogicalFilter with CorrelationId to fix "unexpected correlate variable" exception when using Hive dialect

[GitBox <gi...@apache.org>]

luoyuxia commented on code in PR #18920:
URL: https://github.com/apache/flink/pull/18920#discussion_r907300197


##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserCalcitePlanner.java:
##########
@@ -1070,7 +1073,11 @@ private RelNode genFilterRelNode(
                             .convert(subQueryExpr)
                             .accept(funcConverter);
 
-            RelNode filterRel = LogicalFilter.create(srcRel, convertedFilterLHS);
+            RelNode filterRel =

Review Comment:
   Good point. But it's not enough for the fix.
   When replace with this code, the exception will still be thrown for the following sql
   `select * from src where src.key in (select c.key from (select * from src b where exists (select a.key from src a where b.value = a.value)) c);`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org