[GitHub] [pinot] xiangfu0 commented on a diff in pull request #10515: Allow ValueBlock length to increase in TransformFunction

["xiangfu0 (via GitHub)" <gi...@apache.org>]

xiangfu0 commented on code in PR #10515:
URL: https://github.com/apache/pinot/pull/10515#discussion_r1154094318


##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/GroovyTransformFunction.java:
##########
@@ -429,13 +408,11 @@ public double[][] transformToDoubleValuesMV(ValueBlock valueBlock) {
 
   @Override
   public String[][] transformToStringValuesMV(ValueBlock valueBlock) {
-    if (_stringValuesMV == null) {
-      _stringValuesMV = new String[DocIdSetPlanNode.MAX_DOC_PER_CALL][];
-    }
+    int length = valueBlock.getNumDocs();
+    initStringValuesMV(length);

Review Comment:
   Why this is set as `MAX_DOC_PER_CALL` initially? Will this causing the frequent resizing problem?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org