You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/03/03 01:54:57 UTC
[GitHub] [incubator-mxnet] Zha0q1 opened a new pull request #19973: [v1.x] ONNX Fixes for some NLP models
Zha0q1 opened a new pull request #19973:
URL: https://github.com/apache/incubator-mxnet/pull/19973
1. fix the output missing issue when the output is in the iniatilizer
2. fix shape issue in zeros_ and ones_
3. fix one_hot dtype issue
4. fix scalar_op_helper multi-dimensional tensor not being flattened issue
5. fix leaky_relu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 merged pull request #19973: [v1.x] ONNX Fixes for some NLP models
Posted by GitBox <gi...@apache.org>.
Zha0q1 merged pull request #19973:
URL: https://github.com/apache/incubator-mxnet/pull/19973
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #19973: [v1.x] ONNX Fixes for some NLP models
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on a change in pull request #19973:
URL: https://github.com/apache/incubator-mxnet/pull/19973#discussion_r586051613
##########
File path: python/mxnet/contrib/onnx/mx2onnx/_op_translations.py
##########
@@ -822,7 +822,7 @@ def convert_leakyrelu(node, **kwargs):
inputs=input_nodes,
outputs=[name],
name=name)
- elif act_type in ('gelu'):
+ elif act_type in ('gelu',):
Review comment:
otherwise this is not a tuple, and `elu` is in `gelu` so we will never go into the else branch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] josephevans commented on a change in pull request #19973: [v1.x] ONNX Fixes for some NLP models
Posted by GitBox <gi...@apache.org>.
josephevans commented on a change in pull request #19973:
URL: https://github.com/apache/incubator-mxnet/pull/19973#discussion_r588783944
##########
File path: python/mxnet/contrib/onnx/mx2onnx/_op_translations.py
##########
@@ -822,7 +822,7 @@ def convert_leakyrelu(node, **kwargs):
inputs=input_nodes,
outputs=[name],
name=name)
- elif act_type in ('gelu'):
+ elif act_type in ('gelu',):
Review comment:
Should we use a list for this instead? Why a tuple?
`elif act_type in ['gelu']:`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] waytrue17 commented on a change in pull request #19973: [v1.x] ONNX Fixes for some NLP models
Posted by GitBox <gi...@apache.org>.
waytrue17 commented on a change in pull request #19973:
URL: https://github.com/apache/incubator-mxnet/pull/19973#discussion_r586050813
##########
File path: python/mxnet/contrib/onnx/mx2onnx/_op_translations.py
##########
@@ -822,7 +822,7 @@ def convert_leakyrelu(node, **kwargs):
inputs=input_nodes,
outputs=[name],
name=name)
- elif act_type in ('gelu'):
+ elif act_type in ('gelu',):
Review comment:
Why do we add `,` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19973: [v1.x] ONNX Fixes for some NLP models
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19973:
URL: https://github.com/apache/incubator-mxnet/pull/19973#issuecomment-789364423
Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [sanity, windows-cpu, unix-cpu, centos-gpu, centos-cpu, windows-gpu, clang, website, unix-gpu, edge, miscellaneous]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org