You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/05 19:11:07 UTC
[GitHub] [pulsar] lhotari opened a new pull request #11575: [Tests] Fix cpp build not failing when tests fail
lhotari opened a new pull request #11575:
URL: https://github.com/apache/pulsar/pull/11575
### Motivation
- add issue that cpp build doesn't fail when tests fail
- merge after #11557
- https://github.com/apache/pulsar/pull/11557#issuecomment-893422981
- https://github.com/apache/pulsar/pull/10309/files#r683626563
### Modifications
- `set -o pipefail;` is required when using `| cat`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower merged pull request #11575: [Tests] Fix cpp build not failing when tests fail
Posted by GitBox <gi...@apache.org>.
BewareMyPower merged pull request #11575:
URL: https://github.com/apache/pulsar/pull/11575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #11575: [Tests] Fix cpp build not failing when tests fail
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #11575:
URL: https://github.com/apache/pulsar/pull/11575#issuecomment-893949858
Good job! After the tests are fixed, I'll notify you to rebase to master so that we can merge this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #11575: [Tests] Fix cpp build not failing when tests fail
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #11575:
URL: https://github.com/apache/pulsar/pull/11575#issuecomment-894812856
Now #11557 is merged, could you rebase to master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #11575: [Tests] Fix cpp build not failing when tests fail
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #11575:
URL: https://github.com/apache/pulsar/pull/11575#issuecomment-894835097
@BewareMyPower This PR is now rebased and ready for merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org