You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by omallassi <gi...@git.apache.org> on 2016/05/19 08:49:36 UTC
[GitHub] storm pull request: STORM-1850: State Checkpointing Documentation ...
GitHub user omallassi opened a pull request:
https://github.com/apache/storm/pull/1433
STORM-1850: State Checkpointing Documentation update
update the documentation following this discussion
https://mail-archives.apache.org/mod_mbox/storm-user/201605.mbox/%3CF9D9F747-8431-4A26-9028-BD74C09BCA84%40hortonworks.com%3E
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omallassi/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1433.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1433
----
commit 253fa793aadd3d7ac9f0d73e3301099ac1822049
Author: omallassi <om...@murex.com>
Date: 2016-05-19T08:43:06Z
State Checkpointing Documentation update
update the documentation following this discussion
https://mail-archives.apache.org/mod_mbox/storm-user/201605.mbox/%3CF9D9F747-8431-4A26-9028-BD74C09BCA84%40hortonworks.com%3E
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1850: State Checkpointing Documentation ...
Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1433#issuecomment-220894358
Thanks @omallassi this is merged to master and 1.x-branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1850: State Checkpointing Documentation ...
Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1433#issuecomment-220897907
@HeartSaVioR thanks for noticing. The changes are now merged to master, 1.x-branch and 1.0.x-branch.
@omallassi thanks for the patch. You may close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1850: State Checkpointing Documentation ...
Posted by omallassi <gi...@git.apache.org>.
Github user omallassi closed the pull request at:
https://github.com/apache/storm/pull/1433
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1850: State Checkpointing Documentation ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/1433#issuecomment-220894899
@arunmahadevan Seems like it would be better to apply this to 1.0.x as well. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1850: State Checkpointing Documentation ...
Posted by omallassi <gi...@git.apache.org>.
Github user omallassi closed the pull request at:
https://github.com/apache/storm/pull/1433
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1850: State Checkpointing Documentation ...
Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1433#issuecomment-220280889
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1850: State Checkpointing Documentation ...
Posted by hmcl <gi...@git.apache.org>.
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/1433#issuecomment-220402065
+1 once some minor grammar suggestions have been addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1850: State Checkpointing Documentation ...
Posted by omallassi <gi...@git.apache.org>.
GitHub user omallassi reopened a pull request:
https://github.com/apache/storm/pull/1433
STORM-1850: State Checkpointing Documentation update
update the documentation following this discussion
https://mail-archives.apache.org/mod_mbox/storm-user/201605.mbox/%3CF9D9F747-8431-4A26-9028-BD74C09BCA84%40hortonworks.com%3E
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omallassi/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1433.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1433
----
commit 253fa793aadd3d7ac9f0d73e3301099ac1822049
Author: omallassi <om...@murex.com>
Date: 2016-05-19T08:43:06Z
State Checkpointing Documentation update
update the documentation following this discussion
https://mail-archives.apache.org/mod_mbox/storm-user/201605.mbox/%3CF9D9F747-8431-4A26-9028-BD74C09BCA84%40hortonworks.com%3E
commit 1fec49b2d8bb22b0605d46ff10e7d697bc0c649a
Author: omallassi <ol...@gmail.com>
Date: 2016-05-20T07:33:27Z
STORM-1850: State Checkpointing Documentation update
grammar updates
commit 17dad93d1a7b123f94b4072625b2888839b03700
Author: omallassi <ol...@gmail.com>
Date: 2016-05-20T07:35:27Z
Merge remote-tracking branch 'refs/remotes/apache/master'
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1850: State Checkpointing Documentation ...
Posted by hmcl <gi...@git.apache.org>.
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1433#discussion_r63924300
--- Diff: docs/State-checkpointing.md ---
@@ -94,6 +94,9 @@ is saved and then the checkpoint tuple is forwarded to the next component. Each
streams before it saves its state so that the state represents a consistent state across the topology. Once the checkpoint spout receives
ACK from all the bolts, the state commit is complete and the transaction is recorded as committed by the checkpoint spout.
+The state checkpointing does not currently checkpoint the state of the spout. Yet, once the states of all bolts are checkpointed and once the checkpoint tuples is acked, the tuples emitted by the spout are acked.
+It also implies that `topology.state.checkpoint.interval.ms` is lower than `topology.message.timeout.secs`.
--- End diff --
once the *STATE* of all the bolts are checkpointed, and once the checkpoint tuples *ARE* acked.... by the spout are *ALSO* acked.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---