You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Alex Brett <al...@citrix.com> on 2014/06/12 15:27:09 UTC
Review Request 22512: CLOUDSTACK-6862 Don't run vGPU tests on KVM or in the
BVTs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22512/
-----------------------------------------------------------
Review request for cloudstack and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-6862 and CLOUDSTACK-6876
https://issues.apache.org/jira/browse/CLOUDSTACK-6862
https://issues.apache.org/jira/browse/CLOUDSTACK-6876
Repository: cloudstack-git
Description
-------
- Make this test skip if it's not running on a XenServer host (as that's the only hypervisor that supports vGPU at present)
- Also remove the tags that make this test run on a BVT, since it will *only* work if run on a host with vGPU hardware
See also CLOUDSTACK-6876 - I don't have rights to duplicate these two issues, but I believe they are the same thing.
Diffs
-----
test/integration/smoke/test_deploy_vgpu_enabled_vm.py fa33bdc
Diff: https://reviews.apache.org/r/22512/diff/
Testing
-------
Tested against a KVM host to ensure the skip logic kicks in.
Thanks,
Alex Brett
Re: Review Request 22512: CLOUDSTACK-6862 Don't run vGPU tests on KVM or in
the BVTs
Posted by Alex Brett <al...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22512/
-----------------------------------------------------------
(Updated June 12, 2014, 5:21 p.m.)
Review request for cloudstack and SrikanteswaraRao Talluri.
Changes
-------
Updated patch to fix the first issue
Bugs: CLOUDSTACK-6862 and CLOUDSTACK-6876
https://issues.apache.org/jira/browse/CLOUDSTACK-6862
https://issues.apache.org/jira/browse/CLOUDSTACK-6876
Repository: cloudstack-git
Description
-------
- Make this test skip if it's not running on a XenServer host (as that's the only hypervisor that supports vGPU at present)
- Also remove the tags that make this test run on a BVT, since it will *only* work if run on a host with vGPU hardware
See also CLOUDSTACK-6876 - I don't have rights to duplicate these two issues, but I believe they are the same thing.
Diffs (updated)
-----
test/integration/smoke/test_deploy_vgpu_enabled_vm.py fa33bdc
Diff: https://reviews.apache.org/r/22512/diff/
Testing
-------
Tested against a KVM host to ensure the skip logic kicks in.
Thanks,
Alex Brett
Re: Review Request 22512: CLOUDSTACK-6862 Don't run vGPU tests on KVM or in
the BVTs
Posted by Alex Brett <al...@citrix.com>.
> On June 12, 2014, 3:27 p.m., Santhosh Edukulla wrote:
> > test/integration/smoke/test_deploy_vgpu_enabled_vm.py, line 126
> > <https://reviews.apache.org/r/22512/diff/1/?file=608112#file608112line126>
> >
> > If this is specific to entire module, then its better we move this check to setup class instead and skip.
Which module are you referring to - there isn't a specific vGPU module in Marvin as far as I can see, the test just creates a ServiceOffering for VGPU with 'pciDevice': 'VGPU' set?
> On June 12, 2014, 3:27 p.m., Santhosh Edukulla wrote:
> > test/integration/smoke/test_deploy_vgpu_enabled_vm.py, line 164
> > <https://reviews.apache.org/r/22512/diff/1/?file=608112#file608112line164>
> >
> > Dont we require other advanced, basic,provisioning tags? Otherwise it may run on non required setups as well.
As I understand it (which is quite liable to be wrong) the tags are OR'd together, there's no way of specifying that a specific attribute *must* be provided for the test to run.
Only options here therefore are:
1. Ensure the BVTs (and any other run of Marvin tests that's not on VGPU hardware) have a !vgpu tag specified
2. Have a separate set of vgpu-advanced, vgpu-basic etc tags
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22512/#review45503
-----------------------------------------------------------
On June 12, 2014, 1:27 p.m., Alex Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22512/
> -----------------------------------------------------------
>
> (Updated June 12, 2014, 1:27 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-6862 and CLOUDSTACK-6876
> https://issues.apache.org/jira/browse/CLOUDSTACK-6862
> https://issues.apache.org/jira/browse/CLOUDSTACK-6876
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - Make this test skip if it's not running on a XenServer host (as that's the only hypervisor that supports vGPU at present)
> - Also remove the tags that make this test run on a BVT, since it will *only* work if run on a host with vGPU hardware
>
> See also CLOUDSTACK-6876 - I don't have rights to duplicate these two issues, but I believe they are the same thing.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_deploy_vgpu_enabled_vm.py fa33bdc
>
> Diff: https://reviews.apache.org/r/22512/diff/
>
>
> Testing
> -------
>
> Tested against a KVM host to ensure the skip logic kicks in.
>
>
> Thanks,
>
> Alex Brett
>
>
Re: Review Request 22512: CLOUDSTACK-6862 Don't run vGPU tests on KVM or in
the BVTs
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22512/#review45503
-----------------------------------------------------------
test/integration/smoke/test_deploy_vgpu_enabled_vm.py
<https://reviews.apache.org/r/22512/#comment80357>
If this is specific to entire module, then its better we move this check to setup class instead and skip.
test/integration/smoke/test_deploy_vgpu_enabled_vm.py
<https://reviews.apache.org/r/22512/#comment80358>
Dont we require other advanced, basic,provisioning tags? Otherwise it may run on non required setups as well.
- Santhosh Edukulla
On June 12, 2014, 1:27 p.m., Alex Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22512/
> -----------------------------------------------------------
>
> (Updated June 12, 2014, 1:27 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-6862 and CLOUDSTACK-6876
> https://issues.apache.org/jira/browse/CLOUDSTACK-6862
> https://issues.apache.org/jira/browse/CLOUDSTACK-6876
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - Make this test skip if it's not running on a XenServer host (as that's the only hypervisor that supports vGPU at present)
> - Also remove the tags that make this test run on a BVT, since it will *only* work if run on a host with vGPU hardware
>
> See also CLOUDSTACK-6876 - I don't have rights to duplicate these two issues, but I believe they are the same thing.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_deploy_vgpu_enabled_vm.py fa33bdc
>
> Diff: https://reviews.apache.org/r/22512/diff/
>
>
> Testing
> -------
>
> Tested against a KVM host to ensure the skip logic kicks in.
>
>
> Thanks,
>
> Alex Brett
>
>
Re: Review Request 22512: CLOUDSTACK-6862 Don't run vGPU tests on KVM or in
the BVTs
Posted by Alex Brett <al...@citrix.com>.
> On June 12, 2014, 3:56 p.m., Santhosh Edukulla wrote:
> > test/integration/smoke/test_deploy_vgpu_enabled_vm.py, line 164
> > <https://reviews.apache.org/r/22512/diff/1/?file=608112#file608112line164>
> >
> > We have to get nose tests discovery for that. We dont have a case for vgpu.
> > EX: A tag of advanced,means we want all advanced zone test cases, then this test case will as well be picked up otherwise wont if not tagged. Similarly, we can do and or with tags values provided separately.
Sorry I don't quite follow you - this test is running in the BVTs at the moment because it is being picked up by the 'basic' and 'advanced' tags, but as there's no vGPU hardware in use it would never work.
I suppose we could modify the test to skip if it's not running on vGPU hardware, but that's quite difficult to detect...
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22512/#review45510
-----------------------------------------------------------
On June 12, 2014, 5:21 p.m., Alex Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22512/
> -----------------------------------------------------------
>
> (Updated June 12, 2014, 5:21 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-6862 and CLOUDSTACK-6876
> https://issues.apache.org/jira/browse/CLOUDSTACK-6862
> https://issues.apache.org/jira/browse/CLOUDSTACK-6876
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - Make this test skip if it's not running on a XenServer host (as that's the only hypervisor that supports vGPU at present)
> - Also remove the tags that make this test run on a BVT, since it will *only* work if run on a host with vGPU hardware
>
> See also CLOUDSTACK-6876 - I don't have rights to duplicate these two issues, but I believe they are the same thing.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_deploy_vgpu_enabled_vm.py fa33bdc
>
> Diff: https://reviews.apache.org/r/22512/diff/
>
>
> Testing
> -------
>
> Tested against a KVM host to ensure the skip logic kicks in.
>
>
> Thanks,
>
> Alex Brett
>
>
Re: Review Request 22512: CLOUDSTACK-6862 Don't run vGPU tests on KVM or in
the BVTs
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22512/#review45510
-----------------------------------------------------------
test/integration/smoke/test_deploy_vgpu_enabled_vm.py
<https://reviews.apache.org/r/22512/#comment80361>
Iam referring to current test suite, please check setupClass in other test suites, the suite is explicit for vgpu, so this check should apply to all test classes inside it. So, if we add one more test class down the lane, the check still holds good.
test/integration/smoke/test_deploy_vgpu_enabled_vm.py
<https://reviews.apache.org/r/22512/#comment80362>
We have to get nose tests discovery for that. We dont have a case for vgpu.
EX: A tag of advanced,means we want all advanced zone test cases, then this test case will as well be picked up otherwise wont if not tagged. Similarly, we can do and or with tags values provided separately.
- Santhosh Edukulla
On June 12, 2014, 1:27 p.m., Alex Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22512/
> -----------------------------------------------------------
>
> (Updated June 12, 2014, 1:27 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-6862 and CLOUDSTACK-6876
> https://issues.apache.org/jira/browse/CLOUDSTACK-6862
> https://issues.apache.org/jira/browse/CLOUDSTACK-6876
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - Make this test skip if it's not running on a XenServer host (as that's the only hypervisor that supports vGPU at present)
> - Also remove the tags that make this test run on a BVT, since it will *only* work if run on a host with vGPU hardware
>
> See also CLOUDSTACK-6876 - I don't have rights to duplicate these two issues, but I believe they are the same thing.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_deploy_vgpu_enabled_vm.py fa33bdc
>
> Diff: https://reviews.apache.org/r/22512/diff/
>
>
> Testing
> -------
>
> Tested against a KVM host to ensure the skip logic kicks in.
>
>
> Thanks,
>
> Alex Brett
>
>