You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2015/06/20 16:07:49 UTC
[7/9] wicket git commit: FindBugs: remove 'synchronized' to
#setPageManagerProvider()
FindBugs: remove 'synchronized' to #setPageManagerProvider()
The getter is not synchronized. All other **Provider() methods are also not synchronized.
Usually these methods are called in Application#init() where there is no concurrency.
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/5f9f47d8
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/5f9f47d8
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/5f9f47d8
Branch: refs/heads/master
Commit: 5f9f47d88bc0a0ec5eb8a8b10c74ba428e06d484
Parents: 003d1c3
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Sat Jun 20 16:33:58 2015 +0300
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Sat Jun 20 16:33:58 2015 +0300
----------------------------------------------------------------------
wicket-core/src/main/java/org/apache/wicket/Application.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/5f9f47d8/wicket-core/src/main/java/org/apache/wicket/Application.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/Application.java b/wicket-core/src/main/java/org/apache/wicket/Application.java
index 056d4ae..f6c3f33 100644
--- a/wicket-core/src/main/java/org/apache/wicket/Application.java
+++ b/wicket-core/src/main/java/org/apache/wicket/Application.java
@@ -1485,7 +1485,7 @@ public abstract class Application implements UnboundListener, IEventSink
*
* @param provider
*/
- public synchronized final Application setPageManagerProvider(final IPageManagerProvider provider)
+ public final Application setPageManagerProvider(final IPageManagerProvider provider)
{
pageManagerProvider = provider;
return this;