You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jbertram <gi...@git.apache.org> on 2016/06/17 21:21:41 UTC
[GitHub] activemq-artemis pull request #588: ARTEMIS-563 update POODLE message
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/588
ARTEMIS-563 update POODLE message
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-563
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/588.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #588
----
commit 965033d2029885a596a0501bb8ccc329272d7195
Author: jbertram <jb...@apache.org>
Date: 2016-06-17T21:20:57Z
ARTEMIS-563 update POODLE message
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #588: ARTEMIS-563 update POODLE message
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/588#discussion_r67702691
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java ---
@@ -309,6 +309,12 @@ void slowConsumerDetected(String sessionID,
@Message(id = 221052, value = "trying to deploy topic {0}", format = Message.Format.MESSAGE_FORMAT)
void deployTopic(SimpleString topicName);
+ @LogMessage(level = Logger.Level.INFO)
--- End diff --
I see. Merged. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #588: ARTEMIS-563 update POODLE message
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/588#discussion_r67671276
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java ---
@@ -309,6 +309,12 @@ void slowConsumerDetected(String sessionID,
@Message(id = 221052, value = "trying to deploy topic {0}", format = Message.Format.MESSAGE_FORMAT)
void deployTopic(SimpleString topicName);
+ @LogMessage(level = Logger.Level.INFO)
--- End diff --
What is the reason for adding a new message here (with different ID) vs just adding the change to the existing message?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #588: ARTEMIS-563 update POODLE message
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/588
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #588: ARTEMIS-563 update POODLE message
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/588#discussion_r67690084
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java ---
@@ -309,6 +309,12 @@ void slowConsumerDetected(String sessionID,
@Message(id = 221052, value = "trying to deploy topic {0}", format = Message.Format.MESSAGE_FORMAT)
void deployTopic(SimpleString topicName);
+ @LogMessage(level = Logger.Level.INFO)
--- End diff --
The ID of the message is tied to the "level" of the message per the JavaDoc on the class. Therefore since the level changed the ID changed as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---