You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/12/11 06:48:05 UTC

[GitHub] [maven-site] kwin commented on a diff in pull request #354: [MNGSITE-503] add .well-known/security.txt

kwin commented on code in PR #354:
URL: https://github.com/apache/maven-site/pull/354#discussion_r1045181161


##########
pom.xml:
##########
@@ -232,6 +232,33 @@
 -->
         </executions>
       </plugin>
+      <!--
+        used for timestamp of .well-known/security.txt file
+        Plugin-definition must be before resources-plugin to be
+        in the pre-site phase before 'copy-filtered-resources'.
+      -->
+      <plugin>
+        <groupId>org.codehaus.mojo</groupId>
+        <artifactId>build-helper-maven-plugin</artifactId>
+        <version>3.3.0</version>
+        <executions>
+          <execution>
+            <id>create-security.txt-timestamp</id>
+            <phase>pre-site</phase>
+            <goals>
+              <goal>timestamp-property</goal>
+            </goals>
+            <configuration>
+              <name>maven.security.expires</name>
+              <pattern>yyyy-MM-dd'T'HH:mm:ssXXX</pattern>
+              <!-- This ulgy Plexus magic will be coerced in the plugin to Locale#ROOT -->

Review Comment:
   ```suggestion
                 <!-- This ugly Plexus magic will be coerced in the plugin to Locale#ROOT -->
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org