You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Enrico Olivelli <eo...@gmail.com> on 2020/04/21 15:20:29 UTC
[VOTE] Apache ZooKeeper release 3.6.1 candidate 1
This is a release candidate for 3.6.1.
It is a bugfix release and it introduces a few bugfixes and new features in
these areas:
- compatibility with applications built against 3.5 client libraries
(restored a few non public APIs)
- update Netty to 4.1.48.Final
- ability to pass configuration as file in zkCli for TLS config
- Add setKeepAlive support for NIOServerCnxn
- Fix server side request throttling
The full release notes is available at:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346764
*** Please download, test and vote by April 14th 2020, 23:59 UTC+0. ***
Source files:
https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/
Maven staging repo:
https://repository.apache.org/content/repositories/orgapachezookeeper-1058/
The release candidate tag in git to be voted upon: release-3.6.1-1
https://github.com/apache/zookeeper/tree/release-3.6.1-1
ZooKeeper's KEYS file containing PGP keys we use to sign the release:
https://www.apache.org/dist/zookeeper/KEYS
The staging version of the website is:
https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/website/
Should we release this candidate?
Enrico Olivelli
Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 1
Posted by Matteo Minardi - Diennea <mi...@hotmail.it>.
+1 (non-bindings)
- Compiled on Mac (AdoptOpenJDK build 1.8.0_242-b08).
- Run unit tests (no c client) .
- Run simple commands.
- Spotbugs and Checkstyle passed.
Il giorno 21/04/20, 17:20 "Enrico Olivelli" <eo...@gmail.com> ha scritto:
This is a release candidate for 3.6.1.
It is a bugfix release and it introduces a few bugfixes and new features in
these areas:
- compatibility with applications built against 3.5 client libraries
(restored a few non public APIs)
- update Netty to 4.1.48.Final
- ability to pass configuration as file in zkCli for TLS config
- Add setKeepAlive support for NIOServerCnxn
- Fix server side request throttling
The full release notes is available at:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346764
*** Please download, test and vote by April 14th 2020, 23:59 UTC+0. ***
Source files:
https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/
Maven staging repo:
https://repository.apache.org/content/repositories/orgapachezookeeper-1058/
The release candidate tag in git to be voted upon: release-3.6.1-1
https://github.com/apache/zookeeper/tree/release-3.6.1-1
ZooKeeper's KEYS file containing PGP keys we use to sign the release:
https://www.apache.org/dist/zookeeper/KEYS
The staging version of the website is:
https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/website/
Should we release this candidate?
Enrico Olivelli
Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 1
Posted by Patrick Hunt <ph...@apache.org>.
+1. xsum/sig verified. compiled fine and I was able to run some manual test
successfully. lgtm
Patrick
On Thu, Apr 23, 2020 at 2:16 PM Christopher <ct...@apache.org> wrote:
> +1 (non-binding); overall, looks great!
>
> Good:
> * Source tarball matches tag (git sha1 at
> 104dcb3e3fb464b30c5186d229e00af9f332524b)
> * Release tag includes all commits from branch-3.6 (at
> e64a74fabafeb3b20109014149beb3ebd6a48be7)
> * SHA512 checksums match tarballs:
>
> 1c5cb4d9886fae41bf244a446dd874b73c0fff7a5fc2dda4305041964420cde21e59b388dfd2551464a46bb6918d9d3c3c01ebe68fdbe782074ee360aa830c7d
> apache-zookeeper-3.6.1-bin.tar.gz
>
> 0c6740a14bcc6fac56ffa1d4d18dc5397d454d46ffb42a3f6a784a9d8bf5083b460d6f8a5f65718e83973f65683a420a4614de11710e21cdf288d586d3c5203d
> apache-zookeeper-3.6.1.tar.gz
> * GPG signatures match (signed using key
> BBE7232D7991050B54C8EA0ADC08637CA615D22C, 2048/rsa, with recommended
> SHA512 digest algo) and key is present in KEYS
> * Was able to reproduce creation of the binary tarball (comparison of
> file listing only) using OpenJDK14 (only diffs were expected javadoc
> differences) using `mvn clean package -Pfull-build`
> * I tested the convenience binary with Apache Accumulo 2.0.0 and basic
> functionality is all there
>
> Of minor concern:
> * Seeing lots of warnings in the ZK logs about bad reads from the
> client connection when there hasn't been any other indication of a
> failure anywhere. Possibly a mishandled connection in client code, but
> not sure (certainly not serious enough to block a release, since
> everything seems to be functioning fine otherwise):
> 2020-04-23 17:01:48,414 [myid:] - WARN
> [NIOWorkerThread-3:NIOServerCnxn@364] - Unexpected exception
> EndOfStreamException: Unable to read additional data from client, it
> probably closed the socket: address = /127.0.0.1:35702, session =
> 0x100028c09f1000e
> at
> org.apache.zookeeper.server.NIOServerCnxn.handleFailedRead(NIOServerCnxn.java:163)
> at org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:326)
> at
> org.apache.zookeeper.server.NIOServerCnxnFactory$IOWorkRequest.doWork(NIOServerCnxnFactory.java:522)
> at
> org.apache.zookeeper.server.WorkerService$ScheduledWorkRequest.run(WorkerService.java:154)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
> at java.base/java.lang.Thread.run(Thread.java:832)
>
> On Thu, Apr 23, 2020 at 6:00 AM Norbert Kalmar
> <nk...@cloudera.com.invalid> wrote:
> >
> > Sure, I'll do the update today.
> > +1 (non-binding) from me (see my testing in my previous mail)
> >
> > Thanks Enrico!
> >
> > On Thu, Apr 23, 2020 at 11:20 AM Enrico Olivelli <eo...@gmail.com>
> > wrote:
> >
> > > Il giorno mer 22 apr 2020 alle ore 16:14 Norbert Kalmar
> > > <nk...@cloudera.com.invalid> ha scritto:
> > >
> > > > Only thing I found is that the bin has netty-codec-4.1.49 license
> file
> > > > while the jar included is 4.1.48. I think the license version has a
> typo
> > > in
> > > > the bugfix version. Not sure if it's a showstopper.
> > > >
> > >
> > > I don't consider it a showstopper.
> > >
> > > Do you have time to send a fix please ?
> > > This way if we have to roll out a new RC we can pick it up.
> > >
> > > We could anyhow update to 4.1.49.Final
> > > https://netty.io/news/2020/04/22/4-1-49-Final.html
> > >
> > > Enrico
> > >
> > >
> > > >
> > > > Otherwise LGTM:
> > > > - Signatures OK
> > > > - Compared to git and 3.6.0
> > > > - Compiled both on Mac (without C client) and Linux (with C client)
> > > > - Run tests (from src) and server (from src and bin tarball), connect
> > > with
> > > > client and run simple commands
> > > > - Spotbugs and checkstyle passed
> > > >
> > > > Regards,
> > > > Norbert
> > > >
> > > > On Wed, Apr 22, 2020 at 3:50 PM Szalay-Bekő Máté <
> > > > szalay.beko.mate@gmail.com>
> > > > wrote:
> > > >
> > > > > +1 (non-binding)
> > > > >
> > > > > - I built the source code (-Pfull-build) on Ubuntu 18.04.3 using
> > > OpenJDK
> > > > > 8u242 and maven 3.6.0.
> > > > > - all the unit tests passed (both Java and C-client).
> > > > > - I also built and executed unit tests for zkpython
> > > > > - checkstyle and spotbugs passed
> > > > > - apache-rat passed
> > > > > - fatjar built
> > > > > - I executed a quick rolling-upgrade test from 3.5.7 to 3.6.1.
> (using
> > > > > https://github.com/symat/zk-rolling-upgrade-test)
> > > > >
> > > > > On Tue, Apr 21, 2020 at 5:20 PM Enrico Olivelli <
> eolivelli@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > This is a release candidate for 3.6.1.
> > > > > >
> > > > > > It is a bugfix release and it introduces a few bugfixes and new
> > > > features
> > > > > in
> > > > > > these areas:
> > > > > > - compatibility with applications built against 3.5 client
> libraries
> > > > > > (restored a few non public APIs)
> > > > > > - update Netty to 4.1.48.Final
> > > > > > - ability to pass configuration as file in zkCli for TLS config
> > > > > > - Add setKeepAlive support for NIOServerCnxn
> > > > > > - Fix server side request throttling
> > > > > >
> > > > > > The full release notes is available at:
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346764
> > > > > >
> > > > > > *** Please download, test and vote by April 14th 2020, 23:59
> UTC+0.
> > > ***
> > > > > >
> > > > > > Source files:
> > > > > >
> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/
> > > > > >
> > > > > > Maven staging repo:
> > > > > >
> > > > >
> > > >
> > >
> https://repository.apache.org/content/repositories/orgapachezookeeper-1058/
> > > > > >
> > > > > > The release candidate tag in git to be voted upon:
> release-3.6.1-1
> > > > > > https://github.com/apache/zookeeper/tree/release-3.6.1-1
> > > > > >
> > > > > > ZooKeeper's KEYS file containing PGP keys we use to sign the
> release:
> > > > > > https://www.apache.org/dist/zookeeper/KEYS
> > > > > >
> > > > > > The staging version of the website is:
> > > > > >
> > > > >
> > > >
> > >
> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/website/
> > > > > >
> > > > > > Should we release this candidate?
> > > > > >
> > > > > > Enrico Olivelli
> > > > > >
> > > > >
> > > >
> > >
>
Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 1
Posted by Christopher <ct...@apache.org>.
+1 (non-binding); overall, looks great!
Good:
* Source tarball matches tag (git sha1 at
104dcb3e3fb464b30c5186d229e00af9f332524b)
* Release tag includes all commits from branch-3.6 (at
e64a74fabafeb3b20109014149beb3ebd6a48be7)
* SHA512 checksums match tarballs:
1c5cb4d9886fae41bf244a446dd874b73c0fff7a5fc2dda4305041964420cde21e59b388dfd2551464a46bb6918d9d3c3c01ebe68fdbe782074ee360aa830c7d
apache-zookeeper-3.6.1-bin.tar.gz
0c6740a14bcc6fac56ffa1d4d18dc5397d454d46ffb42a3f6a784a9d8bf5083b460d6f8a5f65718e83973f65683a420a4614de11710e21cdf288d586d3c5203d
apache-zookeeper-3.6.1.tar.gz
* GPG signatures match (signed using key
BBE7232D7991050B54C8EA0ADC08637CA615D22C, 2048/rsa, with recommended
SHA512 digest algo) and key is present in KEYS
* Was able to reproduce creation of the binary tarball (comparison of
file listing only) using OpenJDK14 (only diffs were expected javadoc
differences) using `mvn clean package -Pfull-build`
* I tested the convenience binary with Apache Accumulo 2.0.0 and basic
functionality is all there
Of minor concern:
* Seeing lots of warnings in the ZK logs about bad reads from the
client connection when there hasn't been any other indication of a
failure anywhere. Possibly a mishandled connection in client code, but
not sure (certainly not serious enough to block a release, since
everything seems to be functioning fine otherwise):
2020-04-23 17:01:48,414 [myid:] - WARN
[NIOWorkerThread-3:NIOServerCnxn@364] - Unexpected exception
EndOfStreamException: Unable to read additional data from client, it
probably closed the socket: address = /127.0.0.1:35702, session =
0x100028c09f1000e
at org.apache.zookeeper.server.NIOServerCnxn.handleFailedRead(NIOServerCnxn.java:163)
at org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:326)
at org.apache.zookeeper.server.NIOServerCnxnFactory$IOWorkRequest.doWork(NIOServerCnxnFactory.java:522)
at org.apache.zookeeper.server.WorkerService$ScheduledWorkRequest.run(WorkerService.java:154)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
at java.base/java.lang.Thread.run(Thread.java:832)
On Thu, Apr 23, 2020 at 6:00 AM Norbert Kalmar
<nk...@cloudera.com.invalid> wrote:
>
> Sure, I'll do the update today.
> +1 (non-binding) from me (see my testing in my previous mail)
>
> Thanks Enrico!
>
> On Thu, Apr 23, 2020 at 11:20 AM Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > Il giorno mer 22 apr 2020 alle ore 16:14 Norbert Kalmar
> > <nk...@cloudera.com.invalid> ha scritto:
> >
> > > Only thing I found is that the bin has netty-codec-4.1.49 license file
> > > while the jar included is 4.1.48. I think the license version has a typo
> > in
> > > the bugfix version. Not sure if it's a showstopper.
> > >
> >
> > I don't consider it a showstopper.
> >
> > Do you have time to send a fix please ?
> > This way if we have to roll out a new RC we can pick it up.
> >
> > We could anyhow update to 4.1.49.Final
> > https://netty.io/news/2020/04/22/4-1-49-Final.html
> >
> > Enrico
> >
> >
> > >
> > > Otherwise LGTM:
> > > - Signatures OK
> > > - Compared to git and 3.6.0
> > > - Compiled both on Mac (without C client) and Linux (with C client)
> > > - Run tests (from src) and server (from src and bin tarball), connect
> > with
> > > client and run simple commands
> > > - Spotbugs and checkstyle passed
> > >
> > > Regards,
> > > Norbert
> > >
> > > On Wed, Apr 22, 2020 at 3:50 PM Szalay-Bekő Máté <
> > > szalay.beko.mate@gmail.com>
> > > wrote:
> > >
> > > > +1 (non-binding)
> > > >
> > > > - I built the source code (-Pfull-build) on Ubuntu 18.04.3 using
> > OpenJDK
> > > > 8u242 and maven 3.6.0.
> > > > - all the unit tests passed (both Java and C-client).
> > > > - I also built and executed unit tests for zkpython
> > > > - checkstyle and spotbugs passed
> > > > - apache-rat passed
> > > > - fatjar built
> > > > - I executed a quick rolling-upgrade test from 3.5.7 to 3.6.1. (using
> > > > https://github.com/symat/zk-rolling-upgrade-test)
> > > >
> > > > On Tue, Apr 21, 2020 at 5:20 PM Enrico Olivelli <eo...@gmail.com>
> > > > wrote:
> > > >
> > > > > This is a release candidate for 3.6.1.
> > > > >
> > > > > It is a bugfix release and it introduces a few bugfixes and new
> > > features
> > > > in
> > > > > these areas:
> > > > > - compatibility with applications built against 3.5 client libraries
> > > > > (restored a few non public APIs)
> > > > > - update Netty to 4.1.48.Final
> > > > > - ability to pass configuration as file in zkCli for TLS config
> > > > > - Add setKeepAlive support for NIOServerCnxn
> > > > > - Fix server side request throttling
> > > > >
> > > > > The full release notes is available at:
> > > > >
> > > > >
> > > > >
> > > >
> > >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346764
> > > > >
> > > > > *** Please download, test and vote by April 14th 2020, 23:59 UTC+0.
> > ***
> > > > >
> > > > > Source files:
> > > > > https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/
> > > > >
> > > > > Maven staging repo:
> > > > >
> > > >
> > >
> > https://repository.apache.org/content/repositories/orgapachezookeeper-1058/
> > > > >
> > > > > The release candidate tag in git to be voted upon: release-3.6.1-1
> > > > > https://github.com/apache/zookeeper/tree/release-3.6.1-1
> > > > >
> > > > > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> > > > > https://www.apache.org/dist/zookeeper/KEYS
> > > > >
> > > > > The staging version of the website is:
> > > > >
> > > >
> > >
> > https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/website/
> > > > >
> > > > > Should we release this candidate?
> > > > >
> > > > > Enrico Olivelli
> > > > >
> > > >
> > >
> >
Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 1
Posted by Norbert Kalmar <nk...@cloudera.com.INVALID>.
Sure, I'll do the update today.
+1 (non-binding) from me (see my testing in my previous mail)
Thanks Enrico!
On Thu, Apr 23, 2020 at 11:20 AM Enrico Olivelli <eo...@gmail.com>
wrote:
> Il giorno mer 22 apr 2020 alle ore 16:14 Norbert Kalmar
> <nk...@cloudera.com.invalid> ha scritto:
>
> > Only thing I found is that the bin has netty-codec-4.1.49 license file
> > while the jar included is 4.1.48. I think the license version has a typo
> in
> > the bugfix version. Not sure if it's a showstopper.
> >
>
> I don't consider it a showstopper.
>
> Do you have time to send a fix please ?
> This way if we have to roll out a new RC we can pick it up.
>
> We could anyhow update to 4.1.49.Final
> https://netty.io/news/2020/04/22/4-1-49-Final.html
>
> Enrico
>
>
> >
> > Otherwise LGTM:
> > - Signatures OK
> > - Compared to git and 3.6.0
> > - Compiled both on Mac (without C client) and Linux (with C client)
> > - Run tests (from src) and server (from src and bin tarball), connect
> with
> > client and run simple commands
> > - Spotbugs and checkstyle passed
> >
> > Regards,
> > Norbert
> >
> > On Wed, Apr 22, 2020 at 3:50 PM Szalay-Bekő Máté <
> > szalay.beko.mate@gmail.com>
> > wrote:
> >
> > > +1 (non-binding)
> > >
> > > - I built the source code (-Pfull-build) on Ubuntu 18.04.3 using
> OpenJDK
> > > 8u242 and maven 3.6.0.
> > > - all the unit tests passed (both Java and C-client).
> > > - I also built and executed unit tests for zkpython
> > > - checkstyle and spotbugs passed
> > > - apache-rat passed
> > > - fatjar built
> > > - I executed a quick rolling-upgrade test from 3.5.7 to 3.6.1. (using
> > > https://github.com/symat/zk-rolling-upgrade-test)
> > >
> > > On Tue, Apr 21, 2020 at 5:20 PM Enrico Olivelli <eo...@gmail.com>
> > > wrote:
> > >
> > > > This is a release candidate for 3.6.1.
> > > >
> > > > It is a bugfix release and it introduces a few bugfixes and new
> > features
> > > in
> > > > these areas:
> > > > - compatibility with applications built against 3.5 client libraries
> > > > (restored a few non public APIs)
> > > > - update Netty to 4.1.48.Final
> > > > - ability to pass configuration as file in zkCli for TLS config
> > > > - Add setKeepAlive support for NIOServerCnxn
> > > > - Fix server side request throttling
> > > >
> > > > The full release notes is available at:
> > > >
> > > >
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346764
> > > >
> > > > *** Please download, test and vote by April 14th 2020, 23:59 UTC+0.
> ***
> > > >
> > > > Source files:
> > > > https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/
> > > >
> > > > Maven staging repo:
> > > >
> > >
> >
> https://repository.apache.org/content/repositories/orgapachezookeeper-1058/
> > > >
> > > > The release candidate tag in git to be voted upon: release-3.6.1-1
> > > > https://github.com/apache/zookeeper/tree/release-3.6.1-1
> > > >
> > > > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> > > > https://www.apache.org/dist/zookeeper/KEYS
> > > >
> > > > The staging version of the website is:
> > > >
> > >
> >
> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/website/
> > > >
> > > > Should we release this candidate?
> > > >
> > > > Enrico Olivelli
> > > >
> > >
> >
>
Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 1
Posted by Andor Molnar <an...@apache.org>.
I 100% agree with you that we should not use Thread.sleep() anywhere in our tests. I’ve been actively fighting against it for years, because they caused tons of flaky tests in the past. We’re making quite good progress actually and recent tests are lot less fragile.
Andor
> On 2020. Apr 30., at 12:23, Andor Molnar <an...@apache.org> wrote:
>
> Right. I noticed that part too and have no idea why that sleep-hack-todo has been added originally, but it seems that it doesn’t play part in this game, so I haven’t touched it.
>
> The other waits are not sleeping for X seconds necessarily. The setting just limits the time that they can wait for an event to happen. If it happens earlier, the test goes on similarly to your suggestion.
>
> Patch:
> https://github.com/apache/zookeeper/pull/1345
> Jira:
> https://issues.apache.org/jira/browse/ZOOKEEPER-3813
>
> Thanks,
> Andor
>
>
>
>> On 2020. Apr 30., at 12:15, Christopher <ct...@apache.org> wrote:
>>
>> Looks like I replied at the same time as you. :)
>> Extending the timeout may work... but tests that use Thread.sleep() to
>> wait for an expected condition are fragile. The current code even
>> labels the strategy as "TODO hack".
>> It would be better to loop and re-check for the expected condition,
>> until some overall timeout for the test is reached. Thread.sleep()
>> should only be used to throttle the loop.
>>
>> For example, a test that follows the following pattern is better than
>> one that simply sleeps for 30 seconds and checks the expected
>> condition once:
>>
>> @Test(timeout = 30_000)
>> public void testForCondition() {
>> while (true) {
>> if (expectedCondition) break;
>> Thread.sleep(50);
>> }
>> }
>>
>> On Thu, Apr 30, 2020 at 6:08 AM Andor Molnar <an...@apache.org> wrote:
>>>
>>> Oh, I see now.
>>>
>>> SensitivityWatchEventModifier has been removed by this patch:
>>> https://github.com/apache/zookeeper/pull/1269
>>>
>>> Which will make file change event notification slower and tests to break. On Mac.
>>> Looks like I only need to increase the timeout, because the polling mechanism happens every 10 seconds.
>>>
>>> I’ll put together a patch and continue my testing.
>>>
>>> Andor
>>>
>>>
>>>
>>>
>>>> On 2020. Apr 30., at 11:19, Andor Molnar <an...@apache.org> wrote:
>>>>
>>>> FileChangeWatcherTest keeps failing for me on Mac with the following error:
>>>>
>>>> [ERROR] Tests run: 5, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 29.233 s <<< FAILURE! - in org.apache.zookeeper.common.FileChangeWatcherTest
>>>> [ERROR] testCallbackWorksOnFileChanges(org.apache.zookeeper.common.FileChangeWatcherTest) Time elapsed: 4.068 s <<< FAILURE!
>>>> java.lang.AssertionError: Wrong number of events expected:<1> but was:<0>
>>>> at org.apache.zookeeper.common.FileChangeWatcherTest.testCallbackWorksOnFileChanges(FileChangeWatcherTest.java:92)
>>>>
>>>>
>>>> Andor
>>>>
>>>>
>>>>
>>>>
>>>>> On 2020. Apr 27., at 17:24, Enrico Olivelli <eo...@gmail.com> wrote:
>>>>>
>>>>> +1 (binding)
>>>>>
>>>>> verified checksums, sigs
>>>>> run all tests on Fedora 31 + JDK8
>>>>> checked rat, checkstyle, spotbugs
>>>>> performed basic tests using JDK8 using the staged binaries.
>>>>>
>>>>>
>>>>> Generally I don't like to self-vote, I have prepared the RC so I may be
>>>>> biased.
>>>>>
>>>>> Any other binding +1 would be very appreciated.
>>>>> btw we need another one (we only have me and Patrick as binding voters in
>>>>> this thread)
>>>>>
>>>>> Enrico
>>>>>
>>>>>
>>>>> Il giorno sab 25 apr 2020 alle ore 18:09 Enrico Olivelli <
>>>>> eolivelli@gmail.com> ha scritto:
>>>>>
>>>>>> We still need a couple of binding VOTEs
>>>>>> Please any PMC check this candidate
>>>>>>
>>>>>> Enrico
>>>>>>
>>>>>> Il Ven 24 Apr 2020, 06:31 Patrick Hunt <ph...@apache.org> ha scritto:
>>>>>>
>>>>>>> On Thu, Apr 23, 2020 at 2:20 AM Enrico Olivelli <eo...@gmail.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Il giorno mer 22 apr 2020 alle ore 16:14 Norbert Kalmar
>>>>>>>> <nk...@cloudera.com.invalid> ha scritto:
>>>>>>>>
>>>>>>>>> Only thing I found is that the bin has netty-codec-4.1.49 license file
>>>>>>>>> while the jar included is 4.1.48. I think the license version has a
>>>>>>> typo
>>>>>>>> in
>>>>>>>>> the bugfix version. Not sure if it's a showstopper.
>>>>>>>>>
>>>>>>>>
>>>>>>>> I don't consider it a showstopper.
>>>>>>>>
>>>>>>>> Do you have time to send a fix please ?
>>>>>>>> This way if we have to roll out a new RC we can pick it up.
>>>>>>>>
>>>>>>>
>>>>>>> Sorry - my bad on that one.
>>>>>>>
>>>>>>> I submitted a simple PR to fix it if you want to pull into the other
>>>>>>> branches or have it ready if a respin is necessary:
>>>>>>> https://github.com/apache/zookeeper/pull/1333
>>>>>>>
>>>>>>> Patrick
>>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>> We could anyhow update to 4.1.49.Final
>>>>>>>> https://netty.io/news/2020/04/22/4-1-49-Final.html
>>>>>>>>
>>>>>>>> Enrico
>>>>>>>>
>>>>>>>>
>>>>>>>>>
>>>>>>>>> Otherwise LGTM:
>>>>>>>>> - Signatures OK
>>>>>>>>> - Compared to git and 3.6.0
>>>>>>>>> - Compiled both on Mac (without C client) and Linux (with C client)
>>>>>>>>> - Run tests (from src) and server (from src and bin tarball), connect
>>>>>>>> with
>>>>>>>>> client and run simple commands
>>>>>>>>> - Spotbugs and checkstyle passed
>>>>>>>>>
>>>>>>>>> Regards,
>>>>>>>>> Norbert
>>>>>>>>>
>>>>>>>>> On Wed, Apr 22, 2020 at 3:50 PM Szalay-Bekő Máté <
>>>>>>>>> szalay.beko.mate@gmail.com>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> +1 (non-binding)
>>>>>>>>>>
>>>>>>>>>> - I built the source code (-Pfull-build) on Ubuntu 18.04.3 using
>>>>>>>> OpenJDK
>>>>>>>>>> 8u242 and maven 3.6.0.
>>>>>>>>>> - all the unit tests passed (both Java and C-client).
>>>>>>>>>> - I also built and executed unit tests for zkpython
>>>>>>>>>> - checkstyle and spotbugs passed
>>>>>>>>>> - apache-rat passed
>>>>>>>>>> - fatjar built
>>>>>>>>>> - I executed a quick rolling-upgrade test from 3.5.7 to 3.6.1.
>>>>>>> (using
>>>>>>>>>> https://github.com/symat/zk-rolling-upgrade-test)
>>>>>>>>>>
>>>>>>>>>> On Tue, Apr 21, 2020 at 5:20 PM Enrico Olivelli <
>>>>>>> eolivelli@gmail.com>
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>> This is a release candidate for 3.6.1.
>>>>>>>>>>>
>>>>>>>>>>> It is a bugfix release and it introduces a few bugfixes and new
>>>>>>>>> features
>>>>>>>>>> in
>>>>>>>>>>> these areas:
>>>>>>>>>>> - compatibility with applications built against 3.5 client
>>>>>>> libraries
>>>>>>>>>>> (restored a few non public APIs)
>>>>>>>>>>> - update Netty to 4.1.48.Final
>>>>>>>>>>> - ability to pass configuration as file in zkCli for TLS config
>>>>>>>>>>> - Add setKeepAlive support for NIOServerCnxn
>>>>>>>>>>> - Fix server side request throttling
>>>>>>>>>>>
>>>>>>>>>>> The full release notes is available at:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346764
>>>>>>>>>>>
>>>>>>>>>>> *** Please download, test and vote by April 14th 2020, 23:59
>>>>>>> UTC+0.
>>>>>>>> ***
>>>>>>>>>>>
>>>>>>>>>>> Source files:
>>>>>>>>>>> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/
>>>>>>>>>>>
>>>>>>>>>>> Maven staging repo:
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>> https://repository.apache.org/content/repositories/orgapachezookeeper-1058/
>>>>>>>>>>>
>>>>>>>>>>> The release candidate tag in git to be voted upon: release-3.6.1-1
>>>>>>>>>>> https://github.com/apache/zookeeper/tree/release-3.6.1-1
>>>>>>>>>>>
>>>>>>>>>>> ZooKeeper's KEYS file containing PGP keys we use to sign the
>>>>>>> release:
>>>>>>>>>>> https://www.apache.org/dist/zookeeper/KEYS
>>>>>>>>>>>
>>>>>>>>>>> The staging version of the website is:
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/website/
>>>>>>>>>>>
>>>>>>>>>>> Should we release this candidate?
>>>>>>>>>>>
>>>>>>>>>>> Enrico Olivelli
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>
>>>
>
Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 1
Posted by Andor Molnar <an...@apache.org>.
Right. I noticed that part too and have no idea why that sleep-hack-todo has been added originally, but it seems that it doesn’t play part in this game, so I haven’t touched it.
The other waits are not sleeping for X seconds necessarily. The setting just limits the time that they can wait for an event to happen. If it happens earlier, the test goes on similarly to your suggestion.
Patch:
https://github.com/apache/zookeeper/pull/1345
Jira:
https://issues.apache.org/jira/browse/ZOOKEEPER-3813
Thanks,
Andor
> On 2020. Apr 30., at 12:15, Christopher <ct...@apache.org> wrote:
>
> Looks like I replied at the same time as you. :)
> Extending the timeout may work... but tests that use Thread.sleep() to
> wait for an expected condition are fragile. The current code even
> labels the strategy as "TODO hack".
> It would be better to loop and re-check for the expected condition,
> until some overall timeout for the test is reached. Thread.sleep()
> should only be used to throttle the loop.
>
> For example, a test that follows the following pattern is better than
> one that simply sleeps for 30 seconds and checks the expected
> condition once:
>
> @Test(timeout = 30_000)
> public void testForCondition() {
> while (true) {
> if (expectedCondition) break;
> Thread.sleep(50);
> }
> }
>
> On Thu, Apr 30, 2020 at 6:08 AM Andor Molnar <an...@apache.org> wrote:
>>
>> Oh, I see now.
>>
>> SensitivityWatchEventModifier has been removed by this patch:
>> https://github.com/apache/zookeeper/pull/1269
>>
>> Which will make file change event notification slower and tests to break. On Mac.
>> Looks like I only need to increase the timeout, because the polling mechanism happens every 10 seconds.
>>
>> I’ll put together a patch and continue my testing.
>>
>> Andor
>>
>>
>>
>>
>>> On 2020. Apr 30., at 11:19, Andor Molnar <an...@apache.org> wrote:
>>>
>>> FileChangeWatcherTest keeps failing for me on Mac with the following error:
>>>
>>> [ERROR] Tests run: 5, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 29.233 s <<< FAILURE! - in org.apache.zookeeper.common.FileChangeWatcherTest
>>> [ERROR] testCallbackWorksOnFileChanges(org.apache.zookeeper.common.FileChangeWatcherTest) Time elapsed: 4.068 s <<< FAILURE!
>>> java.lang.AssertionError: Wrong number of events expected:<1> but was:<0>
>>> at org.apache.zookeeper.common.FileChangeWatcherTest.testCallbackWorksOnFileChanges(FileChangeWatcherTest.java:92)
>>>
>>>
>>> Andor
>>>
>>>
>>>
>>>
>>>> On 2020. Apr 27., at 17:24, Enrico Olivelli <eo...@gmail.com> wrote:
>>>>
>>>> +1 (binding)
>>>>
>>>> verified checksums, sigs
>>>> run all tests on Fedora 31 + JDK8
>>>> checked rat, checkstyle, spotbugs
>>>> performed basic tests using JDK8 using the staged binaries.
>>>>
>>>>
>>>> Generally I don't like to self-vote, I have prepared the RC so I may be
>>>> biased.
>>>>
>>>> Any other binding +1 would be very appreciated.
>>>> btw we need another one (we only have me and Patrick as binding voters in
>>>> this thread)
>>>>
>>>> Enrico
>>>>
>>>>
>>>> Il giorno sab 25 apr 2020 alle ore 18:09 Enrico Olivelli <
>>>> eolivelli@gmail.com> ha scritto:
>>>>
>>>>> We still need a couple of binding VOTEs
>>>>> Please any PMC check this candidate
>>>>>
>>>>> Enrico
>>>>>
>>>>> Il Ven 24 Apr 2020, 06:31 Patrick Hunt <ph...@apache.org> ha scritto:
>>>>>
>>>>>> On Thu, Apr 23, 2020 at 2:20 AM Enrico Olivelli <eo...@gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Il giorno mer 22 apr 2020 alle ore 16:14 Norbert Kalmar
>>>>>>> <nk...@cloudera.com.invalid> ha scritto:
>>>>>>>
>>>>>>>> Only thing I found is that the bin has netty-codec-4.1.49 license file
>>>>>>>> while the jar included is 4.1.48. I think the license version has a
>>>>>> typo
>>>>>>> in
>>>>>>>> the bugfix version. Not sure if it's a showstopper.
>>>>>>>>
>>>>>>>
>>>>>>> I don't consider it a showstopper.
>>>>>>>
>>>>>>> Do you have time to send a fix please ?
>>>>>>> This way if we have to roll out a new RC we can pick it up.
>>>>>>>
>>>>>>
>>>>>> Sorry - my bad on that one.
>>>>>>
>>>>>> I submitted a simple PR to fix it if you want to pull into the other
>>>>>> branches or have it ready if a respin is necessary:
>>>>>> https://github.com/apache/zookeeper/pull/1333
>>>>>>
>>>>>> Patrick
>>>>>>
>>>>>>
>>>>>>>
>>>>>>> We could anyhow update to 4.1.49.Final
>>>>>>> https://netty.io/news/2020/04/22/4-1-49-Final.html
>>>>>>>
>>>>>>> Enrico
>>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>> Otherwise LGTM:
>>>>>>>> - Signatures OK
>>>>>>>> - Compared to git and 3.6.0
>>>>>>>> - Compiled both on Mac (without C client) and Linux (with C client)
>>>>>>>> - Run tests (from src) and server (from src and bin tarball), connect
>>>>>>> with
>>>>>>>> client and run simple commands
>>>>>>>> - Spotbugs and checkstyle passed
>>>>>>>>
>>>>>>>> Regards,
>>>>>>>> Norbert
>>>>>>>>
>>>>>>>> On Wed, Apr 22, 2020 at 3:50 PM Szalay-Bekő Máté <
>>>>>>>> szalay.beko.mate@gmail.com>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> +1 (non-binding)
>>>>>>>>>
>>>>>>>>> - I built the source code (-Pfull-build) on Ubuntu 18.04.3 using
>>>>>>> OpenJDK
>>>>>>>>> 8u242 and maven 3.6.0.
>>>>>>>>> - all the unit tests passed (both Java and C-client).
>>>>>>>>> - I also built and executed unit tests for zkpython
>>>>>>>>> - checkstyle and spotbugs passed
>>>>>>>>> - apache-rat passed
>>>>>>>>> - fatjar built
>>>>>>>>> - I executed a quick rolling-upgrade test from 3.5.7 to 3.6.1.
>>>>>> (using
>>>>>>>>> https://github.com/symat/zk-rolling-upgrade-test)
>>>>>>>>>
>>>>>>>>> On Tue, Apr 21, 2020 at 5:20 PM Enrico Olivelli <
>>>>>> eolivelli@gmail.com>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> This is a release candidate for 3.6.1.
>>>>>>>>>>
>>>>>>>>>> It is a bugfix release and it introduces a few bugfixes and new
>>>>>>>> features
>>>>>>>>> in
>>>>>>>>>> these areas:
>>>>>>>>>> - compatibility with applications built against 3.5 client
>>>>>> libraries
>>>>>>>>>> (restored a few non public APIs)
>>>>>>>>>> - update Netty to 4.1.48.Final
>>>>>>>>>> - ability to pass configuration as file in zkCli for TLS config
>>>>>>>>>> - Add setKeepAlive support for NIOServerCnxn
>>>>>>>>>> - Fix server side request throttling
>>>>>>>>>>
>>>>>>>>>> The full release notes is available at:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346764
>>>>>>>>>>
>>>>>>>>>> *** Please download, test and vote by April 14th 2020, 23:59
>>>>>> UTC+0.
>>>>>>> ***
>>>>>>>>>>
>>>>>>>>>> Source files:
>>>>>>>>>> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/
>>>>>>>>>>
>>>>>>>>>> Maven staging repo:
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>> https://repository.apache.org/content/repositories/orgapachezookeeper-1058/
>>>>>>>>>>
>>>>>>>>>> The release candidate tag in git to be voted upon: release-3.6.1-1
>>>>>>>>>> https://github.com/apache/zookeeper/tree/release-3.6.1-1
>>>>>>>>>>
>>>>>>>>>> ZooKeeper's KEYS file containing PGP keys we use to sign the
>>>>>> release:
>>>>>>>>>> https://www.apache.org/dist/zookeeper/KEYS
>>>>>>>>>>
>>>>>>>>>> The staging version of the website is:
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/website/
>>>>>>>>>>
>>>>>>>>>> Should we release this candidate?
>>>>>>>>>>
>>>>>>>>>> Enrico Olivelli
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>
>>
Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 1
Posted by Christopher <ct...@apache.org>.
Looks like I replied at the same time as you. :)
Extending the timeout may work... but tests that use Thread.sleep() to
wait for an expected condition are fragile. The current code even
labels the strategy as "TODO hack".
It would be better to loop and re-check for the expected condition,
until some overall timeout for the test is reached. Thread.sleep()
should only be used to throttle the loop.
For example, a test that follows the following pattern is better than
one that simply sleeps for 30 seconds and checks the expected
condition once:
@Test(timeout = 30_000)
public void testForCondition() {
while (true) {
if (expectedCondition) break;
Thread.sleep(50);
}
}
On Thu, Apr 30, 2020 at 6:08 AM Andor Molnar <an...@apache.org> wrote:
>
> Oh, I see now.
>
> SensitivityWatchEventModifier has been removed by this patch:
> https://github.com/apache/zookeeper/pull/1269
>
> Which will make file change event notification slower and tests to break. On Mac.
> Looks like I only need to increase the timeout, because the polling mechanism happens every 10 seconds.
>
> I’ll put together a patch and continue my testing.
>
> Andor
>
>
>
>
> > On 2020. Apr 30., at 11:19, Andor Molnar <an...@apache.org> wrote:
> >
> > FileChangeWatcherTest keeps failing for me on Mac with the following error:
> >
> > [ERROR] Tests run: 5, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 29.233 s <<< FAILURE! - in org.apache.zookeeper.common.FileChangeWatcherTest
> > [ERROR] testCallbackWorksOnFileChanges(org.apache.zookeeper.common.FileChangeWatcherTest) Time elapsed: 4.068 s <<< FAILURE!
> > java.lang.AssertionError: Wrong number of events expected:<1> but was:<0>
> > at org.apache.zookeeper.common.FileChangeWatcherTest.testCallbackWorksOnFileChanges(FileChangeWatcherTest.java:92)
> >
> >
> > Andor
> >
> >
> >
> >
> >> On 2020. Apr 27., at 17:24, Enrico Olivelli <eo...@gmail.com> wrote:
> >>
> >> +1 (binding)
> >>
> >> verified checksums, sigs
> >> run all tests on Fedora 31 + JDK8
> >> checked rat, checkstyle, spotbugs
> >> performed basic tests using JDK8 using the staged binaries.
> >>
> >>
> >> Generally I don't like to self-vote, I have prepared the RC so I may be
> >> biased.
> >>
> >> Any other binding +1 would be very appreciated.
> >> btw we need another one (we only have me and Patrick as binding voters in
> >> this thread)
> >>
> >> Enrico
> >>
> >>
> >> Il giorno sab 25 apr 2020 alle ore 18:09 Enrico Olivelli <
> >> eolivelli@gmail.com> ha scritto:
> >>
> >>> We still need a couple of binding VOTEs
> >>> Please any PMC check this candidate
> >>>
> >>> Enrico
> >>>
> >>> Il Ven 24 Apr 2020, 06:31 Patrick Hunt <ph...@apache.org> ha scritto:
> >>>
> >>>> On Thu, Apr 23, 2020 at 2:20 AM Enrico Olivelli <eo...@gmail.com>
> >>>> wrote:
> >>>>
> >>>>> Il giorno mer 22 apr 2020 alle ore 16:14 Norbert Kalmar
> >>>>> <nk...@cloudera.com.invalid> ha scritto:
> >>>>>
> >>>>>> Only thing I found is that the bin has netty-codec-4.1.49 license file
> >>>>>> while the jar included is 4.1.48. I think the license version has a
> >>>> typo
> >>>>> in
> >>>>>> the bugfix version. Not sure if it's a showstopper.
> >>>>>>
> >>>>>
> >>>>> I don't consider it a showstopper.
> >>>>>
> >>>>> Do you have time to send a fix please ?
> >>>>> This way if we have to roll out a new RC we can pick it up.
> >>>>>
> >>>>
> >>>> Sorry - my bad on that one.
> >>>>
> >>>> I submitted a simple PR to fix it if you want to pull into the other
> >>>> branches or have it ready if a respin is necessary:
> >>>> https://github.com/apache/zookeeper/pull/1333
> >>>>
> >>>> Patrick
> >>>>
> >>>>
> >>>>>
> >>>>> We could anyhow update to 4.1.49.Final
> >>>>> https://netty.io/news/2020/04/22/4-1-49-Final.html
> >>>>>
> >>>>> Enrico
> >>>>>
> >>>>>
> >>>>>>
> >>>>>> Otherwise LGTM:
> >>>>>> - Signatures OK
> >>>>>> - Compared to git and 3.6.0
> >>>>>> - Compiled both on Mac (without C client) and Linux (with C client)
> >>>>>> - Run tests (from src) and server (from src and bin tarball), connect
> >>>>> with
> >>>>>> client and run simple commands
> >>>>>> - Spotbugs and checkstyle passed
> >>>>>>
> >>>>>> Regards,
> >>>>>> Norbert
> >>>>>>
> >>>>>> On Wed, Apr 22, 2020 at 3:50 PM Szalay-Bekő Máté <
> >>>>>> szalay.beko.mate@gmail.com>
> >>>>>> wrote:
> >>>>>>
> >>>>>>> +1 (non-binding)
> >>>>>>>
> >>>>>>> - I built the source code (-Pfull-build) on Ubuntu 18.04.3 using
> >>>>> OpenJDK
> >>>>>>> 8u242 and maven 3.6.0.
> >>>>>>> - all the unit tests passed (both Java and C-client).
> >>>>>>> - I also built and executed unit tests for zkpython
> >>>>>>> - checkstyle and spotbugs passed
> >>>>>>> - apache-rat passed
> >>>>>>> - fatjar built
> >>>>>>> - I executed a quick rolling-upgrade test from 3.5.7 to 3.6.1.
> >>>> (using
> >>>>>>> https://github.com/symat/zk-rolling-upgrade-test)
> >>>>>>>
> >>>>>>> On Tue, Apr 21, 2020 at 5:20 PM Enrico Olivelli <
> >>>> eolivelli@gmail.com>
> >>>>>>> wrote:
> >>>>>>>
> >>>>>>>> This is a release candidate for 3.6.1.
> >>>>>>>>
> >>>>>>>> It is a bugfix release and it introduces a few bugfixes and new
> >>>>>> features
> >>>>>>> in
> >>>>>>>> these areas:
> >>>>>>>> - compatibility with applications built against 3.5 client
> >>>> libraries
> >>>>>>>> (restored a few non public APIs)
> >>>>>>>> - update Netty to 4.1.48.Final
> >>>>>>>> - ability to pass configuration as file in zkCli for TLS config
> >>>>>>>> - Add setKeepAlive support for NIOServerCnxn
> >>>>>>>> - Fix server side request throttling
> >>>>>>>>
> >>>>>>>> The full release notes is available at:
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>
> >>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346764
> >>>>>>>>
> >>>>>>>> *** Please download, test and vote by April 14th 2020, 23:59
> >>>> UTC+0.
> >>>>> ***
> >>>>>>>>
> >>>>>>>> Source files:
> >>>>>>>> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/
> >>>>>>>>
> >>>>>>>> Maven staging repo:
> >>>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>
> >>>> https://repository.apache.org/content/repositories/orgapachezookeeper-1058/
> >>>>>>>>
> >>>>>>>> The release candidate tag in git to be voted upon: release-3.6.1-1
> >>>>>>>> https://github.com/apache/zookeeper/tree/release-3.6.1-1
> >>>>>>>>
> >>>>>>>> ZooKeeper's KEYS file containing PGP keys we use to sign the
> >>>> release:
> >>>>>>>> https://www.apache.org/dist/zookeeper/KEYS
> >>>>>>>>
> >>>>>>>> The staging version of the website is:
> >>>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>
> >>>> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/website/
> >>>>>>>>
> >>>>>>>> Should we release this candidate?
> >>>>>>>>
> >>>>>>>> Enrico Olivelli
> >>>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>
> >>>>
> >>>
> >
>
Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 1
Posted by Andor Molnar <an...@apache.org>.
Oh, I see now.
SensitivityWatchEventModifier has been removed by this patch:
https://github.com/apache/zookeeper/pull/1269
Which will make file change event notification slower and tests to break. On Mac.
Looks like I only need to increase the timeout, because the polling mechanism happens every 10 seconds.
I’ll put together a patch and continue my testing.
Andor
> On 2020. Apr 30., at 11:19, Andor Molnar <an...@apache.org> wrote:
>
> FileChangeWatcherTest keeps failing for me on Mac with the following error:
>
> [ERROR] Tests run: 5, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 29.233 s <<< FAILURE! - in org.apache.zookeeper.common.FileChangeWatcherTest
> [ERROR] testCallbackWorksOnFileChanges(org.apache.zookeeper.common.FileChangeWatcherTest) Time elapsed: 4.068 s <<< FAILURE!
> java.lang.AssertionError: Wrong number of events expected:<1> but was:<0>
> at org.apache.zookeeper.common.FileChangeWatcherTest.testCallbackWorksOnFileChanges(FileChangeWatcherTest.java:92)
>
>
> Andor
>
>
>
>
>> On 2020. Apr 27., at 17:24, Enrico Olivelli <eo...@gmail.com> wrote:
>>
>> +1 (binding)
>>
>> verified checksums, sigs
>> run all tests on Fedora 31 + JDK8
>> checked rat, checkstyle, spotbugs
>> performed basic tests using JDK8 using the staged binaries.
>>
>>
>> Generally I don't like to self-vote, I have prepared the RC so I may be
>> biased.
>>
>> Any other binding +1 would be very appreciated.
>> btw we need another one (we only have me and Patrick as binding voters in
>> this thread)
>>
>> Enrico
>>
>>
>> Il giorno sab 25 apr 2020 alle ore 18:09 Enrico Olivelli <
>> eolivelli@gmail.com> ha scritto:
>>
>>> We still need a couple of binding VOTEs
>>> Please any PMC check this candidate
>>>
>>> Enrico
>>>
>>> Il Ven 24 Apr 2020, 06:31 Patrick Hunt <ph...@apache.org> ha scritto:
>>>
>>>> On Thu, Apr 23, 2020 at 2:20 AM Enrico Olivelli <eo...@gmail.com>
>>>> wrote:
>>>>
>>>>> Il giorno mer 22 apr 2020 alle ore 16:14 Norbert Kalmar
>>>>> <nk...@cloudera.com.invalid> ha scritto:
>>>>>
>>>>>> Only thing I found is that the bin has netty-codec-4.1.49 license file
>>>>>> while the jar included is 4.1.48. I think the license version has a
>>>> typo
>>>>> in
>>>>>> the bugfix version. Not sure if it's a showstopper.
>>>>>>
>>>>>
>>>>> I don't consider it a showstopper.
>>>>>
>>>>> Do you have time to send a fix please ?
>>>>> This way if we have to roll out a new RC we can pick it up.
>>>>>
>>>>
>>>> Sorry - my bad on that one.
>>>>
>>>> I submitted a simple PR to fix it if you want to pull into the other
>>>> branches or have it ready if a respin is necessary:
>>>> https://github.com/apache/zookeeper/pull/1333
>>>>
>>>> Patrick
>>>>
>>>>
>>>>>
>>>>> We could anyhow update to 4.1.49.Final
>>>>> https://netty.io/news/2020/04/22/4-1-49-Final.html
>>>>>
>>>>> Enrico
>>>>>
>>>>>
>>>>>>
>>>>>> Otherwise LGTM:
>>>>>> - Signatures OK
>>>>>> - Compared to git and 3.6.0
>>>>>> - Compiled both on Mac (without C client) and Linux (with C client)
>>>>>> - Run tests (from src) and server (from src and bin tarball), connect
>>>>> with
>>>>>> client and run simple commands
>>>>>> - Spotbugs and checkstyle passed
>>>>>>
>>>>>> Regards,
>>>>>> Norbert
>>>>>>
>>>>>> On Wed, Apr 22, 2020 at 3:50 PM Szalay-Bekő Máté <
>>>>>> szalay.beko.mate@gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>>> +1 (non-binding)
>>>>>>>
>>>>>>> - I built the source code (-Pfull-build) on Ubuntu 18.04.3 using
>>>>> OpenJDK
>>>>>>> 8u242 and maven 3.6.0.
>>>>>>> - all the unit tests passed (both Java and C-client).
>>>>>>> - I also built and executed unit tests for zkpython
>>>>>>> - checkstyle and spotbugs passed
>>>>>>> - apache-rat passed
>>>>>>> - fatjar built
>>>>>>> - I executed a quick rolling-upgrade test from 3.5.7 to 3.6.1.
>>>> (using
>>>>>>> https://github.com/symat/zk-rolling-upgrade-test)
>>>>>>>
>>>>>>> On Tue, Apr 21, 2020 at 5:20 PM Enrico Olivelli <
>>>> eolivelli@gmail.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> This is a release candidate for 3.6.1.
>>>>>>>>
>>>>>>>> It is a bugfix release and it introduces a few bugfixes and new
>>>>>> features
>>>>>>> in
>>>>>>>> these areas:
>>>>>>>> - compatibility with applications built against 3.5 client
>>>> libraries
>>>>>>>> (restored a few non public APIs)
>>>>>>>> - update Netty to 4.1.48.Final
>>>>>>>> - ability to pass configuration as file in zkCli for TLS config
>>>>>>>> - Add setKeepAlive support for NIOServerCnxn
>>>>>>>> - Fix server side request throttling
>>>>>>>>
>>>>>>>> The full release notes is available at:
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346764
>>>>>>>>
>>>>>>>> *** Please download, test and vote by April 14th 2020, 23:59
>>>> UTC+0.
>>>>> ***
>>>>>>>>
>>>>>>>> Source files:
>>>>>>>> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/
>>>>>>>>
>>>>>>>> Maven staging repo:
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>> https://repository.apache.org/content/repositories/orgapachezookeeper-1058/
>>>>>>>>
>>>>>>>> The release candidate tag in git to be voted upon: release-3.6.1-1
>>>>>>>> https://github.com/apache/zookeeper/tree/release-3.6.1-1
>>>>>>>>
>>>>>>>> ZooKeeper's KEYS file containing PGP keys we use to sign the
>>>> release:
>>>>>>>> https://www.apache.org/dist/zookeeper/KEYS
>>>>>>>>
>>>>>>>> The staging version of the website is:
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/website/
>>>>>>>>
>>>>>>>> Should we release this candidate?
>>>>>>>>
>>>>>>>> Enrico Olivelli
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>
Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 1
Posted by Christopher <ct...@apache.org>.
The FileChangeWatcherTest failure is almost certainly caused by the
removal of the use of com.sun.nio.file.SensitivityWatchEventModifier.
This was done as part of
https://issues.apache.org/jira/browse/ZOOKEEPER-3215 /
https://issues.apache.org/jira/browse/ZOOKEEPER-3739 and fixes the
cross-compilation issues with ByteBuffer and other cross-compilation
issues when building using JDKs newer than 8.
The use of the SensitivityWatchEventModifier as a hack to detect
changes more rapidly on Mac file systems is well-known, but
problematic. See the discussion on the PR for ZOOKEEPER-3739, where I
elaborate on the details.
There are two possible fixes I would suggest:
1. Use a junit Assume.assumeThat() to check
System.getProperty("os.name") for a Mac operating system, and skip the
test, or
2. Improve the test by retrying to check for changes, until changes
are observed, rather than waiting a fixed amount of time and passing
or failing based on whether changes were observed.
On Thu, Apr 30, 2020 at 5:19 AM Andor Molnar <an...@apache.org> wrote:
>
> FileChangeWatcherTest keeps failing for me on Mac with the following error:
>
> [ERROR] Tests run: 5, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 29.233 s <<< FAILURE! - in org.apache.zookeeper.common.FileChangeWatcherTest
> [ERROR] testCallbackWorksOnFileChanges(org.apache.zookeeper.common.FileChangeWatcherTest) Time elapsed: 4.068 s <<< FAILURE!
> java.lang.AssertionError: Wrong number of events expected:<1> but was:<0>
> at org.apache.zookeeper.common.FileChangeWatcherTest.testCallbackWorksOnFileChanges(FileChangeWatcherTest.java:92)
>
>
> Andor
>
>
>
>
> > On 2020. Apr 27., at 17:24, Enrico Olivelli <eo...@gmail.com> wrote:
> >
> > +1 (binding)
> >
> > verified checksums, sigs
> > run all tests on Fedora 31 + JDK8
> > checked rat, checkstyle, spotbugs
> > performed basic tests using JDK8 using the staged binaries.
> >
> >
> > Generally I don't like to self-vote, I have prepared the RC so I may be
> > biased.
> >
> > Any other binding +1 would be very appreciated.
> > btw we need another one (we only have me and Patrick as binding voters in
> > this thread)
> >
> > Enrico
> >
> >
> > Il giorno sab 25 apr 2020 alle ore 18:09 Enrico Olivelli <
> > eolivelli@gmail.com> ha scritto:
> >
> >> We still need a couple of binding VOTEs
> >> Please any PMC check this candidate
> >>
> >> Enrico
> >>
> >> Il Ven 24 Apr 2020, 06:31 Patrick Hunt <ph...@apache.org> ha scritto:
> >>
> >>> On Thu, Apr 23, 2020 at 2:20 AM Enrico Olivelli <eo...@gmail.com>
> >>> wrote:
> >>>
> >>>> Il giorno mer 22 apr 2020 alle ore 16:14 Norbert Kalmar
> >>>> <nk...@cloudera.com.invalid> ha scritto:
> >>>>
> >>>>> Only thing I found is that the bin has netty-codec-4.1.49 license file
> >>>>> while the jar included is 4.1.48. I think the license version has a
> >>> typo
> >>>> in
> >>>>> the bugfix version. Not sure if it's a showstopper.
> >>>>>
> >>>>
> >>>> I don't consider it a showstopper.
> >>>>
> >>>> Do you have time to send a fix please ?
> >>>> This way if we have to roll out a new RC we can pick it up.
> >>>>
> >>>
> >>> Sorry - my bad on that one.
> >>>
> >>> I submitted a simple PR to fix it if you want to pull into the other
> >>> branches or have it ready if a respin is necessary:
> >>> https://github.com/apache/zookeeper/pull/1333
> >>>
> >>> Patrick
> >>>
> >>>
> >>>>
> >>>> We could anyhow update to 4.1.49.Final
> >>>> https://netty.io/news/2020/04/22/4-1-49-Final.html
> >>>>
> >>>> Enrico
> >>>>
> >>>>
> >>>>>
> >>>>> Otherwise LGTM:
> >>>>> - Signatures OK
> >>>>> - Compared to git and 3.6.0
> >>>>> - Compiled both on Mac (without C client) and Linux (with C client)
> >>>>> - Run tests (from src) and server (from src and bin tarball), connect
> >>>> with
> >>>>> client and run simple commands
> >>>>> - Spotbugs and checkstyle passed
> >>>>>
> >>>>> Regards,
> >>>>> Norbert
> >>>>>
> >>>>> On Wed, Apr 22, 2020 at 3:50 PM Szalay-Bekő Máté <
> >>>>> szalay.beko.mate@gmail.com>
> >>>>> wrote:
> >>>>>
> >>>>>> +1 (non-binding)
> >>>>>>
> >>>>>> - I built the source code (-Pfull-build) on Ubuntu 18.04.3 using
> >>>> OpenJDK
> >>>>>> 8u242 and maven 3.6.0.
> >>>>>> - all the unit tests passed (both Java and C-client).
> >>>>>> - I also built and executed unit tests for zkpython
> >>>>>> - checkstyle and spotbugs passed
> >>>>>> - apache-rat passed
> >>>>>> - fatjar built
> >>>>>> - I executed a quick rolling-upgrade test from 3.5.7 to 3.6.1.
> >>> (using
> >>>>>> https://github.com/symat/zk-rolling-upgrade-test)
> >>>>>>
> >>>>>> On Tue, Apr 21, 2020 at 5:20 PM Enrico Olivelli <
> >>> eolivelli@gmail.com>
> >>>>>> wrote:
> >>>>>>
> >>>>>>> This is a release candidate for 3.6.1.
> >>>>>>>
> >>>>>>> It is a bugfix release and it introduces a few bugfixes and new
> >>>>> features
> >>>>>> in
> >>>>>>> these areas:
> >>>>>>> - compatibility with applications built against 3.5 client
> >>> libraries
> >>>>>>> (restored a few non public APIs)
> >>>>>>> - update Netty to 4.1.48.Final
> >>>>>>> - ability to pass configuration as file in zkCli for TLS config
> >>>>>>> - Add setKeepAlive support for NIOServerCnxn
> >>>>>>> - Fix server side request throttling
> >>>>>>>
> >>>>>>> The full release notes is available at:
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>
> >>>>
> >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346764
> >>>>>>>
> >>>>>>> *** Please download, test and vote by April 14th 2020, 23:59
> >>> UTC+0.
> >>>> ***
> >>>>>>>
> >>>>>>> Source files:
> >>>>>>> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/
> >>>>>>>
> >>>>>>> Maven staging repo:
> >>>>>>>
> >>>>>>
> >>>>>
> >>>>
> >>> https://repository.apache.org/content/repositories/orgapachezookeeper-1058/
> >>>>>>>
> >>>>>>> The release candidate tag in git to be voted upon: release-3.6.1-1
> >>>>>>> https://github.com/apache/zookeeper/tree/release-3.6.1-1
> >>>>>>>
> >>>>>>> ZooKeeper's KEYS file containing PGP keys we use to sign the
> >>> release:
> >>>>>>> https://www.apache.org/dist/zookeeper/KEYS
> >>>>>>>
> >>>>>>> The staging version of the website is:
> >>>>>>>
> >>>>>>
> >>>>>
> >>>>
> >>> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/website/
> >>>>>>>
> >>>>>>> Should we release this candidate?
> >>>>>>>
> >>>>>>> Enrico Olivelli
> >>>>>>>
> >>>>>>
> >>>>>
> >>>>
> >>>
> >>
>
Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 1
Posted by Andor Molnar <an...@apache.org>.
FileChangeWatcherTest keeps failing for me on Mac with the following error:
[ERROR] Tests run: 5, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 29.233 s <<< FAILURE! - in org.apache.zookeeper.common.FileChangeWatcherTest
[ERROR] testCallbackWorksOnFileChanges(org.apache.zookeeper.common.FileChangeWatcherTest) Time elapsed: 4.068 s <<< FAILURE!
java.lang.AssertionError: Wrong number of events expected:<1> but was:<0>
at org.apache.zookeeper.common.FileChangeWatcherTest.testCallbackWorksOnFileChanges(FileChangeWatcherTest.java:92)
Andor
> On 2020. Apr 27., at 17:24, Enrico Olivelli <eo...@gmail.com> wrote:
>
> +1 (binding)
>
> verified checksums, sigs
> run all tests on Fedora 31 + JDK8
> checked rat, checkstyle, spotbugs
> performed basic tests using JDK8 using the staged binaries.
>
>
> Generally I don't like to self-vote, I have prepared the RC so I may be
> biased.
>
> Any other binding +1 would be very appreciated.
> btw we need another one (we only have me and Patrick as binding voters in
> this thread)
>
> Enrico
>
>
> Il giorno sab 25 apr 2020 alle ore 18:09 Enrico Olivelli <
> eolivelli@gmail.com> ha scritto:
>
>> We still need a couple of binding VOTEs
>> Please any PMC check this candidate
>>
>> Enrico
>>
>> Il Ven 24 Apr 2020, 06:31 Patrick Hunt <ph...@apache.org> ha scritto:
>>
>>> On Thu, Apr 23, 2020 at 2:20 AM Enrico Olivelli <eo...@gmail.com>
>>> wrote:
>>>
>>>> Il giorno mer 22 apr 2020 alle ore 16:14 Norbert Kalmar
>>>> <nk...@cloudera.com.invalid> ha scritto:
>>>>
>>>>> Only thing I found is that the bin has netty-codec-4.1.49 license file
>>>>> while the jar included is 4.1.48. I think the license version has a
>>> typo
>>>> in
>>>>> the bugfix version. Not sure if it's a showstopper.
>>>>>
>>>>
>>>> I don't consider it a showstopper.
>>>>
>>>> Do you have time to send a fix please ?
>>>> This way if we have to roll out a new RC we can pick it up.
>>>>
>>>
>>> Sorry - my bad on that one.
>>>
>>> I submitted a simple PR to fix it if you want to pull into the other
>>> branches or have it ready if a respin is necessary:
>>> https://github.com/apache/zookeeper/pull/1333
>>>
>>> Patrick
>>>
>>>
>>>>
>>>> We could anyhow update to 4.1.49.Final
>>>> https://netty.io/news/2020/04/22/4-1-49-Final.html
>>>>
>>>> Enrico
>>>>
>>>>
>>>>>
>>>>> Otherwise LGTM:
>>>>> - Signatures OK
>>>>> - Compared to git and 3.6.0
>>>>> - Compiled both on Mac (without C client) and Linux (with C client)
>>>>> - Run tests (from src) and server (from src and bin tarball), connect
>>>> with
>>>>> client and run simple commands
>>>>> - Spotbugs and checkstyle passed
>>>>>
>>>>> Regards,
>>>>> Norbert
>>>>>
>>>>> On Wed, Apr 22, 2020 at 3:50 PM Szalay-Bekő Máté <
>>>>> szalay.beko.mate@gmail.com>
>>>>> wrote:
>>>>>
>>>>>> +1 (non-binding)
>>>>>>
>>>>>> - I built the source code (-Pfull-build) on Ubuntu 18.04.3 using
>>>> OpenJDK
>>>>>> 8u242 and maven 3.6.0.
>>>>>> - all the unit tests passed (both Java and C-client).
>>>>>> - I also built and executed unit tests for zkpython
>>>>>> - checkstyle and spotbugs passed
>>>>>> - apache-rat passed
>>>>>> - fatjar built
>>>>>> - I executed a quick rolling-upgrade test from 3.5.7 to 3.6.1.
>>> (using
>>>>>> https://github.com/symat/zk-rolling-upgrade-test)
>>>>>>
>>>>>> On Tue, Apr 21, 2020 at 5:20 PM Enrico Olivelli <
>>> eolivelli@gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>>> This is a release candidate for 3.6.1.
>>>>>>>
>>>>>>> It is a bugfix release and it introduces a few bugfixes and new
>>>>> features
>>>>>> in
>>>>>>> these areas:
>>>>>>> - compatibility with applications built against 3.5 client
>>> libraries
>>>>>>> (restored a few non public APIs)
>>>>>>> - update Netty to 4.1.48.Final
>>>>>>> - ability to pass configuration as file in zkCli for TLS config
>>>>>>> - Add setKeepAlive support for NIOServerCnxn
>>>>>>> - Fix server side request throttling
>>>>>>>
>>>>>>> The full release notes is available at:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346764
>>>>>>>
>>>>>>> *** Please download, test and vote by April 14th 2020, 23:59
>>> UTC+0.
>>>> ***
>>>>>>>
>>>>>>> Source files:
>>>>>>> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/
>>>>>>>
>>>>>>> Maven staging repo:
>>>>>>>
>>>>>>
>>>>>
>>>>
>>> https://repository.apache.org/content/repositories/orgapachezookeeper-1058/
>>>>>>>
>>>>>>> The release candidate tag in git to be voted upon: release-3.6.1-1
>>>>>>> https://github.com/apache/zookeeper/tree/release-3.6.1-1
>>>>>>>
>>>>>>> ZooKeeper's KEYS file containing PGP keys we use to sign the
>>> release:
>>>>>>> https://www.apache.org/dist/zookeeper/KEYS
>>>>>>>
>>>>>>> The staging version of the website is:
>>>>>>>
>>>>>>
>>>>>
>>>>
>>> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/website/
>>>>>>>
>>>>>>> Should we release this candidate?
>>>>>>>
>>>>>>> Enrico Olivelli
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
Voting best practices (Was: [VOTE] Apache ZooKeeper release 3.6.1
candidate 1)
Posted by Christopher <ct...@apache.org>.
On Mon, Apr 27, 2020 at 11:24 AM Enrico Olivelli <eo...@gmail.com> wrote:
>
> +1 (binding)
>
> verified checksums, sigs
> run all tests on Fedora 31 + JDK8
> checked rat, checkstyle, spotbugs
> performed basic tests using JDK8 using the staged binaries.
>
>
> Generally I don't like to self-vote, I have prepared the RC so I may be
> biased.
As a release manager, your +1 (or at least, +0) is implied by the fact
that you haven't chosen to withdraw a release, though I recommend your
vote explicit before you close the vote.
Everybody's vote is biased, but the release manager is just as likely
to find a problem with the release as anybody else, so I think they
should always check the release for themselves and vote.
>
> Any other binding +1 would be very appreciated.
> btw we need another one (we only have me and Patrick as binding voters in
> this thread)
Based on recent releases, it seems to me that there are relatively few
active PMC members who routinely provide binding votes on releases,
but many more active committers who provide non-binding votes. Since I
haven't been actively following ZK's mailing lists very long, I'm not
sure how common it is to have so few binding votes for a release.
However, one way this could be solved is by voting in more PMC members
from the pool of committers. In general, a long-standing ASF principle
is to keep the barrier to willing participants low (though individual
PMCs have discretion over how low).
In my personal opinion and from what little I've seen so far,
ZooKeeper already has a sufficiently high quality pool of trustworthy
committers, and code is gated through a pretty strict code review
process, so there wouldn't be any harm to the project by just voting
to promote all committers to PMC member (pending the mandatory 72-hour
NOTICE/lazy approval to the ASF board). Many of the committers appear
to be actively voting on releases already, but as non-binding, since
only PMC votes count for releases.
The only practical difference between PMC member and committer is
voting rights and access to the private mailing list. Personally, I
don't find these to be very compelling reasons to keep committers out
of the PMC (often, it's better to have more voices in voting, and it's
better to include committers on private discussions affecting code).
This is why other projects I am active in, such as Apache Accumulo and
Apache Fluo, operate under a "PMC == committer" paradigm. I don't know
how well the ZooKeeper community would work this way, but I suspect it
wouldn't be much different than how it works today, but you'd
certainly have more binding votes available to make release decisions.
That's just my $0.02 opinion anyway. Even if the ZK PMC doesn't invite
all committers.... inviting a few of the active ones (especially those
with good records of participating in release candidate
testing/voting) to the PMC would definitely help releases go more
smoothly and to prevent problems of too few binding voters in future.
>
> Enrico
>
>
> Il giorno sab 25 apr 2020 alle ore 18:09 Enrico Olivelli <
> eolivelli@gmail.com> ha scritto:
>
> > We still need a couple of binding VOTEs
> > Please any PMC check this candidate
> >
> > Enrico
> >
> > Il Ven 24 Apr 2020, 06:31 Patrick Hunt <ph...@apache.org> ha scritto:
> >
> >> On Thu, Apr 23, 2020 at 2:20 AM Enrico Olivelli <eo...@gmail.com>
> >> wrote:
> >>
> >> > Il giorno mer 22 apr 2020 alle ore 16:14 Norbert Kalmar
> >> > <nk...@cloudera.com.invalid> ha scritto:
> >> >
> >> > > Only thing I found is that the bin has netty-codec-4.1.49 license file
> >> > > while the jar included is 4.1.48. I think the license version has a
> >> typo
> >> > in
> >> > > the bugfix version. Not sure if it's a showstopper.
> >> > >
> >> >
> >> > I don't consider it a showstopper.
> >> >
> >> > Do you have time to send a fix please ?
> >> > This way if we have to roll out a new RC we can pick it up.
> >> >
> >>
> >> Sorry - my bad on that one.
> >>
> >> I submitted a simple PR to fix it if you want to pull into the other
> >> branches or have it ready if a respin is necessary:
> >> https://github.com/apache/zookeeper/pull/1333
> >>
> >> Patrick
> >>
> >>
> >> >
> >> > We could anyhow update to 4.1.49.Final
> >> > https://netty.io/news/2020/04/22/4-1-49-Final.html
> >> >
> >> > Enrico
> >> >
> >> >
> >> > >
> >> > > Otherwise LGTM:
> >> > > - Signatures OK
> >> > > - Compared to git and 3.6.0
> >> > > - Compiled both on Mac (without C client) and Linux (with C client)
> >> > > - Run tests (from src) and server (from src and bin tarball), connect
> >> > with
> >> > > client and run simple commands
> >> > > - Spotbugs and checkstyle passed
> >> > >
> >> > > Regards,
> >> > > Norbert
> >> > >
> >> > > On Wed, Apr 22, 2020 at 3:50 PM Szalay-Bekő Máté <
> >> > > szalay.beko.mate@gmail.com>
> >> > > wrote:
> >> > >
> >> > > > +1 (non-binding)
> >> > > >
> >> > > > - I built the source code (-Pfull-build) on Ubuntu 18.04.3 using
> >> > OpenJDK
> >> > > > 8u242 and maven 3.6.0.
> >> > > > - all the unit tests passed (both Java and C-client).
> >> > > > - I also built and executed unit tests for zkpython
> >> > > > - checkstyle and spotbugs passed
> >> > > > - apache-rat passed
> >> > > > - fatjar built
> >> > > > - I executed a quick rolling-upgrade test from 3.5.7 to 3.6.1.
> >> (using
> >> > > > https://github.com/symat/zk-rolling-upgrade-test)
> >> > > >
> >> > > > On Tue, Apr 21, 2020 at 5:20 PM Enrico Olivelli <
> >> eolivelli@gmail.com>
> >> > > > wrote:
> >> > > >
> >> > > > > This is a release candidate for 3.6.1.
> >> > > > >
> >> > > > > It is a bugfix release and it introduces a few bugfixes and new
> >> > > features
> >> > > > in
> >> > > > > these areas:
> >> > > > > - compatibility with applications built against 3.5 client
> >> libraries
> >> > > > > (restored a few non public APIs)
> >> > > > > - update Netty to 4.1.48.Final
> >> > > > > - ability to pass configuration as file in zkCli for TLS config
> >> > > > > - Add setKeepAlive support for NIOServerCnxn
> >> > > > > - Fix server side request throttling
> >> > > > >
> >> > > > > The full release notes is available at:
> >> > > > >
> >> > > > >
> >> > > > >
> >> > > >
> >> > >
> >> >
> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346764
> >> > > > >
> >> > > > > *** Please download, test and vote by April 14th 2020, 23:59
> >> UTC+0.
> >> > ***
> >> > > > >
> >> > > > > Source files:
> >> > > > > https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/
> >> > > > >
> >> > > > > Maven staging repo:
> >> > > > >
> >> > > >
> >> > >
> >> >
> >> https://repository.apache.org/content/repositories/orgapachezookeeper-1058/
> >> > > > >
> >> > > > > The release candidate tag in git to be voted upon: release-3.6.1-1
> >> > > > > https://github.com/apache/zookeeper/tree/release-3.6.1-1
> >> > > > >
> >> > > > > ZooKeeper's KEYS file containing PGP keys we use to sign the
> >> release:
> >> > > > > https://www.apache.org/dist/zookeeper/KEYS
> >> > > > >
> >> > > > > The staging version of the website is:
> >> > > > >
> >> > > >
> >> > >
> >> >
> >> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/website/
> >> > > > >
> >> > > > > Should we release this candidate?
> >> > > > >
> >> > > > > Enrico Olivelli
> >> > > > >
> >> > > >
> >> > >
> >> >
> >>
> >
Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 1
Posted by Enrico Olivelli <eo...@gmail.com>.
+1 (binding)
verified checksums, sigs
run all tests on Fedora 31 + JDK8
checked rat, checkstyle, spotbugs
performed basic tests using JDK8 using the staged binaries.
Generally I don't like to self-vote, I have prepared the RC so I may be
biased.
Any other binding +1 would be very appreciated.
btw we need another one (we only have me and Patrick as binding voters in
this thread)
Enrico
Il giorno sab 25 apr 2020 alle ore 18:09 Enrico Olivelli <
eolivelli@gmail.com> ha scritto:
> We still need a couple of binding VOTEs
> Please any PMC check this candidate
>
> Enrico
>
> Il Ven 24 Apr 2020, 06:31 Patrick Hunt <ph...@apache.org> ha scritto:
>
>> On Thu, Apr 23, 2020 at 2:20 AM Enrico Olivelli <eo...@gmail.com>
>> wrote:
>>
>> > Il giorno mer 22 apr 2020 alle ore 16:14 Norbert Kalmar
>> > <nk...@cloudera.com.invalid> ha scritto:
>> >
>> > > Only thing I found is that the bin has netty-codec-4.1.49 license file
>> > > while the jar included is 4.1.48. I think the license version has a
>> typo
>> > in
>> > > the bugfix version. Not sure if it's a showstopper.
>> > >
>> >
>> > I don't consider it a showstopper.
>> >
>> > Do you have time to send a fix please ?
>> > This way if we have to roll out a new RC we can pick it up.
>> >
>>
>> Sorry - my bad on that one.
>>
>> I submitted a simple PR to fix it if you want to pull into the other
>> branches or have it ready if a respin is necessary:
>> https://github.com/apache/zookeeper/pull/1333
>>
>> Patrick
>>
>>
>> >
>> > We could anyhow update to 4.1.49.Final
>> > https://netty.io/news/2020/04/22/4-1-49-Final.html
>> >
>> > Enrico
>> >
>> >
>> > >
>> > > Otherwise LGTM:
>> > > - Signatures OK
>> > > - Compared to git and 3.6.0
>> > > - Compiled both on Mac (without C client) and Linux (with C client)
>> > > - Run tests (from src) and server (from src and bin tarball), connect
>> > with
>> > > client and run simple commands
>> > > - Spotbugs and checkstyle passed
>> > >
>> > > Regards,
>> > > Norbert
>> > >
>> > > On Wed, Apr 22, 2020 at 3:50 PM Szalay-Bekő Máté <
>> > > szalay.beko.mate@gmail.com>
>> > > wrote:
>> > >
>> > > > +1 (non-binding)
>> > > >
>> > > > - I built the source code (-Pfull-build) on Ubuntu 18.04.3 using
>> > OpenJDK
>> > > > 8u242 and maven 3.6.0.
>> > > > - all the unit tests passed (both Java and C-client).
>> > > > - I also built and executed unit tests for zkpython
>> > > > - checkstyle and spotbugs passed
>> > > > - apache-rat passed
>> > > > - fatjar built
>> > > > - I executed a quick rolling-upgrade test from 3.5.7 to 3.6.1.
>> (using
>> > > > https://github.com/symat/zk-rolling-upgrade-test)
>> > > >
>> > > > On Tue, Apr 21, 2020 at 5:20 PM Enrico Olivelli <
>> eolivelli@gmail.com>
>> > > > wrote:
>> > > >
>> > > > > This is a release candidate for 3.6.1.
>> > > > >
>> > > > > It is a bugfix release and it introduces a few bugfixes and new
>> > > features
>> > > > in
>> > > > > these areas:
>> > > > > - compatibility with applications built against 3.5 client
>> libraries
>> > > > > (restored a few non public APIs)
>> > > > > - update Netty to 4.1.48.Final
>> > > > > - ability to pass configuration as file in zkCli for TLS config
>> > > > > - Add setKeepAlive support for NIOServerCnxn
>> > > > > - Fix server side request throttling
>> > > > >
>> > > > > The full release notes is available at:
>> > > > >
>> > > > >
>> > > > >
>> > > >
>> > >
>> >
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346764
>> > > > >
>> > > > > *** Please download, test and vote by April 14th 2020, 23:59
>> UTC+0.
>> > ***
>> > > > >
>> > > > > Source files:
>> > > > > https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/
>> > > > >
>> > > > > Maven staging repo:
>> > > > >
>> > > >
>> > >
>> >
>> https://repository.apache.org/content/repositories/orgapachezookeeper-1058/
>> > > > >
>> > > > > The release candidate tag in git to be voted upon: release-3.6.1-1
>> > > > > https://github.com/apache/zookeeper/tree/release-3.6.1-1
>> > > > >
>> > > > > ZooKeeper's KEYS file containing PGP keys we use to sign the
>> release:
>> > > > > https://www.apache.org/dist/zookeeper/KEYS
>> > > > >
>> > > > > The staging version of the website is:
>> > > > >
>> > > >
>> > >
>> >
>> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/website/
>> > > > >
>> > > > > Should we release this candidate?
>> > > > >
>> > > > > Enrico Olivelli
>> > > > >
>> > > >
>> > >
>> >
>>
>
Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 1
Posted by Enrico Olivelli <eo...@gmail.com>.
We still need a couple of binding VOTEs
Please any PMC check this candidate
Enrico
Il Ven 24 Apr 2020, 06:31 Patrick Hunt <ph...@apache.org> ha scritto:
> On Thu, Apr 23, 2020 at 2:20 AM Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > Il giorno mer 22 apr 2020 alle ore 16:14 Norbert Kalmar
> > <nk...@cloudera.com.invalid> ha scritto:
> >
> > > Only thing I found is that the bin has netty-codec-4.1.49 license file
> > > while the jar included is 4.1.48. I think the license version has a
> typo
> > in
> > > the bugfix version. Not sure if it's a showstopper.
> > >
> >
> > I don't consider it a showstopper.
> >
> > Do you have time to send a fix please ?
> > This way if we have to roll out a new RC we can pick it up.
> >
>
> Sorry - my bad on that one.
>
> I submitted a simple PR to fix it if you want to pull into the other
> branches or have it ready if a respin is necessary:
> https://github.com/apache/zookeeper/pull/1333
>
> Patrick
>
>
> >
> > We could anyhow update to 4.1.49.Final
> > https://netty.io/news/2020/04/22/4-1-49-Final.html
> >
> > Enrico
> >
> >
> > >
> > > Otherwise LGTM:
> > > - Signatures OK
> > > - Compared to git and 3.6.0
> > > - Compiled both on Mac (without C client) and Linux (with C client)
> > > - Run tests (from src) and server (from src and bin tarball), connect
> > with
> > > client and run simple commands
> > > - Spotbugs and checkstyle passed
> > >
> > > Regards,
> > > Norbert
> > >
> > > On Wed, Apr 22, 2020 at 3:50 PM Szalay-Bekő Máté <
> > > szalay.beko.mate@gmail.com>
> > > wrote:
> > >
> > > > +1 (non-binding)
> > > >
> > > > - I built the source code (-Pfull-build) on Ubuntu 18.04.3 using
> > OpenJDK
> > > > 8u242 and maven 3.6.0.
> > > > - all the unit tests passed (both Java and C-client).
> > > > - I also built and executed unit tests for zkpython
> > > > - checkstyle and spotbugs passed
> > > > - apache-rat passed
> > > > - fatjar built
> > > > - I executed a quick rolling-upgrade test from 3.5.7 to 3.6.1. (using
> > > > https://github.com/symat/zk-rolling-upgrade-test)
> > > >
> > > > On Tue, Apr 21, 2020 at 5:20 PM Enrico Olivelli <eolivelli@gmail.com
> >
> > > > wrote:
> > > >
> > > > > This is a release candidate for 3.6.1.
> > > > >
> > > > > It is a bugfix release and it introduces a few bugfixes and new
> > > features
> > > > in
> > > > > these areas:
> > > > > - compatibility with applications built against 3.5 client
> libraries
> > > > > (restored a few non public APIs)
> > > > > - update Netty to 4.1.48.Final
> > > > > - ability to pass configuration as file in zkCli for TLS config
> > > > > - Add setKeepAlive support for NIOServerCnxn
> > > > > - Fix server side request throttling
> > > > >
> > > > > The full release notes is available at:
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346764
> > > > >
> > > > > *** Please download, test and vote by April 14th 2020, 23:59 UTC+0.
> > ***
> > > > >
> > > > > Source files:
> > > > > https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/
> > > > >
> > > > > Maven staging repo:
> > > > >
> > > >
> > >
> >
> https://repository.apache.org/content/repositories/orgapachezookeeper-1058/
> > > > >
> > > > > The release candidate tag in git to be voted upon: release-3.6.1-1
> > > > > https://github.com/apache/zookeeper/tree/release-3.6.1-1
> > > > >
> > > > > ZooKeeper's KEYS file containing PGP keys we use to sign the
> release:
> > > > > https://www.apache.org/dist/zookeeper/KEYS
> > > > >
> > > > > The staging version of the website is:
> > > > >
> > > >
> > >
> >
> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/website/
> > > > >
> > > > > Should we release this candidate?
> > > > >
> > > > > Enrico Olivelli
> > > > >
> > > >
> > >
> >
>
Re: [RESULT] [VOTE] Apache ZooKeeper release 3.6.1 candidate 1
Posted by Andor Molnar <an...@apache.org>.
Great work Enrico! Thanks a lot!
I hope everybody is satisfied with the pace of ZooKeeper releases without drop in the quality. :)
Regards,
Andor
> On 2020. Apr 30., at 17:05, Enrico Olivelli <eo...@gmail.com> wrote:
>
> I'm happy to announce that we have unanimously approved this release.
>
> There are 7 approving votes, 3 of which are binding:
>
> - Enrico Olivelli (binding)
> - Andor Molnar (binding)
> - Patrick Hunt (binding)
> - Szalay-Bekő Máté
> - Norbert Kalmar
> - Matteo Minardi
> - Christopher Tubbs
>
> There are no disapproving votes.
>
> I will promote the artifacts and complete the release procedure.
>
> Thanks to every one who contributed to this great release !
>
> Enrico Olivelli
>
> Il giorno gio 30 apr 2020 alle ore 13:26 Andor Molnar <an...@apache.org> ha
> scritto:
>
>> +1
>>
>> - verified release notes
>> - verified signatures, checksums
>> - run unit tests on Mac and Ubuntu (C tests also passed)
>> - verified 3-node quorum with and without SSL on both Java 8 and 11
>> - run smoke and latency tests
>>
>> Andor
>>
>>
>>
>> On Thu, 2020-04-23 at 21:31 -0700, Patrick Hunt wrote:
>>> On Thu, Apr 23, 2020 at 2:20 AM Enrico Olivelli <eo...@gmail.com>
>>> wrote:
>>>
>>>> Il giorno mer 22 apr 2020 alle ore 16:14 Norbert Kalmar
>>>> <nk...@cloudera.com.invalid> ha scritto:
>>>>
>>>>> Only thing I found is that the bin has netty-codec-4.1.49 license
>>>>> file
>>>>> while the jar included is 4.1.48. I think the license version has
>>>>> a typo
>>>> in
>>>>> the bugfix version. Not sure if it's a showstopper.
>>>>>
>>>>
>>>> I don't consider it a showstopper.
>>>>
>>>> Do you have time to send a fix please ?
>>>> This way if we have to roll out a new RC we can pick it up.
>>>>
>>>
>>> Sorry - my bad on that one.
>>>
>>> I submitted a simple PR to fix it if you want to pull into the other
>>> branches or have it ready if a respin is necessary:
>>> https://github.com/apache/zookeeper/pull/1333
>>>
>>> Patrick
>>>
>>>
>>>> We could anyhow update to 4.1.49.Final
>>>> https://netty.io/news/2020/04/22/4-1-49-Final.html
>>>>
>>>> Enrico
>>>>
>>>>
>>>>> Otherwise LGTM:
>>>>> - Signatures OK
>>>>> - Compared to git and 3.6.0
>>>>> - Compiled both on Mac (without C client) and Linux (with C
>>>>> client)
>>>>> - Run tests (from src) and server (from src and bin tarball),
>>>>> connect
>>>> with
>>>>> client and run simple commands
>>>>> - Spotbugs and checkstyle passed
>>>>>
>>>>> Regards,
>>>>> Norbert
>>>>>
>>>>> On Wed, Apr 22, 2020 at 3:50 PM Szalay-Bekő Máté <
>>>>> szalay.beko.mate@gmail.com>
>>>>> wrote:
>>>>>
>>>>>> +1 (non-binding)
>>>>>>
>>>>>> - I built the source code (-Pfull-build) on Ubuntu 18.04.3
>>>>>> using
>>>> OpenJDK
>>>>>> 8u242 and maven 3.6.0.
>>>>>> - all the unit tests passed (both Java and C-client).
>>>>>> - I also built and executed unit tests for zkpython
>>>>>> - checkstyle and spotbugs passed
>>>>>> - apache-rat passed
>>>>>> - fatjar built
>>>>>> - I executed a quick rolling-upgrade test from 3.5.7 to 3.6.1.
>>>>>> (using
>>>>>> https://github.com/symat/zk-rolling-upgrade-test)
>>>>>>
>>>>>> On Tue, Apr 21, 2020 at 5:20 PM Enrico Olivelli <
>>>>>> eolivelli@gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>>> This is a release candidate for 3.6.1.
>>>>>>>
>>>>>>> It is a bugfix release and it introduces a few bugfixes and
>>>>>>> new
>>>>> features
>>>>>> in
>>>>>>> these areas:
>>>>>>> - compatibility with applications built against 3.5 client
>>>>>>> libraries
>>>>>>> (restored a few non public APIs)
>>>>>>> - update Netty to 4.1.48.Final
>>>>>>> - ability to pass configuration as file in zkCli for TLS
>>>>>>> config
>>>>>>> - Add setKeepAlive support for NIOServerCnxn
>>>>>>> - Fix server side request throttling
>>>>>>>
>>>>>>> The full release notes is available at:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346764
>>>>>>> *** Please download, test and vote by April 14th 2020, 23:59
>>>>>>> UTC+0.
>>>> ***
>>>>>>> Source files:
>>>>>>>
>> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/
>>>>>>>
>>>>>>> Maven staging repo:
>>>>>>>
>>>>
>> https://repository.apache.org/content/repositories/orgapachezookeeper-1058/
>>>>>>> The release candidate tag in git to be voted upon: release-
>>>>>>> 3.6.1-1
>>>>>>> https://github.com/apache/zookeeper/tree/release-3.6.1-1
>>>>>>>
>>>>>>> ZooKeeper's KEYS file containing PGP keys we use to sign the
>>>>>>> release:
>>>>>>> https://www.apache.org/dist/zookeeper/KEYS
>>>>>>>
>>>>>>> The staging version of the website is:
>>>>>>>
>>>>
>> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/website/
>>>>>>> Should we release this candidate?
>>>>>>>
>>>>>>> Enrico Olivelli
>>>>>>>
>>
>>
[RESULT] [VOTE] Apache ZooKeeper release 3.6.1 candidate 1
Posted by Enrico Olivelli <eo...@gmail.com>.
I'm happy to announce that we have unanimously approved this release.
There are 7 approving votes, 3 of which are binding:
- Enrico Olivelli (binding)
- Andor Molnar (binding)
- Patrick Hunt (binding)
- Szalay-Bekő Máté
- Norbert Kalmar
- Matteo Minardi
- Christopher Tubbs
There are no disapproving votes.
I will promote the artifacts and complete the release procedure.
Thanks to every one who contributed to this great release !
Enrico Olivelli
Il giorno gio 30 apr 2020 alle ore 13:26 Andor Molnar <an...@apache.org> ha
scritto:
> +1
>
> - verified release notes
> - verified signatures, checksums
> - run unit tests on Mac and Ubuntu (C tests also passed)
> - verified 3-node quorum with and without SSL on both Java 8 and 11
> - run smoke and latency tests
>
> Andor
>
>
>
> On Thu, 2020-04-23 at 21:31 -0700, Patrick Hunt wrote:
> > On Thu, Apr 23, 2020 at 2:20 AM Enrico Olivelli <eo...@gmail.com>
> > wrote:
> >
> > > Il giorno mer 22 apr 2020 alle ore 16:14 Norbert Kalmar
> > > <nk...@cloudera.com.invalid> ha scritto:
> > >
> > > > Only thing I found is that the bin has netty-codec-4.1.49 license
> > > > file
> > > > while the jar included is 4.1.48. I think the license version has
> > > > a typo
> > > in
> > > > the bugfix version. Not sure if it's a showstopper.
> > > >
> > >
> > > I don't consider it a showstopper.
> > >
> > > Do you have time to send a fix please ?
> > > This way if we have to roll out a new RC we can pick it up.
> > >
> >
> > Sorry - my bad on that one.
> >
> > I submitted a simple PR to fix it if you want to pull into the other
> > branches or have it ready if a respin is necessary:
> > https://github.com/apache/zookeeper/pull/1333
> >
> > Patrick
> >
> >
> > > We could anyhow update to 4.1.49.Final
> > > https://netty.io/news/2020/04/22/4-1-49-Final.html
> > >
> > > Enrico
> > >
> > >
> > > > Otherwise LGTM:
> > > > - Signatures OK
> > > > - Compared to git and 3.6.0
> > > > - Compiled both on Mac (without C client) and Linux (with C
> > > > client)
> > > > - Run tests (from src) and server (from src and bin tarball),
> > > > connect
> > > with
> > > > client and run simple commands
> > > > - Spotbugs and checkstyle passed
> > > >
> > > > Regards,
> > > > Norbert
> > > >
> > > > On Wed, Apr 22, 2020 at 3:50 PM Szalay-Bekő Máté <
> > > > szalay.beko.mate@gmail.com>
> > > > wrote:
> > > >
> > > > > +1 (non-binding)
> > > > >
> > > > > - I built the source code (-Pfull-build) on Ubuntu 18.04.3
> > > > > using
> > > OpenJDK
> > > > > 8u242 and maven 3.6.0.
> > > > > - all the unit tests passed (both Java and C-client).
> > > > > - I also built and executed unit tests for zkpython
> > > > > - checkstyle and spotbugs passed
> > > > > - apache-rat passed
> > > > > - fatjar built
> > > > > - I executed a quick rolling-upgrade test from 3.5.7 to 3.6.1.
> > > > > (using
> > > > > https://github.com/symat/zk-rolling-upgrade-test)
> > > > >
> > > > > On Tue, Apr 21, 2020 at 5:20 PM Enrico Olivelli <
> > > > > eolivelli@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > This is a release candidate for 3.6.1.
> > > > > >
> > > > > > It is a bugfix release and it introduces a few bugfixes and
> > > > > > new
> > > > features
> > > > > in
> > > > > > these areas:
> > > > > > - compatibility with applications built against 3.5 client
> > > > > > libraries
> > > > > > (restored a few non public APIs)
> > > > > > - update Netty to 4.1.48.Final
> > > > > > - ability to pass configuration as file in zkCli for TLS
> > > > > > config
> > > > > > - Add setKeepAlive support for NIOServerCnxn
> > > > > > - Fix server side request throttling
> > > > > >
> > > > > > The full release notes is available at:
> > > > > >
> > > > > >
> > > > > >
> > >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346764
> > > > > > *** Please download, test and vote by April 14th 2020, 23:59
> > > > > > UTC+0.
> > > ***
> > > > > > Source files:
> > > > > >
> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/
> > > > > >
> > > > > > Maven staging repo:
> > > > > >
> > >
> https://repository.apache.org/content/repositories/orgapachezookeeper-1058/
> > > > > > The release candidate tag in git to be voted upon: release-
> > > > > > 3.6.1-1
> > > > > > https://github.com/apache/zookeeper/tree/release-3.6.1-1
> > > > > >
> > > > > > ZooKeeper's KEYS file containing PGP keys we use to sign the
> > > > > > release:
> > > > > > https://www.apache.org/dist/zookeeper/KEYS
> > > > > >
> > > > > > The staging version of the website is:
> > > > > >
> > >
> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/website/
> > > > > > Should we release this candidate?
> > > > > >
> > > > > > Enrico Olivelli
> > > > > >
>
>
Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 1
Posted by Andor Molnar <an...@apache.org>.
+1
- verified release notes
- verified signatures, checksums
- run unit tests on Mac and Ubuntu (C tests also passed)
- verified 3-node quorum with and without SSL on both Java 8 and 11
- run smoke and latency tests
Andor
On Thu, 2020-04-23 at 21:31 -0700, Patrick Hunt wrote:
> On Thu, Apr 23, 2020 at 2:20 AM Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > Il giorno mer 22 apr 2020 alle ore 16:14 Norbert Kalmar
> > <nk...@cloudera.com.invalid> ha scritto:
> >
> > > Only thing I found is that the bin has netty-codec-4.1.49 license
> > > file
> > > while the jar included is 4.1.48. I think the license version has
> > > a typo
> > in
> > > the bugfix version. Not sure if it's a showstopper.
> > >
> >
> > I don't consider it a showstopper.
> >
> > Do you have time to send a fix please ?
> > This way if we have to roll out a new RC we can pick it up.
> >
>
> Sorry - my bad on that one.
>
> I submitted a simple PR to fix it if you want to pull into the other
> branches or have it ready if a respin is necessary:
> https://github.com/apache/zookeeper/pull/1333
>
> Patrick
>
>
> > We could anyhow update to 4.1.49.Final
> > https://netty.io/news/2020/04/22/4-1-49-Final.html
> >
> > Enrico
> >
> >
> > > Otherwise LGTM:
> > > - Signatures OK
> > > - Compared to git and 3.6.0
> > > - Compiled both on Mac (without C client) and Linux (with C
> > > client)
> > > - Run tests (from src) and server (from src and bin tarball),
> > > connect
> > with
> > > client and run simple commands
> > > - Spotbugs and checkstyle passed
> > >
> > > Regards,
> > > Norbert
> > >
> > > On Wed, Apr 22, 2020 at 3:50 PM Szalay-Bekő Máté <
> > > szalay.beko.mate@gmail.com>
> > > wrote:
> > >
> > > > +1 (non-binding)
> > > >
> > > > - I built the source code (-Pfull-build) on Ubuntu 18.04.3
> > > > using
> > OpenJDK
> > > > 8u242 and maven 3.6.0.
> > > > - all the unit tests passed (both Java and C-client).
> > > > - I also built and executed unit tests for zkpython
> > > > - checkstyle and spotbugs passed
> > > > - apache-rat passed
> > > > - fatjar built
> > > > - I executed a quick rolling-upgrade test from 3.5.7 to 3.6.1.
> > > > (using
> > > > https://github.com/symat/zk-rolling-upgrade-test)
> > > >
> > > > On Tue, Apr 21, 2020 at 5:20 PM Enrico Olivelli <
> > > > eolivelli@gmail.com>
> > > > wrote:
> > > >
> > > > > This is a release candidate for 3.6.1.
> > > > >
> > > > > It is a bugfix release and it introduces a few bugfixes and
> > > > > new
> > > features
> > > > in
> > > > > these areas:
> > > > > - compatibility with applications built against 3.5 client
> > > > > libraries
> > > > > (restored a few non public APIs)
> > > > > - update Netty to 4.1.48.Final
> > > > > - ability to pass configuration as file in zkCli for TLS
> > > > > config
> > > > > - Add setKeepAlive support for NIOServerCnxn
> > > > > - Fix server side request throttling
> > > > >
> > > > > The full release notes is available at:
> > > > >
> > > > >
> > > > >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346764
> > > > > *** Please download, test and vote by April 14th 2020, 23:59
> > > > > UTC+0.
> > ***
> > > > > Source files:
> > > > > https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/
> > > > >
> > > > > Maven staging repo:
> > > > >
> > https://repository.apache.org/content/repositories/orgapachezookeeper-1058/
> > > > > The release candidate tag in git to be voted upon: release-
> > > > > 3.6.1-1
> > > > > https://github.com/apache/zookeeper/tree/release-3.6.1-1
> > > > >
> > > > > ZooKeeper's KEYS file containing PGP keys we use to sign the
> > > > > release:
> > > > > https://www.apache.org/dist/zookeeper/KEYS
> > > > >
> > > > > The staging version of the website is:
> > > > >
> > https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/website/
> > > > > Should we release this candidate?
> > > > >
> > > > > Enrico Olivelli
> > > > >
Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 1
Posted by Patrick Hunt <ph...@apache.org>.
On Thu, Apr 23, 2020 at 2:20 AM Enrico Olivelli <eo...@gmail.com> wrote:
> Il giorno mer 22 apr 2020 alle ore 16:14 Norbert Kalmar
> <nk...@cloudera.com.invalid> ha scritto:
>
> > Only thing I found is that the bin has netty-codec-4.1.49 license file
> > while the jar included is 4.1.48. I think the license version has a typo
> in
> > the bugfix version. Not sure if it's a showstopper.
> >
>
> I don't consider it a showstopper.
>
> Do you have time to send a fix please ?
> This way if we have to roll out a new RC we can pick it up.
>
Sorry - my bad on that one.
I submitted a simple PR to fix it if you want to pull into the other
branches or have it ready if a respin is necessary:
https://github.com/apache/zookeeper/pull/1333
Patrick
>
> We could anyhow update to 4.1.49.Final
> https://netty.io/news/2020/04/22/4-1-49-Final.html
>
> Enrico
>
>
> >
> > Otherwise LGTM:
> > - Signatures OK
> > - Compared to git and 3.6.0
> > - Compiled both on Mac (without C client) and Linux (with C client)
> > - Run tests (from src) and server (from src and bin tarball), connect
> with
> > client and run simple commands
> > - Spotbugs and checkstyle passed
> >
> > Regards,
> > Norbert
> >
> > On Wed, Apr 22, 2020 at 3:50 PM Szalay-Bekő Máté <
> > szalay.beko.mate@gmail.com>
> > wrote:
> >
> > > +1 (non-binding)
> > >
> > > - I built the source code (-Pfull-build) on Ubuntu 18.04.3 using
> OpenJDK
> > > 8u242 and maven 3.6.0.
> > > - all the unit tests passed (both Java and C-client).
> > > - I also built and executed unit tests for zkpython
> > > - checkstyle and spotbugs passed
> > > - apache-rat passed
> > > - fatjar built
> > > - I executed a quick rolling-upgrade test from 3.5.7 to 3.6.1. (using
> > > https://github.com/symat/zk-rolling-upgrade-test)
> > >
> > > On Tue, Apr 21, 2020 at 5:20 PM Enrico Olivelli <eo...@gmail.com>
> > > wrote:
> > >
> > > > This is a release candidate for 3.6.1.
> > > >
> > > > It is a bugfix release and it introduces a few bugfixes and new
> > features
> > > in
> > > > these areas:
> > > > - compatibility with applications built against 3.5 client libraries
> > > > (restored a few non public APIs)
> > > > - update Netty to 4.1.48.Final
> > > > - ability to pass configuration as file in zkCli for TLS config
> > > > - Add setKeepAlive support for NIOServerCnxn
> > > > - Fix server side request throttling
> > > >
> > > > The full release notes is available at:
> > > >
> > > >
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346764
> > > >
> > > > *** Please download, test and vote by April 14th 2020, 23:59 UTC+0.
> ***
> > > >
> > > > Source files:
> > > > https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/
> > > >
> > > > Maven staging repo:
> > > >
> > >
> >
> https://repository.apache.org/content/repositories/orgapachezookeeper-1058/
> > > >
> > > > The release candidate tag in git to be voted upon: release-3.6.1-1
> > > > https://github.com/apache/zookeeper/tree/release-3.6.1-1
> > > >
> > > > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> > > > https://www.apache.org/dist/zookeeper/KEYS
> > > >
> > > > The staging version of the website is:
> > > >
> > >
> >
> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/website/
> > > >
> > > > Should we release this candidate?
> > > >
> > > > Enrico Olivelli
> > > >
> > >
> >
>
Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 1
Posted by Enrico Olivelli <eo...@gmail.com>.
Il giorno mer 22 apr 2020 alle ore 16:14 Norbert Kalmar
<nk...@cloudera.com.invalid> ha scritto:
> Only thing I found is that the bin has netty-codec-4.1.49 license file
> while the jar included is 4.1.48. I think the license version has a typo in
> the bugfix version. Not sure if it's a showstopper.
>
I don't consider it a showstopper.
Do you have time to send a fix please ?
This way if we have to roll out a new RC we can pick it up.
We could anyhow update to 4.1.49.Final
https://netty.io/news/2020/04/22/4-1-49-Final.html
Enrico
>
> Otherwise LGTM:
> - Signatures OK
> - Compared to git and 3.6.0
> - Compiled both on Mac (without C client) and Linux (with C client)
> - Run tests (from src) and server (from src and bin tarball), connect with
> client and run simple commands
> - Spotbugs and checkstyle passed
>
> Regards,
> Norbert
>
> On Wed, Apr 22, 2020 at 3:50 PM Szalay-Bekő Máté <
> szalay.beko.mate@gmail.com>
> wrote:
>
> > +1 (non-binding)
> >
> > - I built the source code (-Pfull-build) on Ubuntu 18.04.3 using OpenJDK
> > 8u242 and maven 3.6.0.
> > - all the unit tests passed (both Java and C-client).
> > - I also built and executed unit tests for zkpython
> > - checkstyle and spotbugs passed
> > - apache-rat passed
> > - fatjar built
> > - I executed a quick rolling-upgrade test from 3.5.7 to 3.6.1. (using
> > https://github.com/symat/zk-rolling-upgrade-test)
> >
> > On Tue, Apr 21, 2020 at 5:20 PM Enrico Olivelli <eo...@gmail.com>
> > wrote:
> >
> > > This is a release candidate for 3.6.1.
> > >
> > > It is a bugfix release and it introduces a few bugfixes and new
> features
> > in
> > > these areas:
> > > - compatibility with applications built against 3.5 client libraries
> > > (restored a few non public APIs)
> > > - update Netty to 4.1.48.Final
> > > - ability to pass configuration as file in zkCli for TLS config
> > > - Add setKeepAlive support for NIOServerCnxn
> > > - Fix server side request throttling
> > >
> > > The full release notes is available at:
> > >
> > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346764
> > >
> > > *** Please download, test and vote by April 14th 2020, 23:59 UTC+0. ***
> > >
> > > Source files:
> > > https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/
> > >
> > > Maven staging repo:
> > >
> >
> https://repository.apache.org/content/repositories/orgapachezookeeper-1058/
> > >
> > > The release candidate tag in git to be voted upon: release-3.6.1-1
> > > https://github.com/apache/zookeeper/tree/release-3.6.1-1
> > >
> > > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> > > https://www.apache.org/dist/zookeeper/KEYS
> > >
> > > The staging version of the website is:
> > >
> >
> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/website/
> > >
> > > Should we release this candidate?
> > >
> > > Enrico Olivelli
> > >
> >
>
Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 1
Posted by Norbert Kalmar <nk...@cloudera.com.INVALID>.
Only thing I found is that the bin has netty-codec-4.1.49 license file
while the jar included is 4.1.48. I think the license version has a typo in
the bugfix version. Not sure if it's a showstopper.
Otherwise LGTM:
- Signatures OK
- Compared to git and 3.6.0
- Compiled both on Mac (without C client) and Linux (with C client)
- Run tests (from src) and server (from src and bin tarball), connect with
client and run simple commands
- Spotbugs and checkstyle passed
Regards,
Norbert
On Wed, Apr 22, 2020 at 3:50 PM Szalay-Bekő Máté <sz...@gmail.com>
wrote:
> +1 (non-binding)
>
> - I built the source code (-Pfull-build) on Ubuntu 18.04.3 using OpenJDK
> 8u242 and maven 3.6.0.
> - all the unit tests passed (both Java and C-client).
> - I also built and executed unit tests for zkpython
> - checkstyle and spotbugs passed
> - apache-rat passed
> - fatjar built
> - I executed a quick rolling-upgrade test from 3.5.7 to 3.6.1. (using
> https://github.com/symat/zk-rolling-upgrade-test)
>
> On Tue, Apr 21, 2020 at 5:20 PM Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > This is a release candidate for 3.6.1.
> >
> > It is a bugfix release and it introduces a few bugfixes and new features
> in
> > these areas:
> > - compatibility with applications built against 3.5 client libraries
> > (restored a few non public APIs)
> > - update Netty to 4.1.48.Final
> > - ability to pass configuration as file in zkCli for TLS config
> > - Add setKeepAlive support for NIOServerCnxn
> > - Fix server side request throttling
> >
> > The full release notes is available at:
> >
> >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346764
> >
> > *** Please download, test and vote by April 14th 2020, 23:59 UTC+0. ***
> >
> > Source files:
> > https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/
> >
> > Maven staging repo:
> >
> https://repository.apache.org/content/repositories/orgapachezookeeper-1058/
> >
> > The release candidate tag in git to be voted upon: release-3.6.1-1
> > https://github.com/apache/zookeeper/tree/release-3.6.1-1
> >
> > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> > https://www.apache.org/dist/zookeeper/KEYS
> >
> > The staging version of the website is:
> >
> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/website/
> >
> > Should we release this candidate?
> >
> > Enrico Olivelli
> >
>
Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 1
Posted by Szalay-Bekő Máté <sz...@gmail.com>.
+1 (non-binding)
- I built the source code (-Pfull-build) on Ubuntu 18.04.3 using OpenJDK
8u242 and maven 3.6.0.
- all the unit tests passed (both Java and C-client).
- I also built and executed unit tests for zkpython
- checkstyle and spotbugs passed
- apache-rat passed
- fatjar built
- I executed a quick rolling-upgrade test from 3.5.7 to 3.6.1. (using
https://github.com/symat/zk-rolling-upgrade-test)
On Tue, Apr 21, 2020 at 5:20 PM Enrico Olivelli <eo...@gmail.com> wrote:
> This is a release candidate for 3.6.1.
>
> It is a bugfix release and it introduces a few bugfixes and new features in
> these areas:
> - compatibility with applications built against 3.5 client libraries
> (restored a few non public APIs)
> - update Netty to 4.1.48.Final
> - ability to pass configuration as file in zkCli for TLS config
> - Add setKeepAlive support for NIOServerCnxn
> - Fix server side request throttling
>
> The full release notes is available at:
>
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12346764
>
> *** Please download, test and vote by April 14th 2020, 23:59 UTC+0. ***
>
> Source files:
> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/
>
> Maven staging repo:
> https://repository.apache.org/content/repositories/orgapachezookeeper-1058/
>
> The release candidate tag in git to be voted upon: release-3.6.1-1
> https://github.com/apache/zookeeper/tree/release-3.6.1-1
>
> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> https://www.apache.org/dist/zookeeper/KEYS
>
> The staging version of the website is:
> https://people.apache.org/~eolivelli/zookeeper-3.6.1-candidate-1/website/
>
> Should we release this candidate?
>
> Enrico Olivelli
>