You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2019/10/01 15:38:59 UTC
[GitHub] [maven-surefire] Col-E commented on a change in pull request #245:
Surefire-1584: Add option to rerun failing tests for JUnit5
Col-E commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5
URL: https://github.com/apache/maven-surefire/pull/245#discussion_r330129552
##########
File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java
##########
@@ -47,6 +47,7 @@
implements TestExecutionListener
{
private final ConcurrentMap<TestIdentifier, Long> testStartTime = new ConcurrentHashMap<>();
+ private final ConcurrentMap<TestIdentifier, TestExecutionResult> failures = new ConcurrentHashMap<>();
Review comment:
Clearing in `testPlanExecutionFinished` doesn't allow the data to be accessible when referenced in `JUnitPlatformProvider#invokeAllTests`. Having it clear per-test in `testPlanExecutionStarted` keeps the expected behavior.
Moving the `failures.clear()` as detailed resolves the ITS failures mentioned today:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services