[jira] [Commented] (JCR-3514) Error in RepositoryImpl class

["Stefan Guggisberg (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCR-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576704#comment-13576704 ] 

Stefan Guggisberg commented on JCR-3514:
----------------------------------------

bq. The condition should rather be if (!initialized || !active) { 
instead of if (!initialized || active) { 

the condition is correct as is.

a workspace is considered active if there are sessions connected to it or if there's a current GC task accessing it.

a workspace is considered idle it it's not active. 

disposeIfIdle should never dispose an active workspace, hence the if-statement.

see also JCR-2749
                
> Error in RepositoryImpl class
> -----------------------------
>
>                 Key: JCR-3514
>                 URL: https://issues.apache.org/jira/browse/JCR-3514
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-core
>    Affects Versions: 2.4.2
>            Reporter: Sarfaraaz ASLAM
>            Assignee: Stefan Guggisberg
>
> Can you please verify line 2123 of RepositoryImpl class.
> The condition should rather be  if (!initialized || !active) {
> instead of  if (!initialized || active) {

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira