You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/21 10:45:10 UTC

[GitHub] [arrow-datafusion] tustvold opened a new pull request, #2305: Make SortPreservingMerge Usable Outside Tokio (#2201)

tustvold opened a new pull request, #2305:
URL: https://github.com/apache/arrow-datafusion/pull/2305

   # Which issue does this PR close?
   
   Closes #2201
   
    # Rationale for this change
   
   Allows using SortPreservingMerge outside of a tokio context
   
   # What changes are included in this PR?
   
   Makes SortPreservingMerge fallback to lazy evaluation outside of a tokio context
   
   # Are there any user-facing changes?
   
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] tustvold merged pull request #2305: Make SortPreservingMerge Usable Outside Tokio (#2201)

Posted by GitBox <gi...@apache.org>.
tustvold merged PR #2305:
URL: https://github.com/apache/arrow-datafusion/pull/2305


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] tustvold commented on pull request #2305: Make SortPreservingMerge Usable Outside Tokio (#2201)

Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #2305:
URL: https://github.com/apache/arrow-datafusion/pull/2305#issuecomment-1105077501

   The compiler error is... Unhelpful...
   
   ```
   error: implementation of `FnOnce` is not general enough
      --> datafusion/core/src/physical_plan/sorts/sort_preserving_merge.rs:157:44
       |
   157 |       ) -> Result<SendableRecordBatchStream> {
       |  ____________________________________________^
   158 | |         debug!(
   159 | |             "Start SortPreservingMergeExec::execute for partition: {}",
   160 | |             partition
   ...   |
   240 | |         }
   241 | |     }
       | |_____^ implementation of `FnOnce` is not general enough
   ```
   
   :rage: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org