You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/08/26 07:16:36 UTC

[GitHub] [incubator-ratis] amaliujia opened a new pull request #183: RATIS-624. RaftServer should support pause/ unpause in its LifeCycle state

amaliujia opened a new pull request #183:
URL: https://github.com/apache/incubator-ratis/pull/183


   ## What changes were proposed in this pull request?
   
   An effort to suppor `pause` in Raft, which can be used to pause a server (most likely follower).
   
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/RATIS-624
   
   ## How was this patch tested?
   
   N/A
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] szetszwo commented on pull request #183: RATIS-624. RaftServer should support pause/ unpause in its LifeCycle state

Posted by GitBox <gi...@apache.org>.
szetszwo commented on pull request #183:
URL: https://github.com/apache/incubator-ratis/pull/183#issuecomment-681088525


   I have briefly checked the code change.  Let's discuss the design in the JIRA.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] amaliujia commented on pull request #183: RATIS-624. RaftServer should support pause/ unpause in its LifeCycle state

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #183:
URL: https://github.com/apache/incubator-ratis/pull/183#issuecomment-680707327


   @szetszwo @hanishakoneru 
   
   I am working on adding `pause` to Ratis. As RATIS-624 describes, it is useful when a follower is lagging behind. When that happens, we can pause that follower and then do a snapshot install to help that follower catches up.
   
   This PR is still WIP. As I kept hacking a solution, I realized it is a fairly complicated change (at least to me).  
   
   Can I ask for some help: am I working on the right track? Am I adding the API in the right classes (e.g. RaftClient, RaftServerProxy, etc.) Any suggestions that I can improve my current thought?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] amaliujia commented on pull request #183: RATIS-624. RaftServer should support pause/ unpause in its LifeCycle state

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #183:
URL: https://github.com/apache/incubator-ratis/pull/183#issuecomment-682210650


   Per the discussion in JIRA, this work will break into several JIRA so will close this draft now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] amaliujia closed pull request #183: RATIS-624. RaftServer should support pause/ unpause in its LifeCycle state

Posted by GitBox <gi...@apache.org>.
amaliujia closed pull request #183:
URL: https://github.com/apache/incubator-ratis/pull/183


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] amaliujia commented on pull request #183: RATIS-624. RaftServer should support pause/ unpause in its LifeCycle state

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #183:
URL: https://github.com/apache/incubator-ratis/pull/183#issuecomment-681019415


   Or, can I tackle this problem by starting from server implementation without considering client/rpc call? (not sure as this is the first time I touch Ratis core).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org