You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Shajini Thayasingh (Code Review)" <ge...@cloudera.org> on 2021/02/26 19:39:50 UTC
[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added argument
Shajini Thayasingh has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17131
Change subject: IMPALA-10538: [DOCS] Document the newly added argument
......................................................................
IMPALA-10538: [DOCS] Document the newly added argument
discussed the newly added scale argument of ndv function
elaborated how this argument maps to a precision used by the HLL algorithm
Change-Id: Iec8007b79afac59cdfb3984bb111806213c21c77
---
M docs/topics/impala_ndv.xml
1 file changed, 24 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/17131/1
--
To view, visit http://gerrit.cloudera.org:8080/17131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec8007b79afac59cdfb3984bb111806213c21c77
Gerrit-Change-Number: 17131
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added NDV parameter
Posted by "Shajini Thayasingh (Code Review)" <ge...@cloudera.org>.
Hello Tamas Mate, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17131
to look at the new patch set (#3).
Change subject: IMPALA-10538: [DOCS] Document the newly added NDV parameter
......................................................................
IMPALA-10538: [DOCS] Document the newly added NDV parameter
Added how this argument maps to a precision used by the HLL algorithm.
Change-Id: Iec8007b79afac59cdfb3984bb111806213c21c77
---
M docs/topics/impala_ndv.xml
1 file changed, 34 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/17131/3
--
To view, visit http://gerrit.cloudera.org:8080/17131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iec8007b79afac59cdfb3984bb111806213c21c77
Gerrit-Change-Number: 17131
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added NDV parameter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17131 )
Change subject: IMPALA-10538: [DOCS] Document the newly added NDV parameter
......................................................................
IMPALA-10538: [DOCS] Document the newly added NDV parameter
Added how this argument maps to a precision used by the HLL algorithm.
Incorporated changes from the feedback.
Change-Id: Iec8007b79afac59cdfb3984bb111806213c21c77
Reviewed-on: http://gerrit.cloudera.org:8080/17131
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/topics/impala_ndv.xml
1 file changed, 36 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec8007b79afac59cdfb3984bb111806213c21c77
Gerrit-Change-Number: 17131
Gerrit-PatchSet: 6
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added NDV parameter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17131 )
Change subject: IMPALA-10538: [DOCS] Document the newly added NDV parameter
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/371/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec8007b79afac59cdfb3984bb111806213c21c77
Gerrit-Change-Number: 17131
Gerrit-PatchSet: 5
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 23:26:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added argument
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17131 )
Change subject: IMPALA-10538: [DOCS] Document the newly added argument
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/622/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/17131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec8007b79afac59cdfb3984bb111806213c21c77
Gerrit-Change-Number: 17131
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Feb 2021 19:40:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added NDV parameter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17131 )
Change subject: IMPALA-10538: [DOCS] Document the newly added NDV parameter
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/623/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/17131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec8007b79afac59cdfb3984bb111806213c21c77
Gerrit-Change-Number: 17131
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Mar 2021 17:43:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added NDV parameter
Posted by "Shajini Thayasingh (Code Review)" <ge...@cloudera.org>.
Hello Tamas Mate, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17131
to look at the new patch set (#2).
Change subject: IMPALA-10538: [DOCS] Document the newly added NDV parameter
......................................................................
IMPALA-10538: [DOCS] Document the newly added NDV parameter
discussed the newly added scale argument of ndv function
added how this argument maps to a precision used by the HLL algorithm
Change-Id: Iec8007b79afac59cdfb3984bb111806213c21c77
---
M docs/topics/impala_ndv.xml
1 file changed, 33 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/17131/2
--
To view, visit http://gerrit.cloudera.org:8080/17131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iec8007b79afac59cdfb3984bb111806213c21c77
Gerrit-Change-Number: 17131
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added NDV parameter
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/17131 )
Change subject: IMPALA-10538: [DOCS] Document the newly added NDV parameter
......................................................................
Patch Set 2:
(5 comments)
Hi Shajini, thank you for the update.
Just a few nits, outside of those looks good to me.
Impala commit messages usually explain the change and are complete sentences, left a few nits on the commit message.
http://gerrit.cloudera.org:8080/#/c/17131/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17131/2//COMMIT_MSG@9
PS2, Line 9: discussed the newly added scale argument of ndv function
I think this part of the commit message is not relevant to the content of the commit. Could you remove it please?
http://gerrit.cloudera.org:8080/#/c/17131/2//COMMIT_MSG@10
PS2, Line 10: m
nit: missing punctuation mark
http://gerrit.cloudera.org:8080/#/c/17131/2//COMMIT_MSG@10
PS2, Line 10: a
nit: capital A
http://gerrit.cloudera.org:8080/#/c/17131/2/docs/topics/impala_ndv.xml
File docs/topics/impala_ndv.xml:
http://gerrit.cloudera.org:8080/#/c/17131/2/docs/topics/impala_ndv.xml@72
PS2, Line 72:
nit: empty tab
http://gerrit.cloudera.org:8080/#/c/17131/2/docs/topics/impala_ndv.xml@77
PS2, Line 77:
nit: empty tab
--
To view, visit http://gerrit.cloudera.org:8080/17131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec8007b79afac59cdfb3984bb111806213c21c77
Gerrit-Change-Number: 17131
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Mar 2021 09:57:05 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added NDV parameter
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17131 )
Change subject: IMPALA-10538: [DOCS] Document the newly added NDV parameter
......................................................................
Patch Set 4: Code-Review+2
LGTM, thanks for the fixes
--
To view, visit http://gerrit.cloudera.org:8080/17131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec8007b79afac59cdfb3984bb111806213c21c77
Gerrit-Change-Number: 17131
Gerrit-PatchSet: 4
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 23:21:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added argument
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/17131 )
Change subject: IMPALA-10538: [DOCS] Document the newly added argument
......................................................................
Patch Set 1:
(4 comments)
Hi Shajini, thank you for this doc update. I had a few observations/questions on the doc change and some on commit.
Impala commit messages are in general complete sentences and describe what the commit contains. Unfortunately, this part does not have anchor, so can not link directly, but at the end of the 'Fix' there is a short paragraph about the styling.
https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala
http://gerrit.cloudera.org:8080/#/c/17131/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17131/1//COMMIT_MSG@7
PS1, Line 7: argument
Could you change this to "NDV parameter"?
'NDV' to be more specific and 'parameter' because the function's definition has parameters, these called arguments when referring to then when the function is called.
http://gerrit.cloudera.org:8080/#/c/17131/1//COMMIT_MSG@10
PS1, Line 10: hm
This line is a bit long.
http://gerrit.cloudera.org:8080/#/c/17131/1/docs/topics/impala_ndv.xml
File docs/topics/impala_ndv.xml:
http://gerrit.cloudera.org:8080/#/c/17131/1/docs/topics/impala_ndv.xml@51
PS1, Line 51: <p> The argument <codeph>scale</codeph> must be an integer and can be in the range from 1 to 10
: and maps to a precision used by the HLL algorithm with the following mapping formula: </p>
:
: <p><codeblock>precision = scale + 8</codeblock></p>
I think an example at the end of the page could greatly help how the scale parameter affects the end result of NDV.
http://gerrit.cloudera.org:8080/#/c/17131/1/docs/topics/impala_ndv.xml@69
PS1, Line 69: Without the secondary argument, all the syntax and semantics of the NDV function are
: preserved. The precision, which determines the total number of different estimators in the HLL
: algorithm, will be still 10.
This looks odd in a user documentation, we should probably just share a default value, if my understanding is right 10 is the default.
--
To view, visit http://gerrit.cloudera.org:8080/17131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec8007b79afac59cdfb3984bb111806213c21c77
Gerrit-Change-Number: 17131
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Sun, 07 Mar 2021 15:36:31 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added NDV parameter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17131 )
Change subject: IMPALA-10538: [DOCS] Document the newly added NDV parameter
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/623/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/17131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec8007b79afac59cdfb3984bb111806213c21c77
Gerrit-Change-Number: 17131
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Mar 2021 17:36:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added NDV parameter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17131 )
Change subject: IMPALA-10538: [DOCS] Document the newly added NDV parameter
......................................................................
Patch Set 4:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/625/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/17131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec8007b79afac59cdfb3984bb111806213c21c77
Gerrit-Change-Number: 17131
Gerrit-PatchSet: 4
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Mar 2021 22:11:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added NDV parameter
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/17131 )
Change subject: IMPALA-10538: [DOCS] Document the newly added NDV parameter
......................................................................
Patch Set 3: Code-Review+1
Hi Shajini, thanks for the update. LGTM!
--
To view, visit http://gerrit.cloudera.org:8080/17131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec8007b79afac59cdfb3984bb111806213c21c77
Gerrit-Change-Number: 17131
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Mar 2021 07:56:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added NDV parameter
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17131 )
Change subject: IMPALA-10538: [DOCS] Document the newly added NDV parameter
......................................................................
Patch Set 3:
(5 comments)
Thanks for doing this, I have some suggestions/comments for making the docs clearer
http://gerrit.cloudera.org:8080/#/c/17131/3/docs/topics/impala_ndv.xml
File docs/topics/impala_ndv.xml:
http://gerrit.cloudera.org:8080/#/c/17131/3/docs/topics/impala_ndv.xml@49
PS3, Line 49: <codeblock>NDV([DISTINCT | ALL] <varname>expression</varname> [,scale])</codeblock>
Need to explain somewhere what scale is used if this parameter is not specified.
http://gerrit.cloudera.org:8080/#/c/17131/3/docs/topics/impala_ndv.xml@51
PS3, Line 51: <p> The argument <codeph>scale</codeph> must be an integer and can be in the range from 1 to 10
This seems a lot of detail for one optional argument. One way to deal with this might be to have some sort of heading like 'notes on the optional scale argument'.
http://gerrit.cloudera.org:8080/#/c/17131/3/docs/topics/impala_ndv.xml@52
PS3, Line 52: and maps to a precision used by the HLL algorithm with the following mapping formula: </p>
Expand HLL or explain what it means
http://gerrit.cloudera.org:8080/#/c/17131/3/docs/topics/impala_ndv.xml@64
PS3, Line 64: need of extra memory. For a given precision p, the amount of memory used by the HLL algorithm
Expand or explain HLL
http://gerrit.cloudera.org:8080/#/c/17131/3/docs/topics/impala_ndv.xml@69
PS3, Line 69: When provided a scale of 10 against a total of 22 distinct data sets loaded into external
I don't understand this sentence, is there a part missing?
--
To view, visit http://gerrit.cloudera.org:8080/17131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec8007b79afac59cdfb3984bb111806213c21c77
Gerrit-Change-Number: 17131
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Mar 2021 21:21:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added NDV parameter
Posted by "Shajini Thayasingh (Code Review)" <ge...@cloudera.org>.
Hello Andrew Sherman, Tamas Mate, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17131
to look at the new patch set (#4).
Change subject: IMPALA-10538: [DOCS] Document the newly added NDV parameter
......................................................................
IMPALA-10538: [DOCS] Document the newly added NDV parameter
Added how this argument maps to a precision used by the HLL algorithm.
Incorporated changes from the feedback.
Change-Id: Iec8007b79afac59cdfb3984bb111806213c21c77
---
M docs/topics/impala_ndv.xml
1 file changed, 36 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/17131/4
--
To view, visit http://gerrit.cloudera.org:8080/17131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iec8007b79afac59cdfb3984bb111806213c21c77
Gerrit-Change-Number: 17131
Gerrit-PatchSet: 4
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added NDV parameter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17131 )
Change subject: IMPALA-10538: [DOCS] Document the newly added NDV parameter
......................................................................
Patch Set 4: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/625/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/17131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec8007b79afac59cdfb3984bb111806213c21c77
Gerrit-Change-Number: 17131
Gerrit-PatchSet: 4
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Mar 2021 22:18:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added NDV parameter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17131 )
Change subject: IMPALA-10538: [DOCS] Document the newly added NDV parameter
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec8007b79afac59cdfb3984bb111806213c21c77
Gerrit-Change-Number: 17131
Gerrit-PatchSet: 5
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 23:26:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added argument
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17131 )
Change subject: IMPALA-10538: [DOCS] Document the newly added argument
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/622/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/17131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec8007b79afac59cdfb3984bb111806213c21c77
Gerrit-Change-Number: 17131
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Feb 2021 19:47:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added NDV parameter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17131 )
Change subject: IMPALA-10538: [DOCS] Document the newly added NDV parameter
......................................................................
Patch Set 3:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/624/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/17131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec8007b79afac59cdfb3984bb111806213c21c77
Gerrit-Change-Number: 17131
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Mar 2021 17:50:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added NDV parameter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17131 )
Change subject: IMPALA-10538: [DOCS] Document the newly added NDV parameter
......................................................................
Patch Set 3: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/624/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/17131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec8007b79afac59cdfb3984bb111806213c21c77
Gerrit-Change-Number: 17131
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Mar 2021 17:57:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added NDV parameter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17131 )
Change subject: IMPALA-10538: [DOCS] Document the newly added NDV parameter
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec8007b79afac59cdfb3984bb111806213c21c77
Gerrit-Change-Number: 17131
Gerrit-PatchSet: 5
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 23:35:47 +0000
Gerrit-HasComments: No