You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/22 01:36:00 UTC
[GitHub] [spark] desmondcheongzx opened a new pull request, #38749: Refactor by introducing physical types
desmondcheongzx opened a new pull request, #38749:
URL: https://github.com/apache/spark/pull/38749
### What changes were proposed in this pull request?
Refactor case matching for Spark types by introducing physical types. Since multiple logical types match to the same physical type (for e.g. `DateType` and `YearMonthIntervalType` are both implemented using an integer), we can case match on their physical types rather than listing all possible logical types.
### Why are the changes needed?
These changes simplify the Spark type system.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Since this code is a refactor of existing code, we rely on existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] desmondcheongzx closed pull request #38749: Refactor by introducing physical types
Posted by GitBox <gi...@apache.org>.
desmondcheongzx closed pull request #38749: Refactor by introducing physical types
URL: https://github.com/apache/spark/pull/38749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org